Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 12 Jul 2018 09:35:38 +0200
From:   Maxime Ripard <maxime.ripard@bootlin.com>
To:     Arnd Bergmann <arnd@arndb.de>
Cc:     Chen-Yu Tsai <wens@csie.org>, dri-devel@lists.freedesktop.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [v3] drm/sun4i: fix build failure with
 CONFIG_DRM_SUN8I_MIXER=m
Message-ID: <20180712073538.drmn75bp6xe5cniz@flea>
References: <20180711144403.1022829-1-arnd@arndb.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="v2vvhu7azu7inmri"
Content-Disposition: inline
In-Reply-To: <20180711144403.1022829-1-arnd@arndb.de>
User-Agent: NeoMutt/20180622
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--v2vvhu7azu7inmri
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jul 11, 2018 at 04:43:10PM +0200, Arnd Bergmann wrote:
> Having DRM_SUN4I built-in but DRM_SUN8I_MIXER as a loadable module result=
s in
> a link error, as we try to access a symbol from the sun8i_tcon_top.ko mod=
ule:
>=20
> ERROR: "sun8i_tcon_top_of_table" [drivers/gpu/drm/sun4i/sun8i-drm-hdmi.ko=
] undefined!
> ERROR: "sun8i_tcon_top_of_table" [drivers/gpu/drm/sun4i/sun4i-drm.ko] und=
efined!
>=20
> This solves the problem by adding a silent symbol for the tcon_top module,
> building it as a separate module in exactly the cases that we need it,
> but in a way that it is reachable by the other modules.
>=20
> Fixes: 57e23de02f48 ("drm/sun4i: DW HDMI: Expand algorithm for possible c=
rtcs")
> Fixes: ef0cf6441fbb ("drm/sun4i: Add support for traversing graph with TC=
ON TOP")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied, thanks!
Maxime

--=20
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

--v2vvhu7azu7inmri
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAltHBMkACgkQ0rTAlCFN
r3TR5g//VYb7CM4LY37INFtComYldKAjYiFTY8DqWfoHPehe03dpr0YXXOxeyaMk
9BQ99zMlHVcWZut9dnscl/B7b4RNVJCL5MoWpsJqrfk+02XjLn+wy7LWV9UIBODD
y4b58KrzTt6rSNyNBUulH5CxQfcU6rM0HvuClJMGk9PWSWRn1Q3/TJ93+MWDO64E
hKmRY/81738ElIeIG6UfqswFdqdee4TsrBAwfu84k/EcV3Sm8WUgwTp5MBBQB49+
1ba0qJfjwXJRi9YzO4pcAyDw3xW1Rsu8WAhZ9gUjZw9E5eMAi+zMrE4LhN0hH6k8
MFmObHQxDd4c3R78E6LG5T+2Q6EHak0zat+1mcaJcF/TnaSNp3imBl+bn53WQ2J/
Ed5myYjleU7ZzAOK8INur9+KmPEYqEgQlBeFecpau/SJsJ6nclCJnhu9N8tobt8g
mTAi/63u2Voo2NmR87kmN1o7EuXBI46yftyPRIiq1epJw5NZ/J0LQF9Yah6AlAlz
LvZ8spIOpWBaXIymxajqOyG2ccchkEUXaHRvLXOSiqqvvho5UBNRfHMrdP1zgdvb
DfgNuQhTGkIBbIh7lMjCapzKNzYrpya22TFvubVku0II84hdFOkNUQgeLQm2t3ev
abfsolIcuB3lofEw63k9XBE/K+O8ANWxN57Gvtb77NJRtYvK18Y=
=OTH+
-----END PGP SIGNATURE-----

--v2vvhu7azu7inmri--