Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1393255imm;
        Thu, 12 Jul 2018 00:45:16 -0700 (PDT)
X-Google-Smtp-Source: AAOMgpfutInFyhLbdHz/dLk6KLUpswnVfAhTaBumrRC0MrxRXISmPXcDJNUfoBiVwyHV/V4iDrAM
X-Received: by 2002:a63:f:: with SMTP id 15-v6mr1108722pga.430.1531381516062;
        Thu, 12 Jul 2018 00:45:16 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1531381516; cv=none;
        d=google.com; s=arc-20160816;
        b=RBWumdlEz5GiimO/0VSGPzE63OTpCZiXMBZcmAbhpLEngwxTlVwv5W2OvijctZ6Jzu
         3bBYs4Tz1qjfc4oKlAhjHvfrqC2kOhtpa2KH2BTtAuGnbUSN125IZNlRCOGXorfyEx50
         M6o/uVUJzqtSb8vqHfynIBufFvKkGofoiFSl8j718DQ2yq0tolZ7jrZMjGtxDL59qR9C
         6OaM8rfW6Xze0HufZzdYig7KTWN9EIljEO36iRtKsvOsSzm1S0rmoetGNy400vpVS/Hb
         n5pduND50TFw1Q0+ktl5IQGjsgmuaiUVjvI80a7ENVO0lNLtHxGhkf4TmETMxmhLraN6
         58CQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :arc-authentication-results;
        bh=c83kh3QcPijEHbPJsthjOwT4JOV+EJiLnFAXfMExx28=;
        b=prIrwMgBHrwGzj4ssAUOU2RUcv1z3KBi5yRoxNgkHMoXfRduTe1Vklk6A1rwTkvJK2
         T6gUiE9biUr8lSvx2CT9oe/aDjAdy7EtS81BlR+neduKXorrjJ6p8X27R2rAPSrghmtE
         fHErMY9w+oj4oHPQH33e4hd/gwDCZMrFy473p8edyZ3/dq/NTiPuPYQW2PtXa8r+HnjQ
         yRc2t1ff1sLmWWfhJdldhF/1GekvPz37w7Gq1unLtGs1fak2NcFeQ68Dx1Ql6ZD4WILa
         nusZS1JycXrXuSMdA6nhn68CVGh19vI9yJLOfMLgemQ3BOWKKkvqJCl80qBgqLrjvXdx
         uXSw==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id j61-v6si21242635plb.68.2018.07.12.00.44.59;
        Thu, 12 Jul 2018 00:45:16 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726755AbeGLHwq (ORCPT <rfc822;kerneldev.sdk@gmail.com>
        + 99 others); Thu, 12 Jul 2018 03:52:46 -0400
Received: from hqemgate14.nvidia.com ([216.228.121.143]:9660 "EHLO
        hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726227AbeGLHwq (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 12 Jul 2018 03:52:46 -0400
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1, AES128-SHA)
        id <B5b4706d50000>; Thu, 12 Jul 2018 00:44:21 -0700
Received: from HQMAIL101.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Thu, 12 Jul 2018 00:44:24 -0700
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Thu, 12 Jul 2018 00:44:24 -0700
Received: from dhcp-10-21-25-168 (10.21.25.201) by HQMAIL101.nvidia.com
 (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Thu, 12 Jul
 2018 07:44:21 +0000
Date:   Thu, 12 Jul 2018 10:44:16 +0300
From:   Aapo Vienamo <avienamo@nvidia.com>
To:     Jon Hunter <jonathanh@nvidia.com>
CC:     Peter De Schrijver <pdeschrijver@nvidia.com>,
        Prashant Gaikwad <pgaikwad@nvidia.com>,
        Michael Turquette <mturquette@baylibre.com>,
        "Stephen Boyd" <sboyd@kernel.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        <linux-kernel@vger.kernel.org>, <linux-clk@vger.kernel.org>,
        <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH v4 2/4] clk: tegra: refactor 7.1 div calculation
Message-ID: <20180712104416.7d2a6e14@dhcp-10-21-25-168>
In-Reply-To: <7022b1f4-97ac-aa1b-5c60-d7041da6704b@nvidia.com>
References: <1531154338-3998-1-git-send-email-avienamo@nvidia.com>
        <1531154338-3998-3-git-send-email-avienamo@nvidia.com>
        <5805047f-4099-db34-0759-42e4a9e11629@nvidia.com>
        <20180711080022.GB1636@tbergstrom-lnx.Nvidia.com>
        <ef90eb24-e993-9cc1-ac09-5afedeceba75@nvidia.com>
        <20180711111754.GC1636@tbergstrom-lnx.Nvidia.com>
        <7022b1f4-97ac-aa1b-5c60-d7041da6704b@nvidia.com>
X-NVConfidentiality: public
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.21.25.201]
X-ClientProxiedBy: UKMAIL102.nvidia.com (10.26.138.15) To HQMAIL101.nvidia.com
 (172.20.187.10)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 11 Jul 2018 16:14:13 +0100
Jon Hunter <jonathanh@nvidia.com> wrote:

> On 11/07/18 12:17, Peter De Schrijver wrote:
> > On Wed, Jul 11, 2018 at 09:42:20AM +0100, Jon Hunter wrote:  
> >>
> >> On 11/07/18 09:00, Peter De Schrijver wrote:  
> >>> On Tue, Jul 10, 2018 at 05:17:05PM +0100, Jon Hunter wrote:  
> >>>>
> >>>> On 09/07/18 17:38, Aapo Vienamo wrote:  
> >>>>> From: Peter De Schrijver <pdeschrijver@nvidia.com>
> >>>>>
> >>>>> Move this to a separate file so it can be used to calculate the sdmmc
> >>>>> clock dividers.  
> >>>>
> >>>> Sorry for not commenting sooner, but what is the motivation for moving
> >>>> this to its own file? I don't see why we need to do this in order to use
> >>>> elsewhere. Furthermore, the original file is quite aptly named 'clk-divider.c'
> >>>> and now we have a div71.c which seems quite specific.  
> >>>
> >>> How else would you do it?  
> >>
> >> Keep it in the same file?
> >>  
> > 
> > That seems odd. clk-divider.c is meant to implement a clock type, not
> > utility functions we happen to need in several types.  
> 
> I see, then why not have a clk-utils.c for stuff like this. I am painting
> the bikeshed here, but div71.c seems very specific and I still don't
> understand the 7.1 bit.

While the code could work with other dividers, it was called 7.1 because
the current usecases were only on 7.1 dividers. I can submit another
version with a different filename if other changes to the series come
about or if it's seen necessary to change div-frac.c from the latest
version of the series to something else.

 -Aapo