Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1508346imm;
        Thu, 12 Jul 2018 03:11:05 -0700 (PDT)
X-Google-Smtp-Source: AAOMgpdhHo0QS+lBznYwXeWuvs/cuflGnXTwzcLSVNaR30LClQ+Xjwp6pc2dWUZ69mxLH8SBeH8u
X-Received: by 2002:a63:8c0b:: with SMTP id m11-v6mr1522123pgd.372.1531390265129;
        Thu, 12 Jul 2018 03:11:05 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1531390265; cv=none;
        d=google.com; s=arc-20160816;
        b=AVzPIouQpYMgkFQpTs4Rl6k9LiCVYXcpp7VxzhVfkPEDrEJEt4E5QSvDAyOCUoANuQ
         sk1BV2++WEeZBjrUGYk2sHNUmzCh4LYtz7ZfMVvRUcDKWQkHav3Y/OUJPOtR9ihi7r1t
         xMrnIKE+/EJGn4yu36c3OKw4g94g1hKF2RYcbcXLs0eaGhS0AltyFFZFHJsntg4aLjH1
         dWUPSt++9EVeraaLcMYyowpXM9eMRpLthoZ0lcuTPUdHDoRkYpNtZ9SW97n22v+825sA
         0tAaXPT4ZIrf/QWO1UYS0aNwrlCTv5Ath/cuU9lAyGHkroSBnnpJGk7iIxjmNURRKq4A
         F6TQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject:arc-authentication-results;
        bh=uFYu/q/AQ1MDe620AGgGF504tx4yVoQAfOLJjbc3xhA=;
        b=BsQR8L75fOZR7q9yueBcFZiHRKk21Lr3kuNWy1TVbOAtFiQsCdV5apqoGwGZ7Akvvq
         QldJROJhkP0pf50sfqnyRtt3j8ZBncyTabM7+ilTlO/rPYtvLFlyR2mJq56fuqLLEgfI
         ywdf4cR8p3ysy27l8ygTV8vo5NBIRHKxB4KB58XQhL3t10NC76hExHQbVahhXtkTslYX
         WivYJUYKNu2mvUy3O5tjpR1B5vlAg0dlK2Fs6krzjxyae2OqP1flvpu+vsIfliJfgUlB
         ltkioV3BOShIsLc0ucARUcA7Xd6pnQXhdsfFpP1AyJlW/Bxe+5Y3H4ZTtjAZAW8jHp5Q
         Xr8A==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id e1-v6si21835116pli.6.2018.07.12.03.10.49;
        Thu, 12 Jul 2018 03:11:05 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726573AbeGLKTF (ORCPT <rfc822;kerneldev.sdk@gmail.com>
        + 99 others); Thu, 12 Jul 2018 06:19:05 -0400
Received: from hqemgate14.nvidia.com ([216.228.121.143]:16092 "EHLO
        hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726397AbeGLKTF (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 12 Jul 2018 06:19:05 -0400
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1, AES128-SHA)
        id <B5b4729020000>; Thu, 12 Jul 2018 03:10:10 -0700
Received: from HQMAIL101.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Thu, 12 Jul 2018 03:10:13 -0700
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Thu, 12 Jul 2018 03:10:13 -0700
Received: from [10.21.132.122] (10.124.1.5) by HQMAIL101.nvidia.com
 (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Thu, 12 Jul
 2018 10:10:08 +0000
Subject: Re: [PATCH v2 3/7] soc/tegra: pmc: Implement
 tegra_io_pad_is_powered()
To:     Aapo Vienamo <avienamo@nvidia.com>
CC:     Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        Mikko Perttunen <mperttunen@nvidia.com>,
        <devicetree@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <1531317693-3520-1-git-send-email-avienamo@nvidia.com>
 <1531317693-3520-4-git-send-email-avienamo@nvidia.com>
 <3ced704b-2a8b-b78c-3b1e-6c2d7562edcc@nvidia.com>
 <2d669942-0b4d-f48b-a8ba-67794485bf5f@nvidia.com>
 <20180712105247.121a5d13@dhcp-10-21-25-168>
From:   Jon Hunter <jonathanh@nvidia.com>
Message-ID: <5e041bd6-d152-30a9-e2f8-48552e50ccee@nvidia.com>
Date:   Thu, 12 Jul 2018 11:10:03 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <20180712105247.121a5d13@dhcp-10-21-25-168>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL104.nvidia.com (172.18.146.11) To
 HQMAIL101.nvidia.com (172.20.187.10)
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 12/07/18 08:52, Aapo Vienamo wrote:
> On Wed, 11 Jul 2018 16:26:42 +0100
> Jon Hunter <jonathanh@nvidia.com> wrote:
> 
>> On 11/07/18 16:23, Jon Hunter wrote:
>>>
>>> On 11/07/18 15:01, Aapo Vienamo wrote:  
>>>> Implement a function to query whether a pad is in deep power down mode.  
>>> Can you elaborate on why this public function is needed and who will be
>>> using this?  
>>
>> Or I should say does this need to be public?
> 
> It's only called from the pinconf callbacks and exposing it doesn't
> indeed make much sense if we intend to replace direct calls to pmc.c
> with pinctrl anyway. I'll make it private on the next iteration of the
> series.

Yes let's make it private.

Cheers
Jon

-- 
nvpublic