Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1897893imm; Thu, 12 Jul 2018 09:33:16 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeAlJnrhVbUPVy6DFArTTy1WhShfBVnJC84iZxU/7sszeCjbVGAISSKbPlvxqTrut+rg0n/ X-Received: by 2002:a62:642:: with SMTP id 63-v6mr3193102pfg.222.1531413196198; Thu, 12 Jul 2018 09:33:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531413196; cv=none; d=google.com; s=arc-20160816; b=aL6ulQryfBJaDpK9VYZBRIePHvP08vsuH2Vgiq4NqKBEri+yC9doFruKOif3j2TmUT SvFx7/9GzTIaW7cAjSlHshw4qrcHWVqSk6gFBFoSl/X+Q/OxT3HYv1X2qQ0bFHN47G7S 5RQhyWDKMlBY6eciyjXo40l/hSgRckdBYWVGXBIuqBY5pJqmSvtMAe0nBzXmYggqxzIX +BUf2ZgowcyO1EhrktlMMsbdOlg+X5wReU8p7BiQICxJzoBx67E5GNmUMWok+i6Tjw3c 6eJve8JsGjzNfVgBf14o5FO4WyZLpoQQcen/Dtkr2jMrECMXAQjHTVbBDmxPCm/OfPjb a/DQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature:arc-authentication-results; bh=FhpM/08uzNucjIkrBK1MW4AOCttLe59TUAf6vhz7Bdo=; b=tQXC3X51BAgyhuCGYUjwH4OfIgXNbNP3ipbNhE8EqKpmdWCVJm2aus1c/p/saXbghH nQW+J4JfzftqaVsgp8mMo2J9ApNtjr94AfPePZEhKvTwlv99+XRRLo/6xbBO7GiOKPyS OgUB0p4G2CYqMwkRYcqbQWieixXJSDJKAbvcAqRpXI7bzuUEGwx08EFOOBb7iWNcQ5Jm fBS5YK7kPDetdMeCnbQIWOOH1Om4tOvpBIUinDvU9vQHQtKXgsAJ0mL4VeByBTkfWiWN dbalc1P7/Efh9h27H6nDQrW3uaI612r96aBnWhlC1X2+aMiI7ukNIt4iyEoYqH7jVln8 P8iw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=VZ0otPOC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l88-v6si4099293pfi.179.2018.07.12.09.33.00; Thu, 12 Jul 2018 09:33:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=VZ0otPOC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732359AbeGLQmV (ORCPT + 99 others); Thu, 12 Jul 2018 12:42:21 -0400 Received: from mail-io0-f195.google.com ([209.85.223.195]:35052 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726816AbeGLQmV (ORCPT ); Thu, 12 Jul 2018 12:42:21 -0400 Received: by mail-io0-f195.google.com with SMTP id q4-v6so28784518iob.2; Thu, 12 Jul 2018 09:32:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=FhpM/08uzNucjIkrBK1MW4AOCttLe59TUAf6vhz7Bdo=; b=VZ0otPOC5r3NuziRW0eJhXGpsxJdmpnK2cvMu3jjx+5E2jvlVwCIMaH6bOCy8jxFoP I2Sn8TwrEWAdApy3+V4LBo5Ru+NpE07+V5WvEnQWzXNAmjI4Bi69XGFU8j9BnAv6DELK RYWj5Ngh4iF+g5460ECTyCoxPvA1lOTvAPBFI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=FhpM/08uzNucjIkrBK1MW4AOCttLe59TUAf6vhz7Bdo=; b=TfRuGpBQTDedHSLPZHCInC5VDT6ulaXJHvgtocR5O21czqAYiYbfDcXdozFlm+0HEH ybWWX+wj8co9bAwNuYBabrh4uHjIzBdjZFY/P5IUz5R5/RYm/99phLSn2oVJwgosTraZ 50/5LB/CHBgldn6A8kj8UtS3GZHGNBd696FKjBCfwcs2lmi6h2Rku41qrlm1y+hJ96b5 k51XFMSS1GocDCpl9jo02aCFyHL7VIBgq6NEVPa4nOw8RfXElcXRUsrUCtP3NmJ23z7s KdZC8nUjQI5mnuS9Nw+rIGwz1xD7W9LtsAoBDtBw9phFHdOV/jF9qm7oTqj8hMl5fnZy MW4A== X-Gm-Message-State: APt69E0rshxr4WW7Y3qab2h3Qtwc6M5puzR10NlAKbuWOeF3uhhnmPwH 77w5a2v5Ooa2owb+sYxpxQWbJ0bEu+0Vh7IhdJOz0cBY X-Received: by 2002:a6b:1502:: with SMTP id 2-v6mr29776048iov.203.1531413123824; Thu, 12 Jul 2018 09:32:03 -0700 (PDT) MIME-Version: 1.0 References: <153126248868.14533.9751473662727327569.stgit@warthog.procyon.org.uk> <153126264966.14533.3388004240803696769.stgit@warthog.procyon.org.uk> <686E805C-81F3-43D0-A096-50C644C57EE3@amacapital.net> <22370.1531293761@warthog.procyon.org.uk> <7002.1531407244@warthog.procyon.org.uk> <338BC3C4-F3E7-48F0-A82E-2C7295B6640E@amacapital.net> In-Reply-To: <338BC3C4-F3E7-48F0-A82E-2C7295B6640E@amacapital.net> From: Linus Torvalds Date: Thu, 12 Jul 2018 09:31:52 -0700 Message-ID: Subject: Re: [PATCH 24/32] vfs: syscall: Add fsopen() to prepare for superblock creation [ver #9] To: Andy Lutomirski Cc: David Howells , Andrew Lutomirski , Al Viro , Linux API , linux-fsdevel , Linux Kernel Mailing List , Jann Horn , Tycho Andersen Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 12, 2018 at 9:23 AM Andy Lutomirski wrote= : > > (Al- can=E2=80=99t we just stop allowing splice() at all on things that d= on=E2=80=99t use iov_iter?) We could add a FMODE_SPLICE_READ/WRITE bit, and let people opt in to splice. We probably should have. But again, that really doesn't change the fundamentals. Using write() for commands is stupid. It also means that you have to _parse_ all the damn input at that level, which is a mistake too. It easily leads to insane decisions like "you have to use 'write()' calls without buffering", because re-buffering the stream is a f*cking pain. Just say no. Seriously. Stop this idiotic discussion. I'm just happy this came up early, because that way I know to look out for it and not merge it. Linus