Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
USER-AGENT: NeoMutt/20170609 (1.8.3)
MIME-Version: 1.0
Message-ID: <20180713065721.a5cntccedumupewo@mwanda>
Date:   Thu, 12 Jul 2018 23:57:22 -0700 (PDT)
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Tuomas Tynkkynen <tuomas@tuxera.com>
Cc:     Stefan Wahren <stefan.wahren@i2se.com>, devel@driverdev.osuosl.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, Eric Anholt <eric@anholt.net>,
        linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] staging: bcm2835-audio: Check if workqueue allocation
 failed
References: <20180712215417.22491-1-tuomas@tuxera.com>
 <20180713064816.lv6qhkipi6fpeptj@mwanda>
In-Reply-To: <20180713064816.lv6qhkipi6fpeptj@mwanda>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Jul 13, 2018 at 09:48:16AM +0300, Dan Carpenter wrote:
> On Fri, Jul 13, 2018 at 12:54:16AM +0300, Tuomas Tynkkynen wrote:
> > @@ -424,7 +411,9 @@ int bcm2835_audio_open(struct bcm2835_alsa_stream *alsa_stream)
> >  	int status;
> >  	int ret;
> >  
> > -	my_workqueue_init(alsa_stream);
> > +	alsa_stream->my_wq = alloc_workqueue("my_queue", WQ_HIGHPRI, 1);
> > +	if (!alsa_stream->my_wq)
> > +		return -ENOMEM;
> >  
> >  	ret = bcm2835_audio_open_connection(alsa_stream);
> >  	if (ret) {
> 
> This patch is good but if bcm2835_audio_open_connection() fails then
> we need to release alsa_stream->my_wq.

Never mind, you handle it in the next patch.  The bug *was* there in the
original code as well, so that's a legit way to split the patches.

regards,
dan carpenter