Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp472704imm; Fri, 13 Jul 2018 00:20:43 -0700 (PDT) X-Google-Smtp-Source: AAOMgpecv5mmDkVoieeRRTBkOgzarhmEykWH5SZucR1f9368huCCaNnNpfYPLgk+JzTqyzqEseEc X-Received: by 2002:a17:902:8b86:: with SMTP id ay6-v6mr5262122plb.295.1531466443742; Fri, 13 Jul 2018 00:20:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531466443; cv=none; d=google.com; s=arc-20160816; b=JKimsWtPQGuEpnQbJgUoGL0nmsXf99mBc8eaHQDngNN5fR5fDEcoUCtjksP91kVPL2 3vdLojYyuNR5aOp6MFre3Gv/XY5SvoTV63Gd5GnpHlFTvk0pBP2fesvqnLnhBECs02sr 64Ln5FLLEm1Xq2ZZKeJwg/7O8dTI9FfPUsCEK98SVskQouVQRHx47dey8z9ahnA/k+CP TH73jxG5HNXG9lwnlRDrMbI4pt+8NavibdgWZDubR/4ngwzhjOQaw8pz8Sr2cjGA0mBc p2dqso9GOQWvT4AzurY15/aOpkkZiF8EZBuKujlZkMgRSuIHbqj2uYSmo1kvLNA/eCjs 9FrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:cc:references:to :subject:dkim-signature:arc-authentication-results; bh=I2cREey5FIKG4Fa5HZ/9cIvCQ2df3NNYcNUZ+XISqJk=; b=eJBfxnRolgzWSNuBjAIDO28eiFb+d3nENMfqlLp6fJFU0F30Gf4Z38+p58c+m7uU5K TPpw8dAVh7p2pu1fwHZQMueq86BKBTOaeDM/FpPYJdtw8YpWAWQTXkUOTnhqyg/zIe6o G6wljC5w1V3iPWhz5qvYh6uM8VqRACfebhsYx7WqnxRhuRz5a2IwW2WBzj6E4eXjb8kL upPcyhcAcAhV9yQu2hH8OjlS1RPIpyxd1ttxEKlkFAo/EXLXVGdLt0mIhJxXB1bUV+gZ C6ZbT1uceYl7to0YEPrLTY9KcW2ddw3rq6aYS8KggKMk6kf3mL8s93Yf3oWBiecs69r8 AAaA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=MGFiOmWy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x5-v6si21367288pgr.436.2018.07.13.00.20.27; Fri, 13 Jul 2018 00:20:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=MGFiOmWy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731350AbeGMHc5 (ORCPT + 99 others); Fri, 13 Jul 2018 03:32:57 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:37044 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729764AbeGMHc4 (ORCPT ); Fri, 13 Jul 2018 03:32:56 -0400 Received: by mail-wm0-f65.google.com with SMTP id n17-v6so8385995wmh.2 for ; Fri, 13 Jul 2018 00:19:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=I2cREey5FIKG4Fa5HZ/9cIvCQ2df3NNYcNUZ+XISqJk=; b=MGFiOmWyhvsKz2JWAoY9tqOQJiiHroOSa6h8v8QHh88PcOKyKUVmfYfR0mLQrPidjj ktfw0nkPP3CuxNEjHJDe4JHGZTY6fwIZyoEJyJIbo7A1EPkK/aPwb2LGXo32oPD122LT E+vWL6J0zPzMA2xvUfzCdxwu7YWepT39/aNs8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=I2cREey5FIKG4Fa5HZ/9cIvCQ2df3NNYcNUZ+XISqJk=; b=Wa0bQVSWkmdnFFhJ/0dCYwRqEHE5K2KuvjJ8LMZFpGTNLT0T2ewIpubQydUWw+xPnb CNVsX3Inc41mHNzrlnxSX869CsWsffSeAd6S0PkvnN+IAL4zStp/j8C24woSeils9tWC JGQSw6vuvhh4iqmrXUvMsUerTpdCR2VFwbhMC0kH90S86X7Ocee4xtiRCYomb/oz7IA5 fdZCCwhn/4EPf0IpubjLZWvpFwSY1ogHJmYNIMAZrMLYiBhTjo9ecqoU0/+icq8TBuW/ RgNzj8pZWeQHKCcOGIer1w6M/CCz1ScFTsRJENh83uBXsvpshYTF0O2QGE3jo9YZZz1I oBJA== X-Gm-Message-State: AOUpUlGpsLqg83p3hNsiAEiayz3mr5oeUNteKa8/Eezj4oPBbnXKWdn3 C5OGAUoM+jFgjgpHgU6zQ1MVFVul X-Received: by 2002:a1c:9290:: with SMTP id u138-v6mr3363362wmd.52.1531466375683; Fri, 13 Jul 2018 00:19:35 -0700 (PDT) Received: from [10.176.68.125] ([192.19.248.250]) by smtp.gmail.com with ESMTPSA id d18-v6sm1914775wrq.71.2018.07.13.00.19.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Jul 2018 00:19:34 -0700 (PDT) Subject: Re: [PATCH 10/18] brcmsmac: change strncpy+truncation to strlcpy To: Dominique Martinet References: <1531444483-17338-1-git-send-email-asmadeus@codewreck.org> <1531445147-19566-1-git-send-email-asmadeus@codewreck.org> Cc: Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , Kalle Valo , "David S. Miller" , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org From: Arend van Spriel Message-ID: <5B485285.7050603@broadcom.com> Date: Fri, 13 Jul 2018 09:19:33 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1531445147-19566-1-git-send-email-asmadeus@codewreck.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/13/2018 3:25 AM, Dominique Martinet wrote: > Generated by scripts/coccinelle/misc/strncpy_truncation.cocci Acked-by: Arend van Spriel > Signed-off-by: Dominique Martinet > --- > > Please see https://marc.info/?l=linux-kernel&m=153144450722324&w=2 (the > first patch of the serie) for the motivation behind this patch I would prefer to have the motivation in the commit message of this patch. Regards, Arend