Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] drm: mxsfb: fix runtime PM handling
To:     Anson Huang <Anson.Huang@nxp.com>, airlied@linux.ie,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc:     Linux-imx@nxp.com
References: <1531472085-25174-1-git-send-email-Anson.Huang@nxp.com>
From:   Marek Vasut <marex@denx.de>
Message-ID: <ea029b69-f853-4a5f-e798-70a04b02ac1d@denx.de>
Date:   Fri, 13 Jul 2018 11:03:15 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <1531472085-25174-1-git-send-email-Anson.Huang@nxp.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 07/13/2018 10:54 AM, Anson Huang wrote:
> As display power domain is combined with lcdif node
> on some i.MX platforms like i.MX6SL, when lcdif driver
> is enabled, the mxsfb_load is called to enable runtime
> pm, and a pair of pm_runtime_get_sync and
> pm_runtime_put_sync are also called, that will cause
> generic power domain driver to disable lcdif power domain
> and lcdif is no longer working, the lcdif power
> should ONLY be turned off when display is disabled,
> so move the pm_runtime_put_sync to mxsfb_unload
> and remove the pm_runtime_get_sync in mxsfb_unload
> as well, in this way, when display is enabled, the
> lcdif power will be always ON until the display
> is disabled.
> 
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>

Doesn't this also mean the block will always be on, thus wasting power ?

> ---
>  drivers/gpu/drm/mxsfb/mxsfb_drv.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> index ffe5137..1ba179b 100644
> --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> @@ -235,7 +235,6 @@ static int mxsfb_load(struct drm_device *drm, unsigned long flags)
>  
>  	pm_runtime_get_sync(drm->dev);
>  	ret = drm_irq_install(drm, platform_get_irq(pdev, 0));
> -	pm_runtime_put_sync(drm->dev);
>  
>  	if (ret < 0) {
>  		dev_err(drm->dev, "Failed to install IRQ handler\n");
> @@ -264,6 +263,7 @@ static int mxsfb_load(struct drm_device *drm, unsigned long flags)
>  err_irq:
>  	drm_panel_detach(mxsfb->panel);
>  err_vblank:
> +	pm_runtime_put_sync(drm->dev);
>  	pm_runtime_disable(drm->dev);
>  
>  	return ret;
> @@ -279,7 +279,6 @@ static void mxsfb_unload(struct drm_device *drm)
>  	drm_kms_helper_poll_fini(drm);
>  	drm_mode_config_cleanup(drm);
>  
> -	pm_runtime_get_sync(drm->dev);
>  	drm_irq_uninstall(drm);
>  	pm_runtime_put_sync(drm->dev);
>  
> 


-- 
Best regards,
Marek Vasut