Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp569685imm; Fri, 13 Jul 2018 02:30:51 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcmaKu8i/hifPiZ8D4iHcSLgfo2CsM0ALJiwA2XdxnFYVdYWpdRMqtWVoJDguncJ44UeOEz X-Received: by 2002:a63:b504:: with SMTP id y4-v6mr4867119pge.247.1531474251907; Fri, 13 Jul 2018 02:30:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531474251; cv=none; d=google.com; s=arc-20160816; b=0euW8gVbgJIjBr2VTA/aePYYfaIPFJsNXAL52lbINpjA5lPfNQyrRHv3yyPTervt28 SgLj/YibkowB65HOB+Sdt9XfqJDO7VunO2+aylYm7hsMe71hx8aH/9Pqxs69KLVKBRzf XslEfJoWE/d06BeA1a/X1K98XdGXBYFOR//ND7bxVAaXmS++FIZuBGjmDx1yMgOjeaX9 Pp2J6mUttQ2ZrVhPJcn6NrCe5X2Yotg9HHBUFtsgBS5nWFFiXJzqJEF6g8BOMUrKQ9kb 7wE9+5wkselZzW52MD74PROUq4VtcKWhWmFd17gjdstd1LnBaItwwjAqMiPRIBFDahyH mTWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:arc-authentication-results; bh=PSoRrHyXghSSTDppw58tFNcKnCJQ1+3pZGgNit6FHUM=; b=SLdAfyNpOnMcwqsLhhtj0qmxx+ldqfUuDSU2knNrbBBQaGnOHqtAt0ugvZdLqqVMpO xoIm5G6vbQQuiz7CihSLtXVx56LyHvKp0BEJWEluvicA6Fy8nSMN4L19JVRvT+2c5uim 9BJDDpCrUVAm6DJOBjhF2hGREtLIkVcmzW7ClXWSn9wnfhnmCE/veefQtxdI1YChfv+U ziUpkatZQ2pH0KGmvjCICUPp63oYJWm6vOxjH8ee7SnJ/BdV9YKsY0HIBfOiUvC9KVxa XDkEE+IQHYWHOdOrsqWdP+H2vhpf5Ia93xwmUysmp0nW2YF2zlHbQEcbl3Ed+iFSmwYn Ns7w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 1-v6si24037797plv.16.2018.07.13.02.30.36; Fri, 13 Jul 2018 02:30:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729175AbeGMJnr (ORCPT + 99 others); Fri, 13 Jul 2018 05:43:47 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:59264 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726380AbeGMJnr (ORCPT ); Fri, 13 Jul 2018 05:43:47 -0400 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1fduOi-0004Rn-CQ; Fri, 13 Jul 2018 09:29:56 +0000 From: Colin King To: Alan Stern , Greg Kroah-Hartman , linux-usb@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] usb: host: ehci-sched: remove redundant pointer dev Date: Fri, 13 Jul 2018 10:29:56 +0100 Message-Id: <20180713092956.13247-1-colin.king@canonical.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King Pointer dev is being assigned but is never used hence it is redundant and can be removed. Cleans up clang warning: warning: variable 'dev' set but not used [-Wunused-but-set-variable] Signed-off-by: Colin Ian King --- drivers/usb/host/ehci-sched.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/usb/host/ehci-sched.c b/drivers/usb/host/ehci-sched.c index 1d87295682b8..da7b00a6110b 100644 --- a/drivers/usb/host/ehci-sched.c +++ b/drivers/usb/host/ehci-sched.c @@ -1835,7 +1835,6 @@ static bool itd_complete(struct ehci_hcd *ehci, struct ehci_itd *itd) unsigned uframe; int urb_index = -1; struct ehci_iso_stream *stream = itd->stream; - struct usb_device *dev; bool retval = false; /* for each uframe with a packet */ @@ -1886,7 +1885,6 @@ static bool itd_complete(struct ehci_hcd *ehci, struct ehci_itd *itd) */ /* give urb back to the driver; completion often (re)submits */ - dev = urb->dev; ehci_urb_done(ehci, urb, 0); retval = true; urb = NULL; @@ -2230,7 +2228,6 @@ static bool sitd_complete(struct ehci_hcd *ehci, struct ehci_sitd *sitd) u32 t; int urb_index; struct ehci_iso_stream *stream = sitd->stream; - struct usb_device *dev; bool retval = false; urb_index = sitd->index; @@ -2268,7 +2265,6 @@ static bool sitd_complete(struct ehci_hcd *ehci, struct ehci_sitd *sitd) */ /* give urb back to the driver; completion often (re)submits */ - dev = urb->dev; ehci_urb_done(ehci, urb, 0); retval = true; urb = NULL; -- 2.17.1