Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp623200imm; Fri, 13 Jul 2018 03:35:39 -0700 (PDT) X-Google-Smtp-Source: AAOMgpe3X+Pd/43g0lwJN+oq3wDrP375W6MIIZe0pBOLwok/an0qiqMq+ImLZKx+yYXN+unSKffR X-Received: by 2002:a65:60cf:: with SMTP id r15-v6mr5576730pgv.41.1531478139355; Fri, 13 Jul 2018 03:35:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531478139; cv=none; d=google.com; s=arc-20160816; b=NEQtSZ3w4kJYcM7L8oGa9Z3YfNos4qHStbBs8OXAEmfyfodFbd4hcHZ5Y79m2D3BZF p16ed2HBHHRoEIIFkdlfOTbanu0yXVt2StOzqKuh4rc3n85f9qJ03aWRvPr8U/Dqjrl1 g+gQmm7huIa0iEHddpzbC/5Iad3NOcoswJpMXHWI9sEg1cji4gsA3TuFcmRfssxnYyYB w/zbe5UZTczJXNm6bhSdyF6ujvOKsbZjIyZa7gR613WTgXo8zxAQ+G4dQTPlMd7I9PNI k/U/Cc2AJx78Anskh0OuS3fAVMrGpOVdfaMqsrKGvuaK5V0xV/6x0kF0DIwQCf93mWdF rHLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date :arc-authentication-results; bh=Uewxo/FWmQfBKAngFel1SxZbrwtDhaxDrhNzbhzErJc=; b=LMpXcybw1k4kWtbuLHzRdaLdOx3/1xcQivhgQmVctffsBl0JGozwooGoMIN/75hRwS J9KoU5W66DUAHgdg/XhoPD8b+nLdOPjiyS9r+APzmqj+g0fnX3KHaUqVjGffSep97tFm F6e24ASN1D2c+fdc7YaetLfvkQxFY5MAJvYtZUuxNpgu0RD+FbrazJWFCGsJ3eLjxbvF jC/2sWYOwcwzQYZrOqZ/VPY15U442CpFrX6fq/S55iuyHuFAhiGexcdDu9b7/Nwf4Fhi CQA4+CwtBUGQ1t6RxdMqE+pl6D6b5Bi7keOv9fGtyiuY4Ys8JLJXfog2pl1Z4U/TsCKW x5MA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u7-v6si21723636pgr.593.2018.07.13.03.35.24; Fri, 13 Jul 2018 03:35:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729731AbeGMKs0 (ORCPT + 99 others); Fri, 13 Jul 2018 06:48:26 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:52356 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727147AbeGMKs0 (ORCPT ); Fri, 13 Jul 2018 06:48:26 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1fdvOw-00086p-V3; Fri, 13 Jul 2018 18:34:15 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1fdvOs-0007EE-9n; Fri, 13 Jul 2018 18:34:10 +0800 Date: Fri, 13 Jul 2018 18:34:10 +0800 From: Herbert Xu To: Stephan =?iso-8859-1?Q?M=FCller?= Cc: syzbot , davem@davemloft.net, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: [PATCH v4] AF_ALG: Initialize sg_num_bytes in error code path Message-ID: <20180713103410.5ox6imgi75w47kpv@gondor.apana.org.au> References: <00000000000092ad87056950ef9e@google.com> <1612449.5GibSviISC@positron.chronox.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1612449.5GibSviISC@positron.chronox.de> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 07, 2018 at 08:41:47PM +0200, Stephan M?ller wrote: > Changes v4: > * Add Fixes and CC line > > Changes v3: > * Fix syz testing line > > Changes v2: > * Addition of syz testing line > > ---8<--- > > The RX SGL in processing is already registered with the RX SGL tracking > list to support proper cleanup. The cleanup code path uses the > sg_num_bytes variable which must therefore be always initialized, even > in the error code path. > > Signed-off-by: Stephan Mueller > Reported-by: syzbot+9c251bdd09f83b92ba95@syzkaller.appspotmail.com > #syz test: https://github.com/google/kmsan.git master > CC: #4.14 > Fixes: e870456d8e7c ("crypto: algif_skcipher - overhaul memory management") > Fixes: d887c52d6ae4 ("crypto: algif_aead - overhaul memory management") Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt