Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 13 Jul 2018 14:07:15 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Marco Felsch <m.felsch@pengutronix.de>
Cc:     lgirdwood@gmail.com, m.purski@samsung.com, p.paillet@st.com,
        linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] regulator: core: fix _regulator_do_disable return value
Message-ID: <20180713130715.GC16228@sirena.org.uk>
References: <20180713125624.13783-1-m.felsch@pengutronix.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="i7F3eY7HS/tUJxUd"
Content-Disposition: inline
In-Reply-To: <20180713125624.13783-1-m.felsch@pengutronix.de>
User-Agent: Mutt/1.10.0 (2018-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--i7F3eY7HS/tUJxUd
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Jul 13, 2018 at 02:56:24PM +0200, Marco Felsch wrote:

> Currently _regulator_do_disable returns 0 if either the ena_pin nor the
> ops.disbale() isn't present. This assumes that the call was successful
> but it wasn't because disbaling isn't supported at all.

> The last case of the if-chain should return -EINVAL, because disabling
> isn't supported by the driver as it is done already by
> _regulator_do_enable.

This is fine - consumers shouldn't expect that a disable will cause
anything to actually get powered off, constraints or other consumers
might mean that the disable doesn't actually happen.  It's just the same
as a consumer with an always on flag.

--i7F3eY7HS/tUJxUd
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAltIpAIACgkQJNaLcl1U
h9B9mQf/ax9GM8TSDGqtJxZefWQsqlxrr+W7rvgFTQZGIl7VXnsUAsodkUTGU58F
A2h920f73/Wuqz6j3aZgTna2XU/8gHF2CVsMlwp7t21TrEwdlvYFAsJ6stO//SgC
EvGJauF/8YemoWMDG/4IB/DWZgTiGsgjPOsda+jExjKOkDxiEgBWHIscWA7cvqyx
RtpcNlIV39S1eV9584OFV97D61XqSRayBcoPpUvfQAzBUM5VmqAq81ckNbIFIr8A
LbarhKL6+xonXHK6WZI2QyVNg0LfpaJLBeOosQwJp5mZKfQrRrk+DbWkdzqs4xps
glBNqM2BPIiSnSlTE1Z8oCsj1m144Q==
=QqU9
-----END PGP SIGNATURE-----

--i7F3eY7HS/tUJxUd--