Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v5 1/2] timers: Don't wake ktimersoftd on every tick
To:     Anna-Maria Gleixner <anna-maria@linutronix.de>
Cc:     linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        harisokn@gmail.com, bigeasy@linutronix.de, tglx@linutronix.de,
        julia.cartwright@ni.com, gratian.crisan@ni.com, daniel@bristot.me,
        efault@gmx.de
References: <7d21ff63-3dce-b8ea-a0f1-81d53617747d@ni.com>
 <20180628164036.27378-1-haris.okanovic@ni.com>
 <alpine.DEB.2.21.1807131354560.2242@somnus>
From:   Haris Okanovic <haris.okanovic@ni.com>
Message-ID: <cba32de4-7b04-52d3-a068-909d675604f0@ni.com>
Date:   Fri, 13 Jul 2018 09:37:52 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.21.1807131354560.2242@somnus>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Received-SPF: None (protection.outlook.com: ni.com does not designate
 permitted sender hosts)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2018 14:37:54.6490 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 9cefd708-a0c0-4420-fe42-08d5e8ce3859
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 87ba1f9a-44cd-43a6-b008-6fdb45a5204e
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR04MB4639
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-07-13_05:,,
 signatures=0
X-Proofpoint-Spam-Details: rule=inbound_policy_notspam policy=inbound_policy score=30
 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0
 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0
 mlxlogscore=358 adultscore=0 classifier=spam adjust=30 reason=mlx
 scancount=1 engine=8.0.1-1806210000 definitions=main-1807130123
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Sounds good. I'll keep an eye out for your patch set and try it on my 
boards as well. CC me if you can.

-- Haris


On 07/13/2018 07:01 AM, Anna-Maria Gleixner wrote:
> Hi Haris,
> 
> On Thu, 28 Jun 2018, Haris Okanovic wrote:
> 
>> Collect expired timers in interrupt context to avoid overhead of waking
>> ktimersoftd on every scheduler tick.
>>
>> This is implemented by storing lists of expired timers in the timer_base
>> struct, which is updated by the interrupt routing on each tick in
>> run_local_timers(). TIMER softirq (ktimersoftd) is then raised only when
>> one or more expired timers are collected.
>>
>> Performance impact on a 2core Intel Atom E3825 system:
>>   * reduction in small latency spikes measured by cyclictest
>>   * ~30% fewer context-switches measured by perf
>>   * run_local_timers() execution time increases by 0.2 measured by TSC
>>
> 
> I'm also working on timer improvements at the moment. When I fixed all
> my bugs in my implementation (there is a last horrible one), I'm very
> interested in integrating your patches into my testing to be able to
> give you a tested-by.
> 
> Thanks,
> 
> 	Anna-Maria
>