Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261839AbTIPLl4 (ORCPT ); Tue, 16 Sep 2003 07:41:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261842AbTIPLlz (ORCPT ); Tue, 16 Sep 2003 07:41:55 -0400 Received: from meryl.it.uu.se ([130.238.12.42]:6306 "EHLO meryl.it.uu.se") by vger.kernel.org with ESMTP id S261839AbTIPLlz (ORCPT ); Tue, 16 Sep 2003 07:41:55 -0400 Date: Tue, 16 Sep 2003 13:41:52 +0200 (MEST) Message-Id: <200309161141.h8GBfqZv012047@harpo.it.uu.se> From: Mikael Pettersson To: davej@codemonkey.org.uk Subject: agpgart's MODULE_ALIAS is broken Cc: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 743 Lines: 23 Dave, With 2.6.0-test5, the generated alias for agpgart in modules.alias looks wrong: alias char-major-10-AGPGART_MINOR agpgart Surely that should be char-major-10-175. The problem is that AGP's MODULE_ALIAS_MISCDEV() is in backend.c, but AGPGART_MINOR isn't #define:d there because agpgart.h is only #include:d in frontend.c. This causes MODULE_ALIAS_MISCDEV()'s __stringify() to convert the token itself rather than its value. Should be easy to fix (move the ALIAS or add #include). /Mikael - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/