Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1044987imm; Fri, 13 Jul 2018 10:30:15 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcPICzUp2KSlcZR35xC+1IYqBfXzA7AYE4lU+sFk+dNWn6Dk6muouhysQDfFfRO09/3lqwC X-Received: by 2002:a63:375b:: with SMTP id g27-v6mr7000342pgn.59.1531503015301; Fri, 13 Jul 2018 10:30:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531503015; cv=none; d=google.com; s=arc-20160816; b=mf8Qo7cvUcVBq1gxdFu2xGk+hLXfy9mpKXK1CgKMYnKRS9h4jQ1iogmxasbho6LaiT EkX/Q2oQVpxePmA85RLmswQa/yl2P9MSU23vVJ6q/d/TSX/XW3aRcc+iNu39VQTB2LlZ YmRddcnY+E8rVeZhqZgRHrjSDgExQ9Aq4fmf7PVubwcffprE5RbxYv+ydexsXZrWVX2R OeFHOP/PfGCWdZtsf1NjmhNtua/PgaYGZwOU88LyDJbQEvjD9KP0PaLH8daFVBY431ZH Z/nVlAktaAO/OpErHvvL1y2rZC42vnvrG0DsWJNXoK/dwrCBsUoXjWGLw/HQtOMPXl3L oPww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=ZszZlBHTPABHo5NkbIkNv+m8IAV9wr+lL8FO08FuVdA=; b=BhnTYen1aoXzaEi8UjbS5llKfrvsdk0/Uyd31FFt5cnOhzuSrZS/7uH8pIqfSwJqt4 7gkiFgUsuFad6UD07kMktBfFhJy8SnPGZ6jgC+Rajrkj5wNsK5PfWgSRNu6I10y8zcBM Ozi/cSYtiiS6yw4MD7N/KRDcoxMTX3Vh86Igc8sYk8G/+W9ASLn9ThPGK2yD4/jLYttq 2x2L/ZyuZo7/y+PmRdslX05XiyxNgqWnBiGHlTlZNSxWUPBuw1RyH1Ev8znlFcLBJg/m kaUHd7cbJVlQm+tSdyJnkCmAUe0/iDWzsS6CDPO2tsp+/Vh2GvB/xrFNJUZhOIWZvApr y1oA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=jcB4HrdC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c15-v6si22673940pgw.550.2018.07.13.10.29.59; Fri, 13 Jul 2018 10:30:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=jcB4HrdC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731493AbeGMRoq (ORCPT + 99 others); Fri, 13 Jul 2018 13:44:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:42204 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730017AbeGMRoq (ORCPT ); Fri, 13 Jul 2018 13:44:46 -0400 Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6C6E0214D5 for ; Fri, 13 Jul 2018 17:29:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1531502952; bh=ZszZlBHTPABHo5NkbIkNv+m8IAV9wr+lL8FO08FuVdA=; h=In-Reply-To:References:From:Date:Subject:To:Cc:From; b=jcB4HrdCDaSyeKhmdBQUqRaqTCCfYSUcM0LVsVAiAZuKXG9YTBfFFmcaWRfLp3znt JNSdz1A0SE/KmThtE4DIxCbrAx+uskdBDfRQggYUBpSpojOlMWQ8KYiwJitDXQanq4 Pa1wGH0nT9T2jCuAXoCL856MgPcmQt1fPdEGxj4w= Received: by mail-wm0-f51.google.com with SMTP id s14-v6so10142259wmc.1 for ; Fri, 13 Jul 2018 10:29:12 -0700 (PDT) X-Gm-Message-State: AOUpUlGiUNiOZlByoPSiejOvnwZmEIzqWwwIKoAMNFOhFfeHbZKMB21Y p1A6Kvo3hsax3W1qjGHuFwiB84ibA8iHLgOBzSlklQ== X-Received: by 2002:a1c:8313:: with SMTP id f19-v6mr4230224wmd.144.1531502950776; Fri, 13 Jul 2018 10:29:10 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a1c:d548:0:0:0:0:0 with HTTP; Fri, 13 Jul 2018 10:28:50 -0700 (PDT) In-Reply-To: <1531308586-29340-40-git-send-email-joro@8bytes.org> References: <1531308586-29340-1-git-send-email-joro@8bytes.org> <1531308586-29340-40-git-send-email-joro@8bytes.org> From: Andy Lutomirski Date: Fri, 13 Jul 2018 10:28:50 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 39/39] x86/entry/32: Add debug code to check entry/exit cr3 To: Joerg Roedel Cc: Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , X86 ML , LKML , Linux-MM , Linus Torvalds , Andy Lutomirski , Dave Hansen , Josh Poimboeuf , Juergen Gross , Peter Zijlstra , Borislav Petkov , Jiri Kosina , Boris Ostrovsky , Brian Gerst , David Laight , Denys Vlasenko , Eduardo Valentin , Greg KH , Will Deacon , "Liguori, Anthony" , Daniel Gruss , Hugh Dickins , Kees Cook , Andrea Arcangeli , Waiman Long , Pavel Machek , "David H . Gutteridge" , Joerg Roedel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 11, 2018 at 4:29 AM, Joerg Roedel wrote: > From: Joerg Roedel > > Add a config option that enabled code to check that we enter > and leave the kernel with the correct cr3. This is needed > because we have no NX protection of user-addresses in the > kernel-cr3 on x86-32 and wouldn't notice that type of bug > otherwise. > I like this, but could you make it just use CONFIG_DEBUG_ENTRY? --Andy