Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1082949imm; Fri, 13 Jul 2018 11:09:21 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfmb06JWY7Q6EgYqlre1x3OyTGKuVs6cuPW/L+V9ZJWCGijvy8d34YXCWA5lsOtlL1I44Rq X-Received: by 2002:a62:858c:: with SMTP id m12-v6mr8199079pfk.173.1531505361485; Fri, 13 Jul 2018 11:09:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531505361; cv=none; d=google.com; s=arc-20160816; b=oEAhZr6pwV1bbEhZFrI3hyUJJ556IWFcpZ0bH9sRLdXG3QefqJyJgzbXsoEo1P8ZMH CtAXhwcXFOfYpUD/8SgDkneGIl1PnMy/JwP/SuVUJK8DxnD4OT+vJzSuEaNCdMEh06BG p0SG2rzZzagFmRtEInyJ+zPToLXh9b+osyWKdNqcJKAFmStKJEFXZE9/myinObgZ+yW1 nWhm3cPJJJ7M/eh2Zc/ZJELdc4w7Er154OyGCaePvil5J4rXLhTS70co9dtuxbfzl70C BCv6S0vkhkjZavvfI5rK8tlo4w08p4uV1sVtbCVta8F+HxptPEoyKKlsQynKNMAej2HH wBjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:references:in-reply-to:date :subject:cc:to:from:arc-authentication-results; bh=DQAIy4k0ni3jOWHmc97zS8jP7ekDcr30gRlkOpYG/F0=; b=zyY4P5lVfniE0K1BzPUjuJm5ojRAUWLePZmlhpBwzT+9RWqaPLI9nubQ/uEXySpzbR AZ3K66uFnhSIqx+HY7W1y2pgrXrM6rSNMO/+JKs/DS7DDHwNcpI0gkLOD/YxP5A2Zd9M RPViFJtzUOiqES9pxb01sXg2gDBGG/zscIfCAHcpdT7JM5vBS/2+dA+esYmk1yB7cltE +HJxkOuSRDXF1q9cqBtb7qAPub5ypwcc88Mr5KCcR98hXmvsyi85Qay0TRUjSIiV/kGl ZboJqgGVizw1uz+VTSzCni3jAH5Kd8qvviiykVBOUSz8VsUtEMbXXQu0f49CvJJ5N3YL OuEQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i35-v6si24309362plg.209.2018.07.13.11.09.06; Fri, 13 Jul 2018 11:09:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387826AbeGMSWx (ORCPT + 99 others); Fri, 13 Jul 2018 14:22:53 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:34118 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732677AbeGMSWG (ORCPT ); Fri, 13 Jul 2018 14:22:06 -0400 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w6DI4EY1050446 for ; Fri, 13 Jul 2018 14:06:23 -0400 Received: from e06smtp04.uk.ibm.com (e06smtp04.uk.ibm.com [195.75.94.100]) by mx0a-001b2d01.pphosted.com with ESMTP id 2k6xq0nt5w-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 13 Jul 2018 14:06:23 -0400 Received: from localhost by e06smtp04.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 13 Jul 2018 19:06:20 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp04.uk.ibm.com (192.168.101.134) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Fri, 13 Jul 2018 19:06:18 +0100 Received: from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w6DI6HIw38797524 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 13 Jul 2018 18:06:17 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4DA7142045; Fri, 13 Jul 2018 21:06:38 +0100 (BST) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4479842042; Fri, 13 Jul 2018 21:06:37 +0100 (BST) Received: from dhcp-9-31-103-18.watson.ibm.com (unknown [9.31.103.18]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Fri, 13 Jul 2018 21:06:37 +0100 (BST) From: Mimi Zohar To: linux-integrity@vger.kernel.org Cc: Mimi Zohar , linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, "Luis R . Rodriguez" , Eric Biederman , kexec@lists.infradead.org, Andres Rodriguez , Greg Kroah-Hartman , Kees Cook Subject: [PATCH v6 2/8] kexec: add call to LSM hook in original kexec_load syscall Date: Fri, 13 Jul 2018 14:05:57 -0400 X-Mailer: git-send-email 2.7.5 In-Reply-To: <1531505163-20227-1-git-send-email-zohar@linux.vnet.ibm.com> References: <1531505163-20227-1-git-send-email-zohar@linux.vnet.ibm.com> X-TM-AS-GCONF: 00 x-cbid: 18071318-0016-0000-0000-000001E691DA X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18071318-0017-0000-0000-0000323B2F81 Message-Id: <1531505163-20227-3-git-send-email-zohar@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-07-13_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=5 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=862 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1806210000 definitions=main-1807130159 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In order for LSMs and IMA-appraisal to differentiate between kexec_load and kexec_file_load syscalls, both the original and new syscalls must call an LSM hook. This patch adds a call to security_kernel_load_data() in the original kexec_load syscall. Signed-off-by: Mimi Zohar Cc: Eric Biederman Cc: Kees Cook Acked-by: Serge Hallyn --- kernel/kexec.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/kernel/kexec.c b/kernel/kexec.c index aed8fb2564b3..68559808fdfa 100644 --- a/kernel/kexec.c +++ b/kernel/kexec.c @@ -11,6 +11,7 @@ #include #include #include +#include #include #include #include @@ -195,10 +196,17 @@ static int do_kexec_load(unsigned long entry, unsigned long nr_segments, static inline int kexec_load_check(unsigned long nr_segments, unsigned long flags) { + int result; + /* We only trust the superuser with rebooting the system. */ if (!capable(CAP_SYS_BOOT) || kexec_load_disabled) return -EPERM; + /* Permit LSMs and IMA to fail the kexec */ + result = security_kernel_load_data(LOADING_KEXEC_IMAGE); + if (result < 0) + return result; + /* * Verify we have a legal set of flags * This leaves us room for future extensions. -- 2.7.5