Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH bpf-next v5 0/3] bpf: btf: print bpftool map data with btf
To:     Okash Khawaja <osk@fb.com>
Cc:     Jakub Kicinski <jakub.kicinski@netronome.com>,
        Martin KaFai Lau <kafai@fb.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Yonghong Song <yhs@fb.com>,
        Quentin Monnet <quentin.monnet@netronome.com>,
        "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org,
        kernel-team@fb.com, linux-kernel@vger.kernel.org
References: <20180712030803.875913594@fb.com>
 <20180711203010.51bab0cf@cakuba.lan>
 <e938c861-b341-22f0-7e82-215a27e2b74f@iogearbox.net>
 <20180713213550.GA5667@w1t1fb>
From:   Daniel Borkmann <daniel@iogearbox.net>
Message-ID: <1e80f262-9b3f-e4ff-0e89-7a07098d1b50@iogearbox.net>
Date:   Sat, 14 Jul 2018 00:35:03 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <20180713213550.GA5667@w1t1fb>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 07/13/2018 11:35 PM, Okash Khawaja wrote:
> On Fri, Jul 13, 2018 at 10:49:01PM +0200, Daniel Borkmann wrote:
>> On 07/12/2018 05:30 AM, Jakub Kicinski wrote:
>>> On Wed, 11 Jul 2018 20:08:03 -0700, Okash Khawaja wrote:
>>>> Hi,
>>>>
>>>> Here are the changes from v4:
>>>>
>>>> patch 2:
>>>>
>>>> - sort headers in btf_dumper.c
>>>> - remove extra parentheses
>>>> - include asm/byteorder.h
>>>> - compile error when big and small endian bitfields macro undefined
>>>
>>> Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
>>
>> Hmm, strange, by accident I just noticed that only your bpf fix ever made
>> it to patchwork, Okash.
>>
>>   https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.ozlabs.org_project_netdev_list_-3Fsubmitter-3D74458-26state-3D-2A&d=DwICaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=4wHrS7MHHFLZe_WCJwRVhA&m=wkiBQFYWPyiN9WONHLY0WiZxcOwNRhXaMMLIE551mCA&s=RggQzClRdkwawboGLPgPXHOdUtYffxeOwlcBlFru-P4&e=
>>
>> Potentially because you've sent with attachments which got dropped on
>> the list?
> interesting because i send all patches using quilt mail, the same way i
> sent bpf fix. i can try git-send-email.
> 
> also i dropped Acked-by as i changed patch versions. is it common thing
> to do? or should i keep the Acked-by?

Depends on whether the pieces that have been ACKed changed in the
meantime or not.