Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp28569imm; Fri, 13 Jul 2018 16:22:57 -0700 (PDT) X-Google-Smtp-Source: AAOMgpehwv92vusAYxyYo4x7jIkxQGO/Uhi54bmYOP1l2gWAWHyayzxe8rWHdl90X3yO+jWIsBgW X-Received: by 2002:a17:902:7202:: with SMTP id ba2-v6mr6281816plb.179.1531524177378; Fri, 13 Jul 2018 16:22:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531524177; cv=none; d=google.com; s=arc-20160816; b=y2sFSo6JmXeoY4c0Fid4iSjX+YEWgcC5dyYXU6xpNTRm2znyvlnuP7euRdtSONMa6j DdivFh1ASBIDnJIf6BTz0+RNHFBINce6A6sWukWq4Z/RfvdHNKQVK0F3IU70y0DvJE8O eMWmeE3vfg3yVAjlvW/6i9Fs0/ilyqsbF3KqJ+7JDzG6ewYnX3dbu+N6tKa8Z6h7dVyo HprZd3J0mMtzIK/4J/y89cyo0TjRVn65Ogf8rMV/WLocX3tUdSiAdPCaIL2wB34qyi/c MqhlqlDe4bRXxAJYULyatK3kX/FkqetrBrxQ/4PzKXRxEqQ5xu5XyERe/XboNVlIBivJ B2BQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=OIiGOyLGpO66FMO5brtbtbdnUdeHfBasgsntwZ5sv90=; b=r0FsHlSj2Yot5SMVlDJndzQoWxg33DxA+79Eb2504rBMR8/BxljCQxfwBrtakfgXMr reoIZderYS8B8DS+6ze7uYM8/YFo+/cQal8kKb8jmeZIpEORu+4XTuw6oliNEyX6UsA6 hOGF4oW2NPCb+oPp1NJ7owQl9801IaajPzj5RvNJ2Y94EocmP+OXDldnbPPWpiuQWSf3 5FmYKoIXnb9Pcx3/rhC80P5RLnM/b7wvpRAcehuQf08y/2YUSVaWMbu72tT4aHBVrSXx zfBKOVI9RtBv8kaMQ5C4dTqiszpR4T+XnXuCKZEhO4/saNAbl+JDG8kRnl2oFOWEILNd ahLw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=PUU9BiwO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j6-v6si24416243pgn.416.2018.07.13.16.22.42; Fri, 13 Jul 2018 16:22:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=PUU9BiwO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729780AbeGMXix (ORCPT + 99 others); Fri, 13 Jul 2018 19:38:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:38912 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729626AbeGMXix (ORCPT ); Fri, 13 Jul 2018 19:38:53 -0400 Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 78A8D208CE for ; Fri, 13 Jul 2018 23:22:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1531524127; bh=X3fO/TB4wvKh2OodbCCLV5H0FDa2wEa0n2ACTxYOb1E=; h=In-Reply-To:References:From:Date:Subject:To:Cc:From; b=PUU9BiwO17OzFsep+t5zVmeP+qKlPFYlL7MWKFV8AsJWEBDFCEN7UgYwCQZ7pG7U3 EAiefhKgc99gy4vZ4S3zyeVKog4mnmqo/9BsZAD34fZvXrwiyWOUoW7VMFeo6YOrq/ A6Jeq/EVSPYkBlu+B82QrRkvwM1yN71MfKU0WgEg= Received: by mail-wm0-f49.google.com with SMTP id s13-v6so5549899wmc.1 for ; Fri, 13 Jul 2018 16:22:07 -0700 (PDT) X-Gm-Message-State: AOUpUlEr/g2hmX6NFAaM7NDKwv1iHSTqOSXs7n4+5lF6ck1FK+uLGpTf Ghf69p9f6Wa5OcY97Tn96cVofbTZodJEEVYx4ssI7Q== X-Received: by 2002:a1c:34c9:: with SMTP id b192-v6mr5178796wma.21.1531524125912; Fri, 13 Jul 2018 16:22:05 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a1c:d548:0:0:0:0:0 with HTTP; Fri, 13 Jul 2018 16:21:45 -0700 (PDT) In-Reply-To: <1531308586-29340-31-git-send-email-joro@8bytes.org> References: <1531308586-29340-1-git-send-email-joro@8bytes.org> <1531308586-29340-31-git-send-email-joro@8bytes.org> From: Andy Lutomirski Date: Fri, 13 Jul 2018 16:21:45 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 30/39] x86/mm/pti: Clone entry-text again in pti_finalize() To: Joerg Roedel Cc: Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , X86 ML , LKML , Linux-MM , Linus Torvalds , Andy Lutomirski , Dave Hansen , Josh Poimboeuf , Juergen Gross , Peter Zijlstra , Borislav Petkov , Jiri Kosina , Boris Ostrovsky , Brian Gerst , David Laight , Denys Vlasenko , Eduardo Valentin , Greg KH , Will Deacon , "Liguori, Anthony" , Daniel Gruss , Hugh Dickins , Kees Cook , Andrea Arcangeli , Waiman Long , Pavel Machek , "David H . Gutteridge" , Joerg Roedel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 11, 2018 at 4:29 AM, Joerg Roedel wrote: > From: Joerg Roedel > > The mapping for entry-text might have changed in the kernel > after it was cloned to the user page-table. Clone again > to update the user page-table to bring the mapping in sync > with the kernel again. Can't we just defer pti_init() until after mark_readonly()? What am I missing?