Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp100874imm; Fri, 13 Jul 2018 18:24:37 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdRFTjvXk09lQLSiUcAIcMihbmN8uBmxnFWLvIxUbA0NGXqvcorS7xXxHHamfghkyHpwWAh X-Received: by 2002:a62:3d86:: with SMTP id x6-v6mr9351060pfj.192.1531531477579; Fri, 13 Jul 2018 18:24:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531531477; cv=none; d=google.com; s=arc-20160816; b=CNlTsnsVMdPWGBctXvAxcVMtpqW0l9nejusebGTJebLpPLFGaj5L9LilktEhPOyd97 B5lSLQHWpqMhhZytU9+MZwJ87iAicl47WQ/VUr14bqxNRlOq/pYV8Lvnm6RvoC9TlviT u6nKZnkuywJU7Y5pa8+GljSi3dvag+yjLNnATu5HYKPXmsu2aGS/3TNONNpvy9IaWu2j xlp6MF0nMtR0eM11/P08aStlTJQmk6UR2JquXyi64Lyl0HTfOvVj0WplJufU/GusFyRf J8xQQeDI+BUi+PD04YU9h6XGwGYNVT1Wy1YKywQbIi4FY6wdTZbSsiOHDdaKAeRNR7bH 8QRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=Hg4rJoA4s7N0q8cfMPT8XooIiApBZP0rYcdJeJFONwU=; b=s8atSB/MyYSn4a055OcuHjI88+/QU5gEGsWZzPCLjHTQgiooCMNVJsBR5ezHVHLqsC G3mADvBnA+SF7eiAQ8UPjxJogr1RlrkqCBm/mWzSrvs0jbYW5C7uGcknKdFeCNtq5Q7o DVLw/bisIWHa2pJk6Z6oQJTj/txp1mJvs5uFSP2AshEwB8e8KprwU//UPEaCgi4wA5i8 RT64cfu3Y3O1x0G3pL+ZaCuN5Eo2s/LLXbn7202g2d6v6uH3+bGjDVBws63Dw1OCGc6l 7DtB0vjBi4Y2I5jrahyYmIYSIoTRzOtqpIChRkMw/unag6B9/RcJfi/NleB6UjE0NGZC 9VKg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q136-v6si23466446pgq.483.2018.07.13.18.24.10; Fri, 13 Jul 2018 18:24:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731402AbeGNBkU (ORCPT + 99 others); Fri, 13 Jul 2018 21:40:20 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:40006 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729645AbeGNBkU (ORCPT ); Fri, 13 Jul 2018 21:40:20 -0400 Received: from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net [74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D934214500EEA; Fri, 13 Jul 2018 18:23:13 -0700 (PDT) Date: Fri, 13 Jul 2018 18:23:11 -0700 (PDT) Message-Id: <20180713.182311.1329076241299839709.davem@davemloft.net> To: gregory.clement@bootlin.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, thomas.petazzoni@bootlin.com, linux-arm-kernel@lists.infradead.org, jason@lakedaemon.net, andrew@lunn.ch, sebastian.hesselbarth@gmail.com, yelena@marvell.com, nadavh@marvell.com, mw@semihalf.com, dima@marvell.com, antoine.tenart@bootlin.com, miquel.raynal@bootlin.com, maxime.chevallier@bootlin.com Subject: Re: [PATCH net-next v2 5/7] net: mvneta: Allocate page for the descriptor From: David Miller In-Reply-To: <20180713161841.11202-6-gregory.clement@bootlin.com> References: <20180713161841.11202-1-gregory.clement@bootlin.com> <20180713161841.11202-6-gregory.clement@bootlin.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 13 Jul 2018 18:23:14 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Gregory CLEMENT Date: Fri, 13 Jul 2018 18:18:39 +0200 > -static int mvneta_rx_refill(struct mvneta_port *pp, > - struct mvneta_rx_desc *rx_desc, > - struct mvneta_rx_queue *rxq) > - > +/* Allocate page per descriptor */ > +static inline int mvneta_rx_refill(struct mvneta_port *pp, > + struct mvneta_rx_desc *rx_desc, Please do not use inline functions in foo.c files, let the compiler decide. Thank you.