Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp242048imm; Fri, 13 Jul 2018 23:01:31 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfTeYrDA2r7miLSxmomvw/oE97aM4cQNyXlPbNf9WvmIffHedhW/SKbdXBw/nfyDwAXV5V0 X-Received: by 2002:a17:902:24a5:: with SMTP id w34-v6mr9012316pla.52.1531548091765; Fri, 13 Jul 2018 23:01:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531548091; cv=none; d=google.com; s=arc-20160816; b=cqHzi7dlkaXYnWFBZ8PSZevyP3AVjLAFD6fADtBfUKZGE9JUfT7Fjd53R9Ng+gqcQp VpaBfMvpBj91hhilNW6yGd+E983yYMbx/vZ7BkZzC3YXmvpOqOxGoXvxl74YczeIf9kT YW5422znO9Pa9VELiZeAFJBzZinMrzW6OYXEyWUUwunJ0B9aBFdGDEkLL0df6hKlmgur 0clF5BoNEN/m6m4fTHi/tdOPWG37XBLISbjKtMvytx5aEh5NdtUc8EOcAqoJaLdSmTZV xT7JrHXRXZAY3kqsZWTn86Q458uWzSQQMVtaj8pP/xdH6J5HTwlL5C6WAts8B6s0mY81 UXXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=BrWKVTSWP35nfIfmRiFCqAiR1XL1rxa34t3vQmXlXu4=; b=fhoPh1cvz1PwI2cfbg2WtiG7sFZZXBrqxerHvPiltj/KTiwd37N1+WAhBh1uhrBKlj ZKFxnIh8rJTU2/BosiTB8WcZw5zhsMGI3rtvTFh8jGmiaH4BPOpatXMZg9c0v4fVoBc0 lwS72eDFWD4tGuMe5peKoDE8T2s08Hw3N3pZjX7ZYGlpn0fE500dhjYk+NzjBEpSMSgJ txUJr8m3EmN84jXMVxssk6MFe4ILOrfaMq8rYF0hZrMdl8APsWlMpzD0/b2+9Vb4LfUH rI2Ag0pRDNpZGHRaxfvJiBdHa+ZpMdzxK9iLL6mHApoapGPsKW08YMK6u65SFHq0rzN9 8GJA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Mfbe7ab2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l26-v6si19972768pfj.188.2018.07.13.23.01.16; Fri, 13 Jul 2018 23:01:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Mfbe7ab2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727705AbeGNGQp (ORCPT + 99 others); Sat, 14 Jul 2018 02:16:45 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:41708 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727401AbeGNGQn (ORCPT ); Sat, 14 Jul 2018 02:16:43 -0400 Received: by mail-pg1-f193.google.com with SMTP id z8-v6so4184188pgu.8 for ; Fri, 13 Jul 2018 22:58:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=BrWKVTSWP35nfIfmRiFCqAiR1XL1rxa34t3vQmXlXu4=; b=Mfbe7ab2oDLiN6MQxuMJ1CZsIxxYmFwJJphtcyGUifEyCWKet3156jtr79vtLmyWki L644oE3pAifKDDI9mNEnqVMz/NnWj5te1y5cap7QdoIzJxAuKpyIa3EX9/IIZpr4VHgr xB9k/LrWCGdsWAr83KnX33vE9XLLv74Zk8HDh+GyUWNjLiDgxSSGiuWo4bm7pljTekdd w79gInudr7z+mb0TuZ2NCiDqcvPyaeWm5qZHquJKyJ3fVt9qoj2oXp0Pvwrb+iR1fqzz OSLkNN4A8+XTvv39LtXVtdOi80aQkplPKiYN9VDFSrJ+jC07KdrOwxR8phT5RixrBQM6 xVhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=BrWKVTSWP35nfIfmRiFCqAiR1XL1rxa34t3vQmXlXu4=; b=nn2JutHMUHgmW9M3OHq7C9Zlh4NvaXKWm0JkbFZk4N0gEOJyEywEt+IovYYOEWI88d MItQ7t+tBWPnPVF49uol5ZVi/tD+OkJASSE3zvcJ8DHE3/D9WkEiyNqWFV9hD16dh6Be 1aJydPZJTVSONKqPy4Vu3yS4ZWdfG/kBWhHtSw0XNmEMTS8OLvfaRgwbw+8wueId0UTj 4lQSr7TXaGFHAGUq/6nSoAV0hTXR1MeeHTXqZ6KFcYUeRuOj/r9JNSO6Sern32J3MusX 2I4hkZQcsmFWSKll+cTVDJq2bzyO7IIXWp503vOzuK2mqFkXNbly/hQsXhlpcpAFILoe Zlig== X-Gm-Message-State: AOUpUlH/UU/zlodlFltNL4GWXRQWibIH/SV/w5/juJLb0/ZugRnjzIl3 6TDeoqfj47iIATzQnX0wWIfQqpUQ X-Received: by 2002:a63:5b0d:: with SMTP id p13-v6mr8700735pgb.202.1531547934060; Fri, 13 Jul 2018 22:58:54 -0700 (PDT) Received: from toddpoynor2.mtv.corp.google.com ([2620:0:1000:3701:7d29:cd13:d903:7908]) by smtp.gmail.com with ESMTPSA id 203-v6sm48411112pgb.14.2018.07.13.22.58.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Jul 2018 22:58:53 -0700 (PDT) From: Todd Poynor To: Rob Springer , John Joseph , Ben Chan , Greg Kroah-Hartman Cc: Zhongze Hu , Simon Que , Dmitry Torokhov , Guenter Roeck , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Todd Poynor Subject: [PATCH 10/18] staging: gasket: gasket_open use container_of() Date: Fri, 13 Jul 2018 22:58:08 -0700 Message-Id: <20180714055816.223754-11-toddpoynor@gmail.com> X-Mailer: git-send-email 2.18.0.203.gfac676dfb9-goog In-Reply-To: <20180714055816.223754-1-toddpoynor@gmail.com> References: <20180714055816.223754-1-toddpoynor@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Todd Poynor Use container_of(), drop unnecessary NULL check. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/gasket/gasket_core.c b/drivers/staging/gasket/gasket_core.c index ffd6ce801313..0c45c54254fb 100644 --- a/drivers/staging/gasket/gasket_core.c +++ b/drivers/staging/gasket/gasket_core.c @@ -1099,12 +1099,9 @@ static int gasket_open(struct inode *inode, struct file *filp) const struct gasket_driver_desc *driver_desc; struct gasket_ownership *ownership; char task_name[TASK_COMM_LEN]; - struct gasket_cdev_info *dev_info = gasket_cdev_get_info(inode->i_cdev); + struct gasket_cdev_info *dev_info = + container_of(inode->i_cdev, struct gasket_cdev_info, cdev); - if (!dev_info) { - gasket_nodev_error("Unable to retrieve device data"); - return -EINVAL; - } gasket_dev = dev_info->gasket_dev_ptr; driver_desc = gasket_dev->internal_desc->driver_desc; ownership = &dev_info->ownership; -- 2.18.0.203.gfac676dfb9-goog