Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp261625imm; Fri, 13 Jul 2018 23:34:35 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdGhP7pXeC8et0FRRuffelEDU8+QGq+m5qTwCS4iCHLT+JFwbu5yXx6r7T9aJUUiGLKcmPG X-Received: by 2002:a65:58c8:: with SMTP id e8-v6mr8492377pgu.96.1531550075016; Fri, 13 Jul 2018 23:34:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531550074; cv=none; d=google.com; s=arc-20160816; b=WbMwvFet09z8DImOIvGfW6DuiLHNG912K1iFZ19JX7/+3ZeHaC001JNrJFMkTM4tY5 sYIsPnUNQogGA3syVxdEGH7HStbUdUBjHTnN0q5YSh+nn+/6bNt6Jn79t5Fh8zFE+S87 +Cz7oo9fT4OZ3V+ZovFHFjUvkoz7R1X1CfJ8WyxnyZ26eW8SdKaCDsmFxL9fx0TajehA CoxZsfhrSnpjuX/+Kvqvrpx8V+eM7cDYfW5PVubmnBwDxRQfiwQlKKWfexd8Z0/Xjd8y 1sGv11jIPssUpTWB6bKPYkoxSKMlSvtJtcm9ds8covKrRYB7x5iF5s1E5CwC+VQBA603 PAKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=sdt0QBJvuMPlwGXZaSkyFdJwfzml8KFzNo5BdLq7mBI=; b=ykEhstRHL0bbAzEcgSRy+xQJ3/l5W6EfIKrsMWiFpdgraE/1FsWBnwpAyO6pt6rWwx mt68zd3/uhtH8uKuN0pTZ5VF9dRsHLudG40V3ZysfG1xfPonUMA6/jDBsVsBRa5csegd 6DKgOC+JJ+yvIa2A+5sXKMTFuChhwE+uyEOT4Q9kSpznqjGdt0BwLbGM1lMjCSHNzrG2 CE3t6bm+w2/F2gi9+ySWfQypE7MMV/bs8I6A9fRirDBsNZv4hBrw95KEnUbV2gNfP2eb bzCxjMbHBEuTuFXIsSS4yOoPgt7GviLD6gf2VxwCt3vYvfWiqcvNtpx1262kST58qf+m dF5g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m76-v6si19056137pfg.323.2018.07.13.23.34.20; Fri, 13 Jul 2018 23:34:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726628AbeGNGve (ORCPT + 99 others); Sat, 14 Jul 2018 02:51:34 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:54884 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725809AbeGNGve (ORCPT ); Sat, 14 Jul 2018 02:51:34 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 93F1F2D; Sat, 14 Jul 2018 06:33:37 +0000 (UTC) Date: Sat, 14 Jul 2018 08:33:34 +0200 From: Greg Kroah-Hartman To: Todd Poynor Cc: Rob Springer , John Joseph , Ben Chan , devel@driverdev.osuosl.org, Zhongze Hu , linux-kernel@vger.kernel.org, Simon Que , Guenter Roeck , Todd Poynor , Dmitry Torokhov Subject: Re: [PATCH 08/18] staging: gasket: gasket_wait_with_reschedule fixups Message-ID: <20180714063334.GE20451@kroah.com> References: <20180714055816.223754-1-toddpoynor@gmail.com> <20180714055816.223754-9-toddpoynor@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180714055816.223754-9-toddpoynor@gmail.com> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 13, 2018 at 10:58:06PM -0700, Todd Poynor wrote: > From: Todd Poynor > > Return -ETIMEDOUT on timeouts. > > Don't need 64-bit sized retry count. > > Use msleep(). > > Return immediately when condition hit. Huge hint, when you have to list the different things you do in a patch, that means it should be split up into smaller patches. Please rework this patch series based on this. I'll stop reviewing them now and wait for a new set of patches. thanks, greg k-h