Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp323209imm; Sat, 14 Jul 2018 01:16:13 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcVViILOYb9ZLchvaVZHMRd3RCj+PT309iOHuUuhjzd5bIUMKhoyMQrTwGjIiEvh7YCdTL8 X-Received: by 2002:a63:a1a:: with SMTP id 26-v6mr8845406pgk.221.1531556173610; Sat, 14 Jul 2018 01:16:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531556173; cv=none; d=google.com; s=arc-20160816; b=MRYsaJyx2j2AdY8k9eQPK3W6pHrmE2L4Sw7gAiHMC6UMIfeAaFdK+g8vZIxuNxYorj uRWD2+px0BzMrnkaixnCcB4T4g+eDvknZZJPg3KEIKdI7XK+L6O2B8qrSWh4ZueFSU3b eXu4DaFXKsRYn2zc05Umt4SHt1gSBhYQWAqyXMrpgkMzHVIkmHS3DmH4Kqbbr0nfnEwB EJ5I6heiGCWoMC1jqLnucnjqMe7DzFUI8ClLChW5pucaZEQSoGC7QJ2Nd6XfwrwJ7Ato TJSKTSjVXJo8Y+enLQtSF0ZrD2jRW2cS9SU9SCVbUEYupZbe2dmTuGUXCluU+3IU3kVm Pmbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature :arc-authentication-results; bh=RCaNO9JYVlWLaA1L1s0sfYz8CW51ujp3r+vifN/+eng=; b=rduVaMwi+2KNxoDAqYl/74QZ3nbtpOaa5mQFMlVN/OkU2yK6se6jK3fqzw5lrpEr2I WKyM9/2ZxiJorjytey1ZVilZFBBFlEzLFgiQEW7MW0wM9fshuv92jzz3jQNrvdlEXGeh 6V4Dj6DfpNOI8mtpzQlY0LLf44rPJDCnRi6lSYe2mLQkVHpwPM48LSLbQXBG3RaWI/ER li8IWj1+pHP3+4qhP9PRVaWohfqX2IhYJmCpGtbDooRRLVLXbbfBp+Ez/EUtYIvCJ19p xbKOMRHf1+mqfjTqjsN2bIfYK9XaBZpo0VywZHBdnso3uJBxRxNpi4fYui23nh6fGa2b sQLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=kFOVZMF1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q17-v6si25981129pff.173.2018.07.14.01.15.58; Sat, 14 Jul 2018 01:16:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=kFOVZMF1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726994AbeGNIdb (ORCPT + 99 others); Sat, 14 Jul 2018 04:33:31 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:33306 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726105AbeGNIdb (ORCPT ); Sat, 14 Jul 2018 04:33:31 -0400 Received: by mail-ed1-f66.google.com with SMTP id x5-v6so22602058edr.0 for ; Sat, 14 Jul 2018 01:15:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RCaNO9JYVlWLaA1L1s0sfYz8CW51ujp3r+vifN/+eng=; b=kFOVZMF1BAHObfVBDsn1HBgMcg2HxdwqeiqQ+ROuxGI9v2zi4awBLFTFfxF0kSf6wi uzJzl5j/reP5LYpRT0znpEfP+rbDnBd7afuFids1enz/2DrChEEp0wOZiJTebg4K3udG Ne91nmX+OfbxD70+WW3jbwaqA0eG9yRUPzCsw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RCaNO9JYVlWLaA1L1s0sfYz8CW51ujp3r+vifN/+eng=; b=r15EdKRs85Qj6mOHHxZ1uKGtSJuVzF0TO+ki1ejqZCKIN1hfL3CaZaH9CoQF77WH/8 agEw3tstjbHfUhll4ZA63vmVpiAKRBKJP4gU0o6m+qzPriOsVc9HWJRI9qAvWqxm7IGX m32XqIFbySrd9n7lFobW7RVkuyqcpYoXoJSfFE4YRaRDLV4ox9auRHI30IEp60tDyk++ /y/c2PD8BluRF2K0IcOVycLiBak3ISt5HO+n6QYAmNREDAlEqYVJ6FYJDzAPrJdlMldL 2Zjn6vV6XSviTsCa1hbZJ8uJ/cYFrjBOLbTwVbv52hURKkeSZLvoMx55FSJO0CDBMrxf bAJg== X-Gm-Message-State: AOUpUlFCBle5qZ78qY82hlgFO6LCOxFQ2B8uBsAj7Xt7QhmZLXeRV0cO hmD1TUmkIA0kXGy6mHmoFyWpb/JCkZ+jCg== X-Received: by 2002:a50:94c4:: with SMTP id t4-v6mr9766702eda.128.1531556114824; Sat, 14 Jul 2018 01:15:14 -0700 (PDT) Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com. [209.85.221.53]) by smtp.gmail.com with ESMTPSA id h4-v6sm7847238edq.89.2018.07.14.01.15.12 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 14 Jul 2018 01:15:12 -0700 (PDT) Received: by mail-wr1-f53.google.com with SMTP id m1-v6so14404766wrg.5 for ; Sat, 14 Jul 2018 01:15:12 -0700 (PDT) X-Received: by 2002:adf:a197:: with SMTP id u23-v6mr7488077wru.50.1531556112534; Sat, 14 Jul 2018 01:15:12 -0700 (PDT) MIME-Version: 1.0 References: <20180714055816.223754-1-toddpoynor@gmail.com> <20180714055816.223754-11-toddpoynor@gmail.com> In-Reply-To: <20180714055816.223754-11-toddpoynor@gmail.com> From: Dmitry Torokhov Date: Sat, 14 Jul 2018 11:15:00 +0300 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 10/18] staging: gasket: gasket_open use container_of() To: toddpoynor@gmail.com Cc: rspringer@google.com, jnjoseph@google.com, benchan@chromium.org, Greg Kroah-Hartman , frankhu@chromium.org, Simon Que , Guenter Roeck , devel@driverdev.osuosl.org, lkml , toddpoynor@google.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 14, 2018 at 8:58 AM Todd Poynor wrote: > > From: Todd Poynor > > Use container_of(), drop unnecessary NULL check. > > Reported-by: Dmitry Torokhov > Signed-off-by: Zhongze Hu > Signed-off-by: Todd Poynor > --- > drivers/staging/gasket/gasket_core.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/gasket/gasket_core.c b/drivers/staging/gasket/gasket_core.c > index ffd6ce801313..0c45c54254fb 100644 > --- a/drivers/staging/gasket/gasket_core.c > +++ b/drivers/staging/gasket/gasket_core.c > @@ -1099,12 +1099,9 @@ static int gasket_open(struct inode *inode, struct file *filp) > const struct gasket_driver_desc *driver_desc; > struct gasket_ownership *ownership; > char task_name[TASK_COMM_LEN]; > - struct gasket_cdev_info *dev_info = gasket_cdev_get_info(inode->i_cdev); Are there other users of gasket_cdev_get_info()? if this was the only one we should remove the macro,otherwise we should convert them as well. > + struct gasket_cdev_info *dev_info = > + container_of(inode->i_cdev, struct gasket_cdev_info, cdev); > > - if (!dev_info) { > - gasket_nodev_error("Unable to retrieve device data"); > - return -EINVAL; > - } > gasket_dev = dev_info->gasket_dev_ptr; > driver_desc = gasket_dev->internal_desc->driver_desc; > ownership = &dev_info->ownership; > -- > 2.18.0.203.gfac676dfb9-goog >