Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp745330imm; Sat, 14 Jul 2018 11:22:55 -0700 (PDT) X-Google-Smtp-Source: AAOMgpe0eqyL3d/fItordZocI0/B/MSztM0oPjzb4QhOMlb8sU5s+CLjeiwntJZut7JPtTK+JO1C X-Received: by 2002:a65:550d:: with SMTP id f13-v6mr10498255pgr.340.1531592575256; Sat, 14 Jul 2018 11:22:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531592575; cv=none; d=google.com; s=arc-20160816; b=WIRUwOzytymlWsi7hMI4a2h/VppLKOrY1e4KXE7+TpbDTzYit96BZmdc3SmVnvl0JN 1/98ruNMHWyg7gcP35EAAhJHuzsPL45wkoBnCsAezAG7KLIHyfFiTT4Py+uPl5KPL7Eq UpN+MBp0qvYq0leZUtWLsrqU1KxH+hKAWBpO8fsyAGABmYdONtsGB7RIfyuyfAQvxnUW 8Wg+VavPzo2jAF2nb0/C7a3v6b/2sb//mMolCJw7UEYz8YCglrOM2dtgInhbeVeLV5cP ls9JvdiXVKQRE4Y20efcLzTDBPqvkzWrM0hYBdkW0b+TgPbJa7//LOWON5mbhYHckrKL V6tQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=9eMm9+Fs95KFAw93Yon2Xo20t33OBvkRbX0eLGyhoF4=; b=R7Bzy/mlQF6V4NUXccYlqJhZCRZ8ixBA3pIu1Tdf7yhq2xn0gsT1mW0XWJUwWUVgWu dliIozzq6VmJBao/yifRJyFW+jm7gRfYVp492wIddcPpIWZUCDZ2aAWTUIfvUSqFV3hI 5DC26qYqh6OxYxte/EzKmfRZuoo5AzGYNK7TqzfEUJQlcOqkObgxPhDMzbl3EiHIYJyn +GjckBZ/gygec3yZO/d+mcOAlZmJ1BCCnYt6sFpKMpvOxiyXyR0rhWP3DvNUL+2OPQqr THPATXkr996WxsAPAp3PyFPHSz5CbfqNYWLYma40qSeBVjlvASnO3gp5zoNKKcMfeW8H KV8w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a33-v6si26270067pld.167.2018.07.14.11.22.40; Sat, 14 Jul 2018 11:22:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731379AbeGNSl7 (ORCPT + 99 others); Sat, 14 Jul 2018 14:41:59 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:52722 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726960AbeGNSl7 (ORCPT ); Sat, 14 Jul 2018 14:41:59 -0400 Received: from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net [74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id B0DEE13F44151; Sat, 14 Jul 2018 11:22:06 -0700 (PDT) Date: Sat, 14 Jul 2018 11:22:04 -0700 (PDT) Message-Id: <20180714.112204.1831168896985469983.davem@davemloft.net> To: laoar.shao@gmail.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, shaoyafang@didichuxing.com, edumazet@google.com Subject: Re: [PATCH net-next] tcp: remove redundant rcv_nxt update From: David Miller In-Reply-To: <1531557390-12592-1-git-send-email-laoar.shao@gmail.com> References: <1531557390-12592-1-git-send-email-laoar.shao@gmail.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 14 Jul 2018 11:22:06 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yafang Shao Date: Sat, 14 Jul 2018 16:36:29 +0800 > tcp_rcv_nxt_update() is already executed in tcp_data_queue(). > This line is redundant. > > See bellow, > tcp_queue_rcv > tcp_rcv_nxt_update(tcp_sk(sk), TCP_SKB_CB(skb)->end_seq); > tcp_rcv_nxt_update(tp, TCP_SKB_CB(skb)->end_seq); <<<< redundant > > Signed-off-by: Yafang Shao > Signed-off-by: Eric Dumazet Applied.