Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 13 Jul 2018 17:15:54 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Marco Felsch <m.felsch@pengutronix.de>
Cc:     lgirdwood@gmail.com, m.purski@samsung.com, p.paillet@st.com,
        linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] regulator: core: fix _regulator_do_disable return value
Message-ID: <20180713161554.GF16228@sirena.org.uk>
References: <20180713125624.13783-1-m.felsch@pengutronix.de>
 <20180713130715.GC16228@sirena.org.uk>
 <20180713154854.qmnraejcdq6gqn3x@pengutronix.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="0hHDr/TIsw4o3iPK"
Content-Disposition: inline
In-Reply-To: <20180713154854.qmnraejcdq6gqn3x@pengutronix.de>
User-Agent: Mutt/1.10.0 (2018-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--0hHDr/TIsw4o3iPK
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Jul 13, 2018 at 05:48:54PM +0200, Marco Felsch wrote:
> On 18-07-13 14:07, Mark Brown wrote:

> > This is fine - consumers shouldn't expect that a disable will cause
> > anything to actually get powered off, constraints or other consumers
> > might mean that the disable doesn't actually happen.  It's just the same
> > as a consumer with an always on flag.

> Okay, I understand that the behaviour should be like the always-on
> contrain. But now the behaviour of the core is like my v1 of
> "Re-Enable support to disable switch regulators". It's like a 'simulated
> off', which wasn't a good solution for you. The difference is, that the
> 'simulated off' is now made in the core.

Right, there's a difference between what the core (which does actually
explicitly turn things on and off) sees and what the consumers (which
only increment and decrement reference counts which may happen to result
in something being turned off immediately but also might not) see.

--0hHDr/TIsw4o3iPK
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAltI0DkACgkQJNaLcl1U
h9C8ywf7B5uF/moFNSn3GVXaDhx5OWuQgti3nKcypjL+jmX88cH9qjXixNRGSmS8
76dAopKcdiyowZGPX4sQS+3l601EhtuDoq4iohUQH6BRY7DSq89beV49nAFulx+v
IMZsAxuoT1lNhjImFwFNVklHiFmI/LUL/z4nhsyyuwtX3ldNRQ4lKpU3Lhb8ZjA1
lA/XJO4LFiex+YjtQugDvM1wtaCMCSkC5fkzaRO0ZPf1fk38uFEDn3zBJYaalveD
s1DftTpYmpBCKcMllyMsdOlMfsNvAeyGmthf6vC/mx/5Agougm72jH7Nzknoqhuj
o+bJKq/P8mjPFdHEwOiQXy9r0slgXA==
=BGkR
-----END PGP SIGNATURE-----

--0hHDr/TIsw4o3iPK--