Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp988911imm; Sat, 14 Jul 2018 18:59:05 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfgl85c2L5V1bQMz8Cn5MWcr+xY5RbU7FYTyGVGpntvooc5x9o6+FxrvGhBfhGZXny2acKG X-Received: by 2002:a63:1c4a:: with SMTP id c10-v6mr10510914pgm.106.1531619945102; Sat, 14 Jul 2018 18:59:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531619945; cv=none; d=google.com; s=arc-20160816; b=GzzsAjdQmI3ECMRi+hQJXQ08suJOuJ09qkLMYt7CzmtJ57Sf4hZcT7mD3KLA5Mjj7a ASo29XpqQwxvXF+0VLVJfzt4mNwiQdkei5zSXUDE452r1Ki9oudmWZCbAjgwdTahUjYi AYCaWwTqn7ya4NZRtAIjx4/weu6GXY4HsZVltqwQMIRbWeUjFYgtEt7GaYFVqJpk7IRd mmAUCgju354MuR0hH3gzvsctmc0IynSnVJlbZpyPSkTqnTm/+nJdVJXUtVIVvMDQsm0F lplMKsMCs01WgiKyP8D/eDHmLY/9GIJlOv4EZT34Wyd3Zo7opZ4Ng3SDeUq2iKuO+64I rgEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature :arc-authentication-results; bh=7q/SOjmobS6UgsAv07jHzji/wery81//CVKQO9pE5D4=; b=MtxeaPGnVMj9tQufxPD+/3AweFZyXxAh7Ge3AyWaJq1o2FdJjmKTMnKlXYf89o0Gb2 fejJg05gIAC/ZvP8BLqErukMnUyF2hSWxt5LQW3TzmtkwWh0ssbMO5zQC1lfD/GmHMT6 P09LAdO699K/YFaDB8Bw0L8UiPHcHjoFcGnCirL33Fj/AIOFeMfRAWmUESY/trx0i22O dQz0JEVdXiizrcCjeng9dal5hrfBQzEK8IxZn5X4ZT8LYlQ97BGiPfEar0KVvYi75w/N amYCXdO7ce/8NGScIXFsPydZwact/jAy5YCQpF6LfGpe/H896L0sSy7pM8gTbtdA5Qnn iTMw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=iMljT9DZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o1-v6si26899619plb.279.2018.07.14.18.58.50; Sat, 14 Jul 2018 18:59:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=iMljT9DZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732811AbeGOCTP (ORCPT + 99 others); Sat, 14 Jul 2018 22:19:15 -0400 Received: from mail-io0-f194.google.com ([209.85.223.194]:37162 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731983AbeGOCTP (ORCPT ); Sat, 14 Jul 2018 22:19:15 -0400 Received: by mail-io0-f194.google.com with SMTP id z19-v6so34614660ioh.4; Sat, 14 Jul 2018 18:58:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7q/SOjmobS6UgsAv07jHzji/wery81//CVKQO9pE5D4=; b=iMljT9DZkxIADHhJt8GcFIwXsIWJHO38CHxdrbtohFbNZ7Wu/EeZ4j2UKFAQy+Nzgl k2hqtCTTQvx64b0PSHzcwEt2h75qqNo1yWyGNxLheDdYEJmxxK5ka0hC7NPItXECBa8r DyA48scwKiTPWeMi1YT1/KPc/Up5coQaXAmd0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7q/SOjmobS6UgsAv07jHzji/wery81//CVKQO9pE5D4=; b=NVeIjfVNl6sWczAlHhf3hzAVX7UsHvqj3zz+OXQbuL0RaqUwWOA/5Vg98WoBq+S4pP XcwjyO0d95FIFt/0g0PFXeoOOVn4n3VNb3BvuKsyqx19KpJFp1K0hNha0y+6geqoRrO3 I+ZoVs5TJbJcPDIxOfPzf6rQEYkoVrWt7rDC6eVgCF0+ts66uRrt81SdWWfB6cPnyWYT vTab36WgwcDAvRm87Bv7YBhNqGQdECsfKL1cmhvrbgVzRRIVxzie1TVelW+reM3s0jEa k8l124aco45hEPrLMTRJaJFr+ZAO5JpAJF+wb0eht/oMgTorrK1e4DosriDD78HdIIoK WcaA== X-Gm-Message-State: APt69E2t+iWg5Xu2DBnp90eHNr+/N/VhF4c2K//lcMkXo13k7mD8N7Do RWQNquwyWY/6kLqTWQqGWNtW3SVwOLBnO7AgFPY= X-Received: by 2002:a6b:1502:: with SMTP id 2-v6mr37623241iov.203.1531619888422; Sat, 14 Jul 2018 18:58:08 -0700 (PDT) MIME-Version: 1.0 References: <20180705161709.17028-1-bart.vanassche@wdc.com> In-Reply-To: From: Linus Torvalds Date: Sat, 14 Jul 2018 18:57:57 -0700 Message-ID: Subject: Re: [PATCH] kernel.h: Avoid that sparse complains about using sizeof(void) To: Kees Cook Cc: Bart Van Assche , Linux Kernel Mailing List , "Uecker, Martin" , Ingo Molnar , Miguel Ojeda , stable Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 14, 2018 at 6:49 PM Kees Cook wrote: > > I'm fine with this; it'll only activate for sparse. I'd like to get > Linus's eyes on it, though, since this macro caused us SO much pain > that I'm nervous to change it without some greater level of review. :) Honestly, I'd like to just encourage people to get the sparse update from Luc Van Oostenryck instead. For a while there it looked like Chris Li would just pull from Luc, and we'd have timely releases, but that really doesn't seem to have ended up happening after all. So right now it's probably just best to get Luc's tree instead from https://github.com/lucvoo/sparse-dev which also ends up fixing a lot of other issues. Linus