Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1207625imm; Sun, 15 Jul 2018 01:57:25 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeStQ57AuJSwxFG2xOWnrQyXHWvkBtMJiED4VCaCwDqJf70goMDKwwxBT+wpUBeOq1bEmwO X-Received: by 2002:a17:902:e281:: with SMTP id cf1-v6mr12608052plb.293.1531645045844; Sun, 15 Jul 2018 01:57:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531645045; cv=none; d=google.com; s=arc-20160816; b=Ja9WG3ZCKeFnBaGbnJ+pKOdsam/JepUbTxrja5q3tkS61xKYx9psm8FIsW0Y5m9k+T E3htetKRyaK7pcGMYFqleIWUUNWIq4wO8RmdpV+1YhriCk7GELPaO8mn8RLoPseFzEVe nUTz032VQ8mbfHP++jQw6lGIoVz4Jal5jS7p0qSfWHRBzpukX1vExqc4Bnzr92XYK9Ar cmvjBTM/JzJ/2fKB/Z8DnuYHWwnbnnxqj4p6GiQ0Gy2VDYTdY/wedmRaLfDWf0eWyqGK COxLBhRnLYhCHu0Sm+MEOIrCaMVYuk6oKOrGNdOiosNpqRLgdtIgcTu/wNnl64iH/+WS WjKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=Hlv/4+8T9RaYQSO7AjjR6Pm/eJyYsq3ofNI0fhMmYtI=; b=f/DMFd56mtYO25KIVBndiBSUacLrYCViTwYtsyVKff1/VSaLaoZXCwbui0yJt9SPSf c8c6GGIqiCM1qyPEIDamDo2XqOgYkLN6xZgd6ZW73B+w+xmnpsJlHIYLX9fpWf3E/RQU wVbAl0H60nsu9pLpj+8IY6QQemfajmZqzQV52GVEmljoINmLiy8GQdWlxdo5xxDUVPuw 1MUvLvFEJDAnJjMI+zi5tgjrS2zinoEALWqepS04kX959wlEhc9M/nUt40Xm8lDVVz5d 8iylY+IgYQSeWtY2wVQxAOe38Wy+GBWlJBTPIzz3+iEBn3h77oUJmoFI/9vleyQGqwxU r0TA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=GIZ+qtor; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e12-v6si26669258pfd.38.2018.07.15.01.57.11; Sun, 15 Jul 2018 01:57:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=GIZ+qtor; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726522AbeGOJSw (ORCPT + 99 others); Sun, 15 Jul 2018 05:18:52 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:46791 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726106AbeGOJSv (ORCPT ); Sun, 15 Jul 2018 05:18:51 -0400 Received: by mail-lf0-f67.google.com with SMTP id l16-v6so30125892lfc.13; Sun, 15 Jul 2018 01:56:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Hlv/4+8T9RaYQSO7AjjR6Pm/eJyYsq3ofNI0fhMmYtI=; b=GIZ+qtorVISNXsb9b63b+GBBNiexJ9GH9nmmXvKQJ43VmSOKW+lR3/dIxkCKNoSlQo dkyNI14CVgLxP0L1qwzO29UYdKkjUB3mySxH5hZ1k7cVHTPXaNqiBDG737kGKGrITtO4 jPa/hvRcAO6/BcisPjRZn3qJwN4wk5ljPknhv0Chz+bN5DJPdH6rNC343BQqf4wGzHBM vk6b9jTF+NFRyA1ejqfnskQ49HOntrC5j+w45Dt/IuWg9roS0YUIoUkjaNqWYLaPc/Dl OPleqF0ZZwC3JZvlhOjL1i02ucC0SKp1VQkMJxZVKJnNlnYzgZNpvwYaEQJwtYPtcKfq xqrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=Hlv/4+8T9RaYQSO7AjjR6Pm/eJyYsq3ofNI0fhMmYtI=; b=cDFiGKeVXBAhRrYkDeD7sDW/S3u5gaXgpGku2bYwBLPMKNcFX+MI12bNNLk5m+b1dP hJYkfQA53i6JccSoHNmiRtIcNVwjfj9aZ0vawml4hTjyiKhEqoNwX6vzY805jcljV5YS ve51exIHXNZVFdKId+JgjTQNOCK0uOf3NVza3wKdITgDeXPb06yDyPxSAl8RhX42VHc2 tTlKe04FlMtvmPgJgneGlMkAzCQjVB/VPLVMSxqdx4arI4NdkjgePNihJgrDDGEbVpVK VUNpBCBFIy7+YxfT+EGQQfyaT9kRaBKsvcCh4P5whzm0PJbNDt5NPzcf/Roev+81TmBS 5v2w== X-Gm-Message-State: AOUpUlEltHm1eJ+Jzrta3KyEANxFeGTmXXfrDRViEIillCFcaWvWge8m IHI+zd3UXSJWI2dMMPRbpqk= X-Received: by 2002:a19:7d84:: with SMTP id y126-v6mr9584170lfc.94.1531644996714; Sun, 15 Jul 2018 01:56:36 -0700 (PDT) Received: from xi.terra (c-8bb2e655.07-184-6d6c6d4.bbcust.telenor.se. [85.230.178.139]) by smtp.gmail.com with ESMTPSA id z7-v6sm3826580lfg.89.2018.07.15.01.56.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 15 Jul 2018 01:56:35 -0700 (PDT) Received: from johan by xi.terra with local (Exim 4.91) (envelope-from ) id 1fecpQ-000642-8I; Sun, 15 Jul 2018 10:56:28 +0200 Date: Sun, 15 Jul 2018 10:56:28 +0200 From: Johan Hovold To: sean.wang@mediatek.com Cc: robh+dt@kernel.org, mark.rutland@arm.com, marcel@holtmann.org, johan.hedberg@gmail.com, devicetree@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Rob Herring , Ulf Hansson , Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org Subject: Re: [PATCH v5 2/7] serdev: add dev_pm_domain_attach|detach() Message-ID: <20180715085628.GI10204@localhost> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 09, 2018 at 11:56:58PM +0800, sean.wang@mediatek.com wrote: > From: Sean Wang > > In order to open up the required power gate before any operation can be > effectively performed over the serial bus between CPU and serdev, it's > clearly essential to add common attach functions for PM domains to serdev > at the probe phase. > > Similarly, the relevant dettach function for the PM domains should be > properly and reversely added at the remove phase. > > Signed-off-by: Sean Wang > Reviewed-by: Ulf Hansson > Cc: Rob Herring > Cc: Ulf Hansson > Cc: Greg Kroah-Hartman > Cc: Jiri Slaby > Cc: linux-serial@vger.kernel.org Reviewed-by: Johan Hovold