Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1425574imm; Sun, 15 Jul 2018 07:28:11 -0700 (PDT) X-Google-Smtp-Source: AAOMgpf4nk+niVlKFG4+SA/P+n9J5Qd2AOucT6J65SUYQA2QW8NxR8nkHowojXZFx7+AVCD0PSMQ X-Received: by 2002:a63:9a01:: with SMTP id o1-v6mr12502218pge.439.1531664890976; Sun, 15 Jul 2018 07:28:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531664890; cv=none; d=google.com; s=arc-20160816; b=ibLR3g8JplnBZR22RT9AbroOurne08LhyYaIKi568bgci+YfVSmS6bUKlYpC9wIjXv vw4cTnVzGfpBHOro9JXn18oE4FJsfDNbAioYOFdxfjKpRFWiMiIMHyzh/OfjhU5SVcsO wNObcm/nWPcuPWXuYHLzdEej2bBXcais+3b+FSjx94oNklQrZkEkEEsohYTSZZc0fs20 izUGvOa/2fiC3c2mWgdOFOYHf3ZYUH6qSWJul9ktzjvg1nzq/cJeucd2y7D1U8H8Zx4e qogMFiFoRD/pY1ZPB7NfBSceEq18OClgPvy20vI+f/YJsdi5fvseJB7/lMF9VLcw0UUL MqdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :arc-authentication-results; bh=6YwEG9kh7dM2ehg4m+YotjYjh7T8mSESHJaApyZVks0=; b=dZj/ZFQOUjzZ7iWfPNzkv+GQhnYUx2DYI7scnNSwFzEYAFKfNhm3z5rCBelP1xZkWx K7ZtxEpbQreq5/2koT5T5kuQvBgWEIGNltqZn5pLclYylSP0hTLpS6XgDhI1h9Obr2oj cxN87PgbBAXGoMyEgjz1QdBGdRr+SfnCoNAKFUjn3Bqg3mSH9iWHrkkmyOQNUNWOzoqa oi/5ZYx+ZEwihTHcETN6dh0zXHxG6KcLKeDN2RRaWpYWsJn4ezuLpoyBtpT0t0nKlRBX qXYU5gro+3Zwj2T5LSHrfHs1yn23eALl0m5dBV0KZyYV4wdStGS/WPimCYT3uvxuUje8 5pQg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v129-v6si31166221pfc.330.2018.07.15.07.27.56; Sun, 15 Jul 2018 07:28:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726842AbeGOOuU (ORCPT + 99 others); Sun, 15 Jul 2018 10:50:20 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:57524 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726246AbeGOOuU (ORCPT ); Sun, 15 Jul 2018 10:50:20 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3BDFF406DE3D; Sun, 15 Jul 2018 14:27:11 +0000 (UTC) Received: from [10.36.116.39] (ovpn-116-39.ams2.redhat.com [10.36.116.39]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E961C76CE; Sun, 15 Jul 2018 14:27:04 +0000 (UTC) Subject: Re: [PATCH] x86/kvm/vmx: don't read current->thread.{fs,gs}base of legacy tasks To: Vitaly Kuznetsov , Sean Christopherson Cc: kvm@vger.kernel.org, =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , x86@kernel.org, Andy Lutomirski , "Dmitry V . Levin" , Masatake YAMATO , linux-kernel@vger.kernel.org References: <20180711173718.8850-1-vkuznets@redhat.com> <20180713164650.GA14830@linux.intel.com> <87lgafvz6p.fsf@vitty.brq.redhat.com> From: Paolo Bonzini Openpgp: preference=signencrypt Autocrypt: addr=pbonzini@redhat.com; prefer-encrypt=mutual; keydata= xsEhBFRCcBIBDqDGsz4K0zZun3jh+U6Z9wNGLKQ0kSFyjN38gMqU1SfP+TUNQepFHb/Gc0E2 CxXPkIBTvYY+ZPkoTh5xF9oS1jqI8iRLzouzF8yXs3QjQIZ2SfuCxSVwlV65jotcjD2FTN04 hVopm9llFijNZpVIOGUTqzM4U55sdsCcZUluWM6x4HSOdw5F5Utxfp1wOjD/v92Lrax0hjiX DResHSt48q+8FrZzY+AUbkUS+Jm34qjswdrgsC5uxeVcLkBgWLmov2kMaMROT0YmFY6A3m1S P/kXmHDXxhe23gKb3dgwxUTpENDBGcfEzrzilWueOeUWiOcWuFOed/C3SyijBx3Av/lbCsHU Vx6pMycNTdzU1BuAroB+Y3mNEuW56Yd44jlInzG2UOwt9XjjdKkJZ1g0P9dwptwLEgTEd3Fo UdhAQyRXGYO8oROiuh+RZ1lXp6AQ4ZjoyH8WLfTLf5g1EKCTc4C1sy1vQSdzIRu3rBIjAvnC tGZADei1IExLqB3uzXKzZ1BZ+Z8hnt2og9hb7H0y8diYfEk2w3R7wEr+Ehk5NQsT2MPI2QBd wEv1/Aj1DgUHZAHzG1QN9S8wNWQ6K9DqHZTBnI1hUlkp22zCSHK/6FwUCuYp1zcAEQEAAc0f UGFvbG8gQm9uemluaSA8Ym9uemluaUBnbnUub3JnPsLBTQQTAQIAIwUCVEJ7AwIbAwcLCQgH AwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEH4VEAzNNmmxNcwOniaZVLsuy1lW/ntYCA0Caz0i sHpmecK8aWlvL9wpQCk4GlOX9L1emyYXZPmzIYB0IRqmSzAlZxi+A2qm9XOxs5gJ2xqMEXX5 FMtUH3kpkWWJeLqe7z0EoQdUI4EG988uv/tdZyqjUn2XJE+K01x7r3MkUSFz/HZKZiCvYuze VlS0NTYdUt5jBXualvAwNKfxEkrxeHjxgdFHjYWhjflahY7TNRmuqPM/Lx7wAuyoDjlYNE40 Z+Kun4/KjMbjgpcF4Nf3PJQR8qXI6p3so2qsSn91tY7DFSJO6v2HwFJkC2jU95wxfNmTEUZc znXahYbVOwCDJRuPrE5GKFd/XJU9u5hNtr/uYipHij01WXal2cce1S5mn1/HuM1yo1u8xdHy IupCd57EWI948e8BlhpujUCU2tzOb2iYS0kpmJ9/oLVZrOcSZCcCl2P0AaCAsj59z2kwQS9D du0WxUs8waso0Qq6tDEHo8yLCOJDzSz4oojTtWe4zsulVnWV+wu70AioemAT8S6JOtlu60C5 dHgQUD1Tp+ReXpDKXmjbASJx4otvW0qah3o6JaqO79tbDqIvncu3tewwp6c85uZd48JnIOh3 utBAu684nJakbbvZUGikJfxd887ATQRUQnHuAQgAx4dxXO6/Zun0eVYOnr5GRl76+2UrAAem Vv9Yfn2PbDIbxXqLff7oyVJIkw4WdhQIIvvtu5zH24iYjmdfbg8iWpP7NqxUQRUZJEWbx2CR wkMHtOmzQiQ2tSLjKh/cHeyFH68xjeLcinR7jXMrHQK+UCEw6jqi1oeZzGvfmxarUmS0uRuf fAb589AJW50kkQK9VD/9QC2FJISSUDnRC0PawGSZDXhmvITJMdD4TjYrePYhSY4uuIV02v02 8TVAaYbIhxvDY0hUQE4r8ZbGRLn52bEzaIPgl1p/adKfeOUeMReg/CkyzQpmyB1TSk8lDMxQ zCYHXAzwnGi8WU9iuE1P0wARAQABwsEzBBgBAgAJBQJUQnHuAhsMAAoJEH4VEAzNNmmxp1EO oJy0uZggJm7gZKeJ7iUpeX4eqUtqelUw6gU2daz2hE/jsxsTbC/w5piHmk1H1VWDKEM4bQBT uiJ0bfo55SWsUNN+c9hhIX+Y8LEe22izK3w7mRpvGcg+/ZRG4DEMHLP6JVsv5GMpoYwYOmHn plOzCXHvmdlW0i6SrMsBDl9rw4AtIa6bRwWLim1lQ6EM3PWifPrWSUPrPcw4OLSwFk0CPqC4 HYv/7ZnASVkR5EERFF3+6iaaVi5OgBd81F1TCvCX2BEyIDRZLJNvX3TOd5FEN+lIrl26xecz 876SvcOb5SL5SKg9/rCBufdPSjojkGFWGziHiFaYhbuI2E+NfWLJtd+ZvWAAV+O0d8vFFSvr iy9enJ8kxJwhC0ECbSKFY+W1eTIhMD3aeAKY90drozWEyHhENf4l/V+Ja5vOnW+gCDQkGt2Y 1lJAPPSIqZKvHzGShdh8DduC0U3xYkfbGAUvbxeepjgzp0uEnBXfPTy09JGpgWbg0w91GyfT /ujKaGd4vxG2Ei+MMNDmS1SMx7wu0evvQ5kT9NPzyq8R2GIhVSiAd2jioGuTjX6AZCFv3ToO 53DliFMkVTecLptsXaesuUHgL9dKIfvpm+rNXRn9wAwGjk0X/A== Message-ID: <7a455c76-50c5-814a-0a75-c3a8b3ce4eeb@redhat.com> Date: Sun, 15 Jul 2018 16:27:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <87lgafvz6p.fsf@vitty.brq.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Sun, 15 Jul 2018 14:27:11 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Sun, 15 Jul 2018 14:27:11 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'pbonzini@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/07/2018 19:10, Vitaly Kuznetsov wrote: >> Because bikeshedding is fun, what do you think about using fs_base and >> kernel_gs_base for these names? I have a series that touches this >> code and also adds local variables for {FS,GS}.base and {FS,GS}.sel. >> I used {fs,gs}_base and {fs,gs}_sel to be consistent with the >> vmx->host_state nomenclature (the local variables are used to update >> the associated vmx->host_state variables), but I'll change my patches >> if you have a strong preference for omitting the underscore. >> > I have nothing against underscores :-) > > Hope this small change can be done by Paolo/Radim upon commit. Or I'll > send v2 if needed. Yup, I've made the change and queued for 4.18-rc. Paolo