Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <CAE5jQCe4nX8m1f5jPL57GeU32CftNv+NvgNmZxufH85nun1o7w@mail.gmail.com>
 <878t6c7f8p.fsf@mail.parknet.co.jp> <20180715143043.GM30522@ZenIV.linux.org.uk>
In-Reply-To: <20180715143043.GM30522@ZenIV.linux.org.uk>
From:   Anatoly Trosinenko <anatoly.trosinenko@gmail.com>
Date:   Sun, 15 Jul 2018 18:08:23 +0300
Message-ID: <CAE5jQCcs2x4myTHUhNmHPZvhMuPsrkzLmiqqeF5wzZ-Hf5druQ@mail.gmail.com>
Subject: Re: FAT: Operating on broken FAT FS causes the write syscall to
 return negative number not equal to -1
To:     viro@zeniv.linux.org.uk
Cc:     OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
        akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Thank you!

> This patch returns better error (-EIO) for me.

This works for me likewise.

> (But note, the corrupted FS image doesn't guarantee POSIX behavior.)

Oops, I was just doing some testing and thought that correct behavior
for crafted FS is to return arbitrary valid error code (like -EIO) or
some arbitrary data, say, not larger than FS (not disclosing the
kernel memory, of course). Please excuse me if I was wrong. If fixing
this would slow down some hot code path, then I am not insisting on
returning valid errno. :)

Meanwhile, how should be considered such discrepancies with man pages
for invalid FS images: should it be considered low priority bug,
not-a-bug or feature request (diagnostics)?


Thanks
Anatoly

=D0=B2=D1=81, 15 =D0=B8=D1=8E=D0=BB. 2018 =D0=B3. =D0=B2 17:30, Al Viro <vi=
ro@zeniv.linux.org.uk>:
>
> On Sun, Jul 15, 2018 at 11:20:06PM +0900, OGAWA Hirofumi wrote:
> > +static inline bool fat_valid_entry(struct msdos_sb_info *sbi, int entr=
y)
> > +{
> > +     if (entry < FAT_START_ENT || sbi->max_cluster <=3D entry)
> > +             return false;
> > +     return true;
> > +}
>
> Pet peeve: if (...) return false; return true; instead of return !....;
>
> In this case,
>         return entry >=3D FAT_START_ENT && entry < sb->max_cluster;