Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1776893imm; Sun, 15 Jul 2018 17:01:44 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeYIGoWLbhrWAdzqv1oozN3xvaMWU4zuzYCTEfbgEzAs/2LrATHz0MZVkAC1Beglr8bRaIZ X-Received: by 2002:a17:902:bd81:: with SMTP id q1-v6mr806959pls.238.1531699303951; Sun, 15 Jul 2018 17:01:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531699303; cv=none; d=google.com; s=arc-20160816; b=K9StcamEiR5Ybp+k5MAM664zkK5Nug4pSppHjT+N9/6wEXQC4OA8zLiuj26kvj+YEQ Mu+zGVMUjCNbMf6NkNroJwx02ZQoDHovwFd0sGzT+E4uKxnkjItBNgbUNzaHpSFQ6he3 rt6xfGKYhWqLXIh1pk+BvHQaQXgb7BgpdK8VxxNmqwNYT12t3l0W+J303Z+HPNaeUT46 W5pyTTdwMNLLkI24VhwltIpf8J0T29RMiioUhau1/68x+lRoh1MkMvMovqLkTaHsIAb7 ZrdbIUv3jn+78qslJDihIrJRZT2AN2uGTEgn1EkDf60vCSW0GFcAqK574Md/VSI9J9XS 7zeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=aWeDc3NPPfMvk56yp9OSUAVHAOcX5svIIZIZSxCyWKQ=; b=xdBj5tpcp9rTUtaF4JEOL0w9f4/t1l5WY9jioezIiLVOJEOleCttrtmXxy6VPtKmo6 orXF+GhQsBHd7v2hBMddf6JihvuK1VgfbgAov6NPjQxXWUnZVxlqwnkhAmtIsiUu+D8D g8iCleIECVvWdfLWWaqBm63BUcN9zrNZ38F80bnZx5GERxmiI9PvELmSm7bUkszPkA9t wPM3wuCasLt3C3uVs+37sQjmS7YUeLaO/Ktqtoe+xxGeSnpGytipqQ3uSA58uOsAX59Z SCaQ9tYvx0vP6X7ODUqsUxjl3QGIXZ/9icZrEPQNaDKnVwwWi+XGQKFKuAhKF/KwK+O4 ftjw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b8-v6si28500229ple.469.2018.07.15.17.01.29; Sun, 15 Jul 2018 17:01:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727203AbeGPAZh (ORCPT + 99 others); Sun, 15 Jul 2018 20:25:37 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:34328 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727051AbeGPAZh (ORCPT ); Sun, 15 Jul 2018 20:25:37 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1feqwb-0002Bi-UP; Mon, 16 Jul 2018 08:00:49 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1feqwY-0001o4-DI; Mon, 16 Jul 2018 08:00:46 +0800 Date: Mon, 16 Jul 2018 08:00:46 +0800 From: Herbert Xu To: Davidlohr Bueso Cc: akpm@linux-foundation.org, tgraf@suug.ch, linux-kernel@vger.kernel.org, Davidlohr Bueso Subject: Re: [PATCH] lib/rhashtable: consider param->min_size when setting initial table size Message-ID: <20180716000046.yscgnpr256qhm2qg@gondor.apana.org.au> References: <20180714062516.30433-1-dave@stgolabs.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180714062516.30433-1-dave@stgolabs.net> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 13, 2018 at 11:25:16PM -0700, Davidlohr Bueso wrote: > rhashtable_init() currently does not take into account the user-passed > min_size parameter unless param->nelem_hint is set as well. As such, > the default size (number of buckets) will always be HASH_DEFAULT_SIZE > even if the smallest allowed size is larger than that. Remediate this > by unconditionally calling into rounded_hashtable_size() and handling > things accordingly. > > Signed-off-by: Davidlohr Bueso Acked-by: Herbert Xu Normally these patches go through netdev so could you please resend it with my ack to netdev@vger.kernel.org? Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt