Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1887395imm; Sun, 15 Jul 2018 20:29:17 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeB5/DyxFO5Mdu1a9uvHaC1vVFYCQhu7hVz6Kzesi/xig1oqMULBxfhH3LZv+dkZo9KN9SH X-Received: by 2002:a63:4203:: with SMTP id p3-v6mr14021102pga.184.1531711757649; Sun, 15 Jul 2018 20:29:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531711757; cv=none; d=google.com; s=arc-20160816; b=kaMEtec/a7DTvmPFljkGi5iQWc+B8fJEbbUWHIfMOh5UT7CccvKJdDsg/Tmo/6Uy6N Y9dQApolqnMJKxa0v2HlH7qz0MZKJs2XvdHd2kGad2j4FPY3f9ueyUWHA/066qviDkm7 sSDL3IdbKG1YUVl2iU9OowR3RETdVqLWTwc0pNp1zs9J8sQFMBnz8sup48OvmlqdEqTv yJ8OYFzXWOJOKgs+JN4vOkr4CCQ3d3q/yNuCs3mlqG38hsPyTptQp4zy+V+zIOb6iTSV rzYDjzGhvoiDFqeYievvVq2x5HmFjeahstQ3RJENb6qV+6u/L9OzfPz/KrZ/eIMyMagn 3YiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=2RVhellQFVJHFftC0Gx0wK5BYjfUPhFpiCS+52iIufE=; b=iuZcwqyRlFPd6C1uXXWhlj3U0czqaQKyZadCweCt3ZfdPk9u1xKk/vwmqHhoFslPtY U2Ni9eZHA7q+WDG/X6YCHfgXAQ2+IO0Hb9wFJIajAJ3F9E0vbbd9M9c6wTXnz9aEhbu1 HhwhuF76aUeuhmhxWq+WF0UGV2NIaUuDOZcYZjERfwaRYaMxbRxUQUbizV9TXzFO7kgw DOpIOGxnN9cjoiodZAjQRJyDAP2EfW5YBtIAQAOoIVYvkUwF4jr7iOIy0iQfykK5XlHb xh95lYeXVUxtaLDu0VBuEDwpLv78cZ9+FGppV1j8DFSfLmQOMPyl6JlzZzS2S0WLyowL /Rog== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n64-v6si30682080pgn.247.2018.07.15.20.29.02; Sun, 15 Jul 2018 20:29:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727957AbeGPDxk (ORCPT + 99 others); Sun, 15 Jul 2018 23:53:40 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:37584 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727374AbeGPDxk (ORCPT ); Sun, 15 Jul 2018 23:53:40 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6C339402312B; Mon, 16 Jul 2018 03:28:23 +0000 (UTC) Received: from jason-ThinkPad-T450s.redhat.com (ovpn-12-140.pek2.redhat.com [10.72.12.140]) by smtp.corp.redhat.com (Postfix) with ESMTP id 77F852026D66; Mon, 16 Jul 2018 03:28:18 +0000 (UTC) From: Jason Wang To: mst@redhat.com, jasowang@redhat.com Cc: kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, wexu@redhat.com, jfreimann@redhat.com, tiwei.bie@intel.com, maxime.coquelin@redhat.com Subject: [PATCH net-next V2 0/8] Packed virtqueue support for vhost Date: Mon, 16 Jul 2018 11:28:03 +0800 Message-Id: <1531711691-6769-1-git-send-email-jasowang@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Mon, 16 Jul 2018 03:28:23 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Mon, 16 Jul 2018 03:28:23 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'jasowang@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi all: This series implements packed virtqueues. The code were tested with Tiwei's guest driver series at https://patchwork.ozlabs.org/cover/942297/ Pktgen test for both RX and TX does not show obvious difference with split virtqueues. The main bottleneck is the guest Linux driver, since it can not stress vhost for a 100% CPU utilization. A full TCP benchmark is ongoing. Will test virtio-net pmd as well when it was ready. Notes: - This version depends on Tiwei's series at https://patchwork.ozlabs.org/cover/942297/ This version were tested with: - Zerocopy (Out of Order) support - vIOMMU support - mergeable buffer on/off - busy polling on/off - vsock (nc-vsock) Changes from V1: - drop uapi patch and use Tiwei's - split the enablement of packed virtqueue into a separate patch Changes from RFC V5: - save unnecessary barriers during vhost_add_used_packed_n() - more compact math for event idx - fix failure of SET_VRING_BASE when avail_wrap_counter is true - fix not copy avail_wrap_counter during GET_VRING_BASE - introduce SET_VRING_USED_BASE/GET_VRING_USED_BASE for syncing last_used_idx - rename used_wrap_counter to last_used_wrap_counter - rebase to net-next Changes from RFC V4: - fix signalled_used index recording - track avail index correctly - various minor fixes Changes from RFC V3: - Fix math on event idx checking - Sync last avail wrap counter through GET/SET_VRING_BASE - remove desc_event prefix in the driver/device structure Changes from RFC V2: - do not use & in checking desc_event_flags - off should be most significant bit - remove the workaround of mergeable buffer for dpdk prototype - id should be in the last descriptor in the chain - keep _F_WRITE for write descriptor when adding used - device flags updating should use ADDR_USED type - return error on unexpected unavail descriptor in a chain - return false in vhost_ve_avail_empty is descriptor is available - track last seen avail_wrap_counter - correctly examine available descriptor in get_indirect_packed() - vhost_idx_diff should return u16 instead of bool Changes from RFC V1: - Refactor vhost used elem code to avoid open coding on used elem - Event suppression support (compile test only). - Indirect descriptor support (compile test only). - Zerocopy support. - vIOMMU support. - SCSI/VSOCK support (compile test only). - Fix several bugs Jason Wang (8): vhost: move get_rx_bufs to vhost.c vhost: hide used ring layout from device vhost: do not use vring_used_elem vhost_net: do not explicitly manipulate vhost_used_elem vhost: vhost_put_user() can accept metadata type vhost: packed ring support vhost: event suppression for packed ring vhost: enable packed virtqueues drivers/vhost/net.c | 143 ++----- drivers/vhost/scsi.c | 62 +-- drivers/vhost/vhost.c | 994 ++++++++++++++++++++++++++++++++++++++++----- drivers/vhost/vhost.h | 55 ++- drivers/vhost/vsock.c | 42 +- include/uapi/linux/vhost.h | 7 + 6 files changed, 1035 insertions(+), 268 deletions(-) -- 2.7.4