Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2038691imm; Mon, 16 Jul 2018 00:39:20 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdK9fMZslkjn9JeDSmOIEGAY+yzSfS2SISCK+i1tZr2f9n7qlmVkseegmj6+lDLnWMLw1kj X-Received: by 2002:a65:5106:: with SMTP id f6-v6mr14333595pgq.72.1531726760614; Mon, 16 Jul 2018 00:39:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531726760; cv=none; d=google.com; s=arc-20160816; b=zFeMM2XyIZy5G+HX2HvScgFIYYHCxgzKXMchgMMDXCBYedgJ6SWPKDZEgTHb9pQQJD C9iAn0qcWeX7yy6f7fZqIl1SR20upaRqDihyeidy7FruaAPugYhNg9SfsSeEgiyTu1xE pI/83wDtjhycFrjOjd6XP7KJ5UqThx8ImaPgdP9DO9D+Uy9fa3ADcLjgSa55p1a8HxMi lB7T0eYPmBt2BnOQJBYIKd7BW9GU1kM5+SGOFlKeCNtxu6NMP4T3Z8lvFIsyA+dHwEj3 hzLT+sDFJZKdtaBvWrH09VTUpH7VoNCQvj1JAHeYFsbDooCTj676vZZFKf7E0KYisb5m q6JQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=oIOwuQqC0hRolMk9347XTg++woN+CLgvsG8KopXfJL8=; b=Yaxc9uUAnS8lCRZd1I5NywqZ0ALMpPerEHjJOAgwHl/ZB60cneGBscTFuSTsgsyjiZ p8zIHhxQJ4coiOLp5C7zWalONGd+B0sCQyBjJrU8rnJAnt3rOvTa5BQA7Z7CONEprTcl s4wuYVxRpRLl3kmh+tQX2vQuDTKWIQWMFZyBGD7qi9XbE7OKNp+X9pYXFkE0uFsa8O0O fppvErC+TmhM7MnMsyidWbGqtRPRqGoRMx+NywdwaB1cFtBtqsgVeUwhr1WyLE7+VVDE z++kJEAiLq+5tpqzF8qCiSXarjIoRVQ6Zmt5GpTwFPStTOUcaLSvTeeAKZDmqBbEUEId BIig== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m141-v6si33250897pfd.310.2018.07.16.00.39.05; Mon, 16 Jul 2018 00:39:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732014AbeGPIDw (ORCPT + 99 others); Mon, 16 Jul 2018 04:03:52 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:46782 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728460AbeGPIDw (ORCPT ); Mon, 16 Jul 2018 04:03:52 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 522FCC03; Mon, 16 Jul 2018 07:37:51 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yoshihiro Shimoda , Geert Uytterhoeven , Simon Horman , Ulf Hansson Subject: [PATCH 4.17 11/67] mmc: renesas_sdhi_internal_dmac: Cannot clear the RX_IN_USE in abort Date: Mon, 16 Jul 2018 09:34:40 +0200 Message-Id: <20180716073444.849899456@linuxfoundation.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180716073443.294323458@linuxfoundation.org> References: <20180716073443.294323458@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.17-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yoshihiro Shimoda commit 25a98edd5795719c5187e16ea271e8de86e02809 upstream. This patch is fixes an issue that the SDHI_INTERNAL_DMAC_RX_IN_USE flag cannot be cleared because tmio_mmc_core sets the host->data to NULL before the tmio_mmc_core calls tmio_mmc_abort_dma(). So, this patch clears the SDHI_INTERNAL_DMAC_RX_IN_USE in the renesas_sdhi_internal_dmac_abort_dma() anyway. This doesn't cause any side effects. Fixes: 0cbc94daa554 ("mmc: renesas_sdhi_internal_dmac: limit DMA RX for old SoCs") Cc: # v4.17+ Signed-off-by: Yoshihiro Shimoda Reviewed-by: Geert Uytterhoeven Reviewed-by: Simon Horman Signed-off-by: Ulf Hansson Signed-off-by: Greg Kroah-Hartman --- drivers/mmc/host/renesas_sdhi_internal_dmac.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/mmc/host/renesas_sdhi_internal_dmac.c +++ b/drivers/mmc/host/renesas_sdhi_internal_dmac.c @@ -139,8 +139,7 @@ renesas_sdhi_internal_dmac_abort_dma(str renesas_sdhi_internal_dmac_dm_write(host, DM_CM_RST, RST_RESERVED_BITS | val); - if (host->data && host->data->flags & MMC_DATA_READ) - clear_bit(SDHI_INTERNAL_DMAC_RX_IN_USE, &global_flags); + clear_bit(SDHI_INTERNAL_DMAC_RX_IN_USE, &global_flags); renesas_sdhi_internal_dmac_enable_dma(host, true); }