Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 16 Jul 2018 09:48:28 +0200 (CEST)
From:   Thomas Gleixner <tglx@linutronix.de>
To:     "Yang, Bin" <bin.yang@intel.com>
cc:     "mingo@kernel.org" <mingo@kernel.org>,
        "hpa@zytor.com" <hpa@zytor.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "Gross, Mark" <mark.gross@intel.com>,
        "x86@kernel.org" <x86@kernel.org>,
        "Hansen, Dave" <dave.hansen@intel.com>
Subject: Re: [PATCH] x86/mm: fix cpu stuck issue in
 __change_page_attr_set_clr
In-Reply-To: <6957364e872792c9cc310cf4928ae90771f2b69a.camel@intel.com>
Message-ID: <alpine.DEB.2.21.1807160946210.2644@nanos.tec.linutronix.de>
References: <1530180340-18593-1-git-send-email-bin.yang@intel.com>    <alpine.DEB.2.21.1807031442030.1601@nanos.tec.linutronix.de>    <0131cecd5d0456c2a109f4b8bdbfe558389671dd.camel@intel.com>    <alpine.DEB.2.21.1807040849520.1816@nanos.tec.linutronix.de>
   <3224aae1d09788aba687fd7bd9e088f233016fc8.camel@intel.com>   <alpine.DEB.2.21.1807041119260.1816@nanos.tec.linutronix.de>  <34a76fad5c43c11ce8ceb491537b453d8053bdb2.camel@intel.com>  <alpine.DEB.2.21.1807041221110.1816@nanos.tec.linutronix.de>
 <6957364e872792c9cc310cf4928ae90771f2b69a.camel@intel.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 10 Jul 2018, Yang, Bin wrote:
> > +	 * FIXME:
> > +	 * 1) Make this yell loudly if something tries to set a full
> > +	 *    large page to something which is not allowed.
> 
> I am trying to work out a patch based on your sample code and
> comments. 
> I do not understand here why it needs to yell loudly if set a full
> large page to something which is not allowed. It can split the large
> page to 4K-pages finally. And static_protection() will also be called
> for 4K-page change. Why not just add warning if 4K-page change is not
> allowed?

Think about it. If there is a large page which contains an area which
requires a different mapping that the one which the large page provides,
then something went wrong _before_ this code is called.

Thanks,

	tglx