Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2051822imm; Mon, 16 Jul 2018 00:59:10 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeQh67+ePI+sS/HymTGGHsXCo4NU+oJXTank4PLEWJlHrE79w47Shw+Jh5PA/ci9eO0EOk/ X-Received: by 2002:a63:8c0b:: with SMTP id m11-v6mr14706163pgd.372.1531727950309; Mon, 16 Jul 2018 00:59:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531727950; cv=none; d=google.com; s=arc-20160816; b=SXmqzVoSppIPAnoDcX2u37s0lxsZZASKhZJ5HV2KAOsvGvUj3Da3zax8G0wraN3rzg xbzO8UdQMB8heLkdQQ9e3HemrR+BOfrQHnSuPiH7WHAsb5FkLfMW9smwMNo/IlIlC4p/ yPegFmsJGH8p0veOZTEN3tOHFytgVSWrLQj/Yjy0D/WKR8VCWxJQzrybU31Sh4hzd4Kk P2lM5dWlHTZ7mUGvdQlDuQJZ8VTJ3sF9VJeCFEW+6stxXvXN12FWoZuHXHUxIfOvS/8R 7HLxXVZhyO0e9UPzOa3E+2h79p/R39on4q1R6yykT7oKT5ytTAhUn+n9yP5/hjGz4gq8 Rnhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date :arc-authentication-results; bh=mpi4QoflrDCqPSvC4CXz+EeIZQELIdyIK7K6Df0UoWc=; b=PwUvn5UBU/yEDuW9bgzcqRB74YXw8oPTcq8fnv2ZeKTgQFxypXcHnuVUpUGgacXd5A c9vl5oGse2k9twB7w2bP97sFwePjkezfogYht/q0/YdIYZFwQ8BXAKTr8PVPpMpV+yCl 28uKXKREnxVldwQQxFG4Jv8rrzf25IsCMzB817tRz3g010aH7edXWnyk8J6opBVeoEPx 7FyP2HVvHxhG0/D0v0Byk2zUM1kvoN4BePVkOfrHO1Z9wTm/LFe9/iiT29q4pBn5/SR2 zQgP5qyxK+c26EO/vIH4cILo1yyDDSGj2KmtClOJiBE9fBVUlbu38fEMZm+HCntWaUe1 5Xng== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j1-v6si10185968pll.493.2018.07.16.00.58.55; Mon, 16 Jul 2018 00:59:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727494AbeGPIXv convert rfc822-to-8bit (ORCPT + 99 others); Mon, 16 Jul 2018 04:23:51 -0400 Received: from muru.com ([72.249.23.125]:51568 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726190AbeGPIXu (ORCPT ); Mon, 16 Jul 2018 04:23:50 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id A37CD80EE; Mon, 16 Jul 2018 08:00:52 +0000 (UTC) Date: Mon, 16 Jul 2018 00:57:40 -0700 From: Tony Lindgren To: Pavel Machek Cc: Sebastian Reichel , kernel list , linux-arm-kernel , linux-omap@vger.kernel.org, nekit1000@gmail.com, mpartap@gmx.net, merlijn@wizzup.org Subject: Re: [PATCH] pwm-omap: handle timers not ready in probe Message-ID: <20180716075740.GT99251@atomide.com> References: <20180709081534.GA6799@amd> <20180709214910.tes6u4ivxomd3aja@earth.universe> <20180709220211.GA7760@amd> <20180710101147.lyu65ro4czvrs2da@earth.universe> <20180710133040.GA4391@amd> <20180710161123.azym6sbboriuj4yc@earth.universe> <20180711080218.GA21225@amd> <20180711132739.GL99251@atomide.com> <20180711142526.dto6iost57zx5t5l@earth.universe> <20180716071323.GB23110@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <20180716071323.GB23110@amd> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Pavel Machek [180716 07:16]: > > When all the drivers are built-in, timers are not ready and probing > fails. Fix that with -EPROBE_DEFFER. > > Signed-off-by: Pavel Machek > > diff --git a/drivers/pwm/pwm-omap-dmtimer.c b/drivers/pwm/pwm-omap-dmtimer.c > index 665da3c..debeb70 100644 > --- a/drivers/pwm/pwm-omap-dmtimer.c > +++ b/drivers/pwm/pwm-omap-dmtimer.c > @@ -265,7 +271,7 @@ static int pwm_omap_dmtimer_probe(struct platform_device *pdev) > timer_pdata = dev_get_platdata(&timer_pdev->dev); > if (!timer_pdata) { > dev_err(&pdev->dev, "dmtimer pdata structure NULL\n"); > - ret = -EINVAL; > + ret = -EPROBE_DEFER; > goto put; > } There seems to be an earlier similar patch, care to take a look at "[PATCH] pwm: pwm-omap-dmtimer: return -EPROBE_DEFER if no dmtimer platform data"? Regards, Tony