Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 16 Jul 2018 09:23:39 +0100
From:   Daniel Thompson <daniel.thompson@linaro.org>
To:     Dominique Martinet <asmadeus@codewreck.org>
Cc:     David Laight <David.Laight@ACULAB.COM>,
        Jason Wessel <jason.wessel@windriver.com>,
        Arnd Bergmann <arnd@arndb.de>,
        kgdb-bugreport@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 14/18] kdb_support: change strncpy+truncation to strlcpy
Message-ID: <20180716082339.tcczk5tdnruhr47x@holly.lan>
References: <93d3ace9a35b4436930ed0521127c12b@AcuMS.aculab.com>
 <20180713103321.thjpohla6fuszona@holly.lan>
 <20180713151851.GA14190@nautica>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180713151851.GA14190@nautica>
User-Agent: NeoMutt/20180622
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Jul 13, 2018 at 05:18:51PM +0200, Dominique Martinet wrote:
> Daniel Thompson wrote on Fri, Jul 13, 2018:
> > On Fri, Jul 13, 2018 at 03:25:58AM +0200, Dominique Martinet wrote:
> > > Generated by scripts/coccinelle/misc/strncpy_truncation.cocci
> > > 
> > > Signed-off-by: Dominique Martinet <asmadeus@codewreck.org>
> > 
> > It would have been good for you to mention in the changelog how
> > you reviewed your change to verify that the extra zero padding
> > from strncpy() isn't required.
> 
> I'm sorry, I went a bit too fast with the send-email button on this
> path series; I agree it is lacking.
> 
> > However... I have taken a look and can't see any problem so:
> > 
> > Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> 
> Thank you for the review, I will update the commit message with more
> details and change strlcpy to strscpy in a v2

You can keep the reviewed by after the change to strscpy().