Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2082242imm; Mon, 16 Jul 2018 01:41:54 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfu0V5FJRd6s3RvdOLAnxw7MSfEbIKtEG2Qneoj3z6u4jSqVURoWF5ZDc2To7Pf1itTdSG4 X-Received: by 2002:a17:902:8347:: with SMTP id z7-v6mr16119877pln.290.1531730514541; Mon, 16 Jul 2018 01:41:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531730514; cv=none; d=google.com; s=arc-20160816; b=OIS3Nuu3oGSWGksudV6E0Lmx+uaSk/Bq/0bdJKHXRJYjkks9DTmkBmPdVKzT04Lgnx DUFc71rvZWh7MTW/7JsAXj1P0teE231teF4X95leEiEA78JNCD6pxZ/ouJW1o7gU2eGy azWepikCi8gmI7QQonwys2ba40mzvndWaqSckyhGuIVPOi3c1gjdjMWSp9SM+eYPebdy tXvx6tASbK0AppK3tzkUpHsxJfNlewRosneoQcERT3uZBBElkz2zx5hpZ/mNUn7Jf472 RTyjebSc2pWk5kDz9yUWM+CanqsFbhIClhywpvqiC4dBeE5jnii5gXyepIab0zFomBW6 skpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=ZpBZo27p75oPxD6lc9iJoqoyZ6LRCYsVOZJQSG3ReLQ=; b=kkrsmQ+WeYgH79INJcmWR8+E/ZhJj6FVexYd0gYB045CyzbJ/t/4SniLYGNS8RUNcS qPlmqglFmYSHZBLA123AD6LC8lj5RzbdAMRQcc2zTZ1lvEREXZUCMn6rK1RMUlOJkPCA yaOvTL1+hhAxeGY2PP84p9VLNemw614Yw4aml0Qb1u/6sBt8DjYGOOHh5cofvg2c54cI lh2UMjEt1iRTSkjBJZaOYawLUATmMr8DhElKiCiHDhpLnM7tCCXfmNHqKLiy4KxZdhsa 9NV+x5zL2xggRF/z8vdEUohgaGKWhe5V6jfiH8wOTbwgEVimeSN54rxCWOSmu6Njlxok Va8Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c6-v6si29509671pgn.143.2018.07.16.01.41.38; Mon, 16 Jul 2018 01:41:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730688AbeGPJGm (ORCPT + 99 others); Mon, 16 Jul 2018 05:06:42 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:36760 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727848AbeGPJGl (ORCPT ); Mon, 16 Jul 2018 05:06:41 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 048B0D5E; Mon, 16 Jul 2018 08:40:22 +0000 (UTC) Date: Mon, 16 Jul 2018 10:40:20 +0200 From: Greg KH To: John Whitmore Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, tglx@linutronix.de, kstewart@linuxfoundation.org, pombredanne@nexb.com Subject: Re: staging:rtl8192u: [0/10] Coding style changes. Message-ID: <20180716084020.GA8260@kroah.com> References: <20180713201247.21428-1-johnfwhitmore@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180713201247.21428-1-johnfwhitmore@gmail.com> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 13, 2018 at 09:12:37PM +0100, John Whitmore wrote: > All coding style changes, but the second [2/10] is a bit more hairy then > most. The original code combined two typedef declarations into one with both > the structure and a pointer to the structure defined. I've totally removed the > pointer to the structure type since it uses Hungarian notation, which the > coding standard isn't keen on. > > As a result of this there are changes in code from the type: > PStructType *ppname; > to: > struct StructType **ppname; > > To keep the diff simple I've kept the current nameing of "ppname", which again > is Hungarian notation. I'll leave that for a future patch. Nit, your subject should look like: Subject: [PATCH 00/10] staging:rtl8192u: Coding style changes. What are you using to generate this email? git format-patch --cover-letter should generate it with a correct subject line prefix, right? thanks, greg k-h