Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2095893imm; Mon, 16 Jul 2018 02:01:13 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeub71MiNWWJwsdnBVR5e79ekwuBEMrwjYbg78auU8yJhXxROSsVWiO1OUNBz8AcDOmegmu X-Received: by 2002:aa7:81d3:: with SMTP id c19-v6mr17274388pfn.224.1531731673524; Mon, 16 Jul 2018 02:01:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531731673; cv=none; d=google.com; s=arc-20160816; b=r81pAtHi554TYkm85UyyjmrzBD35AdIrleDecNzii+tab7ncom7a9AMAJxb5HMmiJ1 4CnBuDlJiY4nGH+M+nUr5vj6qgQ4h6Y0fZQgLyEsRbBu9Qh7ndwDSGlev58BWpIquz7O OyELVopRMCozQnsrcLPe3b0Sr+3BxDSKwXEFzE5oJpKsOaLHdfCAjQB71aeCyGGGFmO8 DtQLDRNhYhnePSsdGkGki2oRdEUtqQ1zNXVqyA4Eo+b4x5TBbnVjGolJr7cM0C0g4fGZ 0ET8wu6ebvLA2aid0lQ9+b5ZvZ07RGaqNqCPtBejeHW2IcS54p3Pdp/HYPGwFNb5wsCn 5uDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=PO1ZaRIvUz6l1aHTWafKPMzYZpN8zt8UXEPWBuikI5A=; b=oNszfSxZej/br3HTFcV+XaFNeXhXvq9GluaVMwqeNdn7BGwkxAutnMqG2HBEeIK0ba 3bhOc1PtQ0FxxIp92HNpodU6cjJfYAUP98SkXZ88EZ2dGM6G3Qt3uiK6PJ4yhuitixVG e0MAaYehGqUGr9Bq9rQ2zWPRt1C3UXn9D8aOvXCDYDVlL4GshC3qtwSdd4FU+IKAKVbN olKP2HJGn7hLEtp9680TbhG6ad8r5C+1gGqg0s5eoCFfK3Ef4gJzsOO+dR7TsgZhYBNQ Wq/JFWFoFSRzSx8Of7BEeEEgXWU8hmehCNdCh5VL4YWwqZop9jQP5O0GmhvmP2E3lXZZ HI6w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 28-v6si29903498pgk.111.2018.07.16.02.00.58; Mon, 16 Jul 2018 02:01:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731358AbeGPJ0H (ORCPT + 99 others); Mon, 16 Jul 2018 05:26:07 -0400 Received: from relmlor3.renesas.com ([210.160.252.173]:45074 "EHLO relmlie2.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727182AbeGPJ0G (ORCPT ); Mon, 16 Jul 2018 05:26:06 -0400 Received: from unknown (HELO relmlir3.idc.renesas.com) ([10.200.68.153]) by relmlie2.idc.renesas.com with ESMTP; 16 Jul 2018 17:59:41 +0900 Received: from relmlii2.idc.renesas.com (relmlii2.idc.renesas.com [10.200.68.66]) by relmlir3.idc.renesas.com (Postfix) with ESMTP id BE60C77E56; Mon, 16 Jul 2018 17:59:41 +0900 (JST) X-IronPort-AV: E=Sophos;i="5.51,360,1526310000"; d="scan'208";a="286981870" Received: from unknown (HELO vbox.ree.adwin.renesas.com) ([10.226.37.67]) by relmlii2.idc.renesas.com with ESMTP; 16 Jul 2018 17:59:39 +0900 From: Phil Edworthy To: Jarkko Nikula Cc: Geert Uytterhoeven , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Phil Edworthy , Andy Shevchenko , Mika Westerberg Subject: [PATCH 2/2] i2c: designware: Add support for a bus clock Date: Mon, 16 Jul 2018 09:59:13 +0100 Message-Id: <1531731553-22979-3-git-send-email-phil.edworthy@renesas.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1531731553-22979-1-git-send-email-phil.edworthy@renesas.com> References: <1531731553-22979-1-git-send-email-phil.edworthy@renesas.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The Synopsys I2C Controller has a bus clock, but typically SoCs hide this away. However, on some SoCs you need to explicity enable the bus clock in order to access the registers. Therefore, enable an optional bus clock specified by DT. Signed-off-by: Phil Edworthy --- drivers/i2c/busses/i2c-designware-common.c | 14 +++++++++++++- drivers/i2c/busses/i2c-designware-core.h | 1 + drivers/i2c/busses/i2c-designware-platdrv.c | 2 ++ 3 files changed, 16 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-designware-common.c b/drivers/i2c/busses/i2c-designware-common.c index 48914df..4fa67d6 100644 --- a/drivers/i2c/busses/i2c-designware-common.c +++ b/drivers/i2c/busses/i2c-designware-common.c @@ -186,13 +186,25 @@ unsigned long i2c_dw_clk_rate(struct dw_i2c_dev *dev) int i2c_dw_prepare_clk(struct dw_i2c_dev *dev, bool prepare) { + int ret; + if (IS_ERR(dev->clk)) return PTR_ERR(dev->clk); - if (prepare) + if (prepare) { + /* Optional bus clock */ + if (!IS_ERR(dev->busclk)) { + ret = clk_prepare_enable(dev->busclk); + if (ret) + return ret; + } + return clk_prepare_enable(dev->clk); + } clk_disable_unprepare(dev->clk); + clk_disable_unprepare(dev->busclk); + return 0; } EXPORT_SYMBOL_GPL(i2c_dw_prepare_clk); diff --git a/drivers/i2c/busses/i2c-designware-core.h b/drivers/i2c/busses/i2c-designware-core.h index d690e64..10f905d 100644 --- a/drivers/i2c/busses/i2c-designware-core.h +++ b/drivers/i2c/busses/i2c-designware-core.h @@ -239,6 +239,7 @@ struct dw_i2c_dev { void __iomem *base; struct completion cmd_complete; struct clk *clk; + struct clk *busclk; struct reset_control *rst; struct i2c_client *slave; u32 (*get_clk_rate_khz) (struct dw_i2c_dev *dev); diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c index 5660daf..64389fe 100644 --- a/drivers/i2c/busses/i2c-designware-platdrv.c +++ b/drivers/i2c/busses/i2c-designware-platdrv.c @@ -332,6 +332,8 @@ static int dw_i2c_plat_probe(struct platform_device *pdev) else i2c_dw_configure_master(dev); + /* Optional bus clock */ + dev->busclk = devm_clk_get(&pdev->dev, "bus"); dev->clk = devm_clk_get(&pdev->dev, NULL); if (!i2c_dw_prepare_clk(dev, true)) { dev->get_clk_rate_khz = i2c_dw_get_clk_rate_khz; -- 2.7.4