Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2105116imm; Mon, 16 Jul 2018 02:12:19 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcQy1LBzHpudBOcHqFZ89ngt17LxBdDNPdpma8/ewg3mWJerg0pyCby0yyTWBqVy/aLvgjq X-Received: by 2002:a63:82c7:: with SMTP id w190-v6mr14765396pgd.253.1531732339876; Mon, 16 Jul 2018 02:12:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531732339; cv=none; d=google.com; s=arc-20160816; b=PUALiz9ptByHqAHAlYXaHeiFE54CkFi5N/XULlKw43ADBPbvaxR7sLj6xnRz6qPITP TTDSMBTh68vfOr9GUi1mCwZFlJSohMfT4LMf9X8zWArF1CDHHlbMHnJkMIqdyPQ+TLkZ Z2gxh9bdTTY6MyBLCu1Sqf1+7QezBQ0ie5DkxU/dTTZMGtApovbC1iKJuFeMCAJ+sGfW /Nlda8C7gcHNWhs9yTSfwUrrPeHh1I8ScFQKndcJ2m0Q6+EwcW2BnUv969mBdkE2sJAA /f0xPZOGtzwXGpHJbJ+9BeKYfo7JsMIT/85I5kdQ1HBlfYe5WKsN5ThdpFswQGJiNUmg Cg4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=4F1ahKb/n4TQ7Ec5YtXL1pz9WCxrO7yV6+CD1RiJGyw=; b=ct8IUrteK8RT50SpDYUV6CHUwyisdl1TSUFQxkYn72r8tYMVzuSNP/q8dOBLkXS9gG CKxeBCNJ+zTSexFt02flMtgiOa874jb/wGaWFz734ptwEI5Iaya/p2V6IxwEe27fVtnX KSaHV0Z7ejKZvg3u65esJ+WdvyOVEu4sAoR/S0tHNoZt6amvvpWgD18c0E28kNnfeUF0 Sh6+N6KQEtCdPtBaT5tmQP/IJzGgr/nL3Hxa4BRCDkYAMmaGptQCvOYsFuAbl0RmXCYF l5mkCSwRVOJG4CG2iwV2ORI3T4T576MUUWIHTss18hSMEea08+BB4i6gXrTWKPPMwvGv xS0A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 25-v6si28279912pfp.108.2018.07.16.02.12.05; Mon, 16 Jul 2018 02:12:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729818AbeGPJhK (ORCPT + 99 others); Mon, 16 Jul 2018 05:37:10 -0400 Received: from mx2.suse.de ([195.135.220.15]:59668 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727182AbeGPJhK (ORCPT ); Mon, 16 Jul 2018 05:37:10 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 4A4C5AE3F; Mon, 16 Jul 2018 09:10:41 +0000 (UTC) Date: Mon, 16 Jul 2018 11:10:40 +0200 From: Michal Hocko To: James Bottomley Cc: Dave Chinner , Linus Torvalds , Matthew Wilcox , Waiman Long , Al Viro , Jonathan Corbet , "Luis R. Rodriguez" , Kees Cook , Linux Kernel Mailing List , linux-fsdevel , linux-mm , "open list:DOCUMENTATION" , Jan Kara , Paul McKenney , Andrew Morton , Ingo Molnar , Miklos Szeredi , Larry Woodman , "Wangkai (Kevin,C)" Subject: Re: [PATCH v6 0/7] fs/dcache: Track & limit # of negative dentries Message-ID: <20180716091040.GH17280@dhcp22.suse.cz> References: <18c5cbfe-403b-bb2b-1d11-19d324ec6234@redhat.com> <1531336913.3260.18.camel@HansenPartnership.com> <4d49a270-23c9-529f-f544-65508b6b53cc@redhat.com> <1531411494.18255.6.camel@HansenPartnership.com> <20180712164932.GA3475@bombadil.infradead.org> <1531416080.18255.8.camel@HansenPartnership.com> <1531425435.18255.17.camel@HansenPartnership.com> <20180713003614.GW2234@dastard> <1531496812.3361.9.camel@HansenPartnership.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1531496812.3361.9.camel@HansenPartnership.com> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 13-07-18 08:46:52, James Bottomley wrote: > On Fri, 2018-07-13 at 10:36 +1000, Dave Chinner wrote: > > On Thu, Jul 12, 2018 at 12:57:15PM -0700, James Bottomley wrote: > > > What surprises me most about this behaviour is the steadiness of > > > the page cache ... I would have thought we'd have shrunk it > > > somewhat given the intense call on the dcache. > > > > Oh, good, the page cache vs superblock shrinker balancing still > > protects the working set of each cache the way it's supposed to > > under heavy single cache pressure. :) > > Well, yes, but my expectation is most of the page cache is clean, so > easily reclaimable. I suppose part of my surprise is that I expected > us to reclaim the clean caches first before we started pushing out the > dirty stuff and reclaiming it. I'm not saying it's a bad thing, just > saying I didn't expect us to make such good decisions under the > parameters of this test. This is indeed unepxected. Especially when the current LRU reclaim balancing logic is highly pagecache biased. Are you sure you were not running in a memcg with a small amount of the pagecache? -- Michal Hocko SUSE Labs