Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 16 Jul 2018 12:02:30 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     RAGHU Halharvi <raghuhack78@gmail.com>
Cc:     devel@driverdev.osuosl.org, driverdev-devel@linuxdriverproject.org,
        linux-kernel@vger.kernel.org, wsa@the-dreams.de
Subject: Re: [PATCH] staging: ks7010_sdio:Fix checkpatch out of memory warning
Message-ID: <20180716100230.GA30655@kroah.com>
References: <20180713160636.8017-1-raghuhack78@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180713160636.8017-1-raghuhack78@gmail.com>
User-Agent: Mutt/1.10.0 (2018-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Jul 13, 2018 at 09:36:36PM +0530, RAGHU Halharvi wrote:
> * Patch fixes checkpatch warning "Possible unnecessary 'out of memory'
> 	message"
> 
> Signed-off-by: RAGHU Halharvi <raghuhack78@gmail.com>
> ---
>  drivers/staging/ks7010/ks7010_sdio.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
> index b8f55a11ee1c..972b01a0257d 100644
> --- a/drivers/staging/ks7010/ks7010_sdio.c
> +++ b/drivers/staging/ks7010/ks7010_sdio.c
> @@ -957,10 +957,8 @@ static int send_stop_request(struct sdio_func *func)
>  	card = sdio_get_drvdata(func);
>  
>  	pp = kzalloc(hif_align_size(sizeof(*pp)), GFP_KERNEL);
> -	if (!pp) {
> -		netdev_err(card->priv->net_dev, "allocate memory failed..\n");
> +	if (!pp)
>  		return -ENOMEM;
> -	}

This change has already been done in my tree, please always work against
linux-next at the least, and ideally staging.git, so that you do not
duplicate work others have already done.

thanks,

greg k-h