Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2164948imm; Mon, 16 Jul 2018 03:28:35 -0700 (PDT) X-Google-Smtp-Source: AAOMgpczGnLkuyzfRiSQVgsQeBetxn6nCYLql8UprY7aQ7FfEsyeY37D6zKQazPmK5a1WyA6mLXZ X-Received: by 2002:a62:9dcc:: with SMTP id a73-v6mr16993271pfk.249.1531736915012; Mon, 16 Jul 2018 03:28:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531736914; cv=none; d=google.com; s=arc-20160816; b=c1545IPyqb9Be/NwzZ+mibe5NNyfwedZyMdUyuLU24yr/1TC13pb3sCjxg30ZLZLsc AJ9FNEqozc9nBhal4UJnJITtDCFDC726EUbSsUg7350Igi2Zo7V9m++qrb+JJxD3c3I4 z2jVexJcHji9ficwThp5E/3N8MzlKTDFujm5dpRSdWDJal/wWLuBFWZMX2aeFDluqSFq /dLLsPQZLuZbKsLKmzSTB0dqxRn05FWiqe6FB2ZKazpcZYRyD+S2fR9Pye30TYtOpBpR h/nnVYGeS/TZxCqvrQmcgMgDAuF9CIfsPFcbFkY9jV+SLS92T6629GziWtHSXBvH/fZy OuFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=tBl9NijlhjjaCEIbn7m/AiasMLs1ZF76VdvjUPlQQ34=; b=tRuopHcCxPgJA7qy2fAbw/jnXvl/ribl65uegM8fW1DgaksM7YKvKkNfgykeIsDrsI JvJfrIwTjM022B0Rdyr81x2MIVwhTirtVuiZzdfOcDEniHNu7k6rSCTMhmKdItTu9c7X 6ZUXdIsZJZLSFsrFME2yhusJKvJxRi36jHG/TopsXq7GGGj4L1HS1XVYBBsHmOGJ+V+i CsOCGxPOokhM2/1mBM1emMJtc8orKS/v7FE+ie9/T3i+5/HvE5wPrAFd5YvLSuQEAH/U LKBV7zenOPZH/y33kHnpUO3WxhsjcYIK0WnS5Mv+gPGJ/ezbMgYJgnUUbGcyOGvBjOpL PSEA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t2-v6si4398964pgs.142.2018.07.16.03.28.20; Mon, 16 Jul 2018 03:28:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728872AbeGPKyX (ORCPT + 99 others); Mon, 16 Jul 2018 06:54:23 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:34630 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727705AbeGPKyX (ORCPT ); Mon, 16 Jul 2018 06:54:23 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 5C8CE89B; Mon, 16 Jul 2018 10:27:37 +0000 (UTC) Date: Mon, 16 Jul 2018 12:27:35 +0200 From: Greg KH To: "Rafael J. Wysocki" Cc: Benjamin Gaignard , broonie@kernel.org, p.paillet@st.com, linux-kernel@vger.kernel.org, m.szyprowski@samsung.com, Benjamin Gaignard Subject: Re: [PATCH v2] base: core: Remove WARN_ON from link dependencies check Message-ID: <20180716102735.GA6269@kroah.com> References: <20180716095952.22202-1-benjamin.gaignard@st.com> <1753469.EDefOSO2YU@aspire.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1753469.EDefOSO2YU@aspire.rjw.lan> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 16, 2018 at 12:07:20PM +0200, Rafael J. Wysocki wrote: > On Monday, July 16, 2018 11:59:52 AM CEST Benjamin Gaignard wrote: > > In some cases the link between between customer and supplier > > already exist, for example when a device use it parent as supplier [1]. > > I think this should be "its parent as a supplier". > > > Do not warn about already existing dependencies because device_link_add() > > take care of this case. > > "device_link_add() takes care of" > > > [1] https://lkml.org/lkml/2018/7/9/356 > > There is the Link: tag for links and it is better to not use lkml.org > as it is not reliable enough. You can use lore.kernel.org/lkml/ instead. Even better, use: lkml.kernel.org/r/[message-id] thanks, greg k-h