Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Rafael J. Wysocki" <rjw@rjwysocki.net>
To:     Greg KH <gregkh@linuxfoundation.org>,
        Benjamin Gaignard <benjamin.gaignard@linaro.org>
Cc:     broonie@kernel.org, p.paillet@st.com, linux-kernel@vger.kernel.org,
        m.szyprowski@samsung.com,
        Benjamin Gaignard <benjamin.gaignard@st.com>
Subject: Re: [PATCH v2] base: core: Remove WARN_ON from link dependencies check
Date:   Mon, 16 Jul 2018 12:40:08 +0200
Message-ID: <2548044.UDzUby0S5K@aspire.rjw.lan>
In-Reply-To: <20180716102735.GA6269@kroah.com>
References: <20180716095952.22202-1-benjamin.gaignard@st.com> <1753469.EDefOSO2YU@aspire.rjw.lan> <20180716102735.GA6269@kroah.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Monday, July 16, 2018 12:27:35 PM CEST Greg KH wrote:
> On Mon, Jul 16, 2018 at 12:07:20PM +0200, Rafael J. Wysocki wrote:
> > On Monday, July 16, 2018 11:59:52 AM CEST Benjamin Gaignard wrote:
> > > In some cases the link between between customer and supplier
> > > already exist, for example when a device use it parent as supplier [1].
> > 
> > I think this should be "its parent as a supplier".
> > 
> > > Do not warn about already existing dependencies because device_link_add()
> > > take care of this case.
> > 
> > "device_link_add() takes care of"
> > 
> > > [1] https://lkml.org/lkml/2018/7/9/356
> > 
> > There is the Link: tag for links and it is better to not use lkml.org
> > as it is not reliable enough.  You can use lore.kernel.org/lkml/ instead.
> 
> Even better, use:
> 	lkml.kernel.org/r/[message-id]

Where [message-id] is the value of the Message-Id: header (without the
enclosing <>) of the target e-mail message (that you can find by looking
at the raw message).

Thanks,
Rafael