Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 16 Jul 2018 12:34:58 +0100
From:   John Whitmore <arigead@gmail.com>
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     John Whitmore <johnfwhitmore@gmail.com>,
        linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
        tglx@linutronix.de, kstewart@linuxfoundation.org,
        pombredanne@nexb.com
Subject: Re: staging:rtl8192u: [0/10] Coding style changes.
Message-ID: <20180716113457.GB22731@xux707-tw>
References: <20180713201247.21428-1-johnfwhitmore@gmail.com>
 <20180716084020.GA8260@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180716084020.GA8260@kroah.com>
User-Agent: Mutt/1.10.0 (2018-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jul 16, 2018 at 10:40:20AM +0200, Greg KH wrote:
> On Fri, Jul 13, 2018 at 09:12:37PM +0100, John Whitmore wrote:
> > All coding style changes, but the second [2/10] is a bit more hairy then
> > most. The original code combined two typedef declarations into one with both
> > the structure and a pointer to the structure defined. I've totally removed the
> > pointer to the structure type since it uses Hungarian notation, which the
> > coding standard isn't keen on.
> > 
> > As a result of this there are changes in code from the type:
> > PStructType  *ppname;
> > to:
> > struct StructType **ppname;
> > 
> > To keep the diff simple I've kept the current nameing of "ppname", which again
> > is Hungarian notation. I'll leave that for a future patch.
> 
> Nit, your subject should look like:
> 
> Subject: [PATCH 00/10] staging:rtl8192u: Coding style changes.
> 
> What are you using to generate this email?  git format-patch
> --cover-letter should generate it with a correct subject line prefix,
> right?
> 

Oops! I was using "git send-email --compose" didn't realise that option was
included in format-patch. I'll use that format-patch option in future.

John