Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 16 Jul 2018 14:01:34 +0200
From:   Johan Hovold <johan@kernel.org>
To:     Niklas Cassel <niklas.cassel@linaro.org>
Cc:     broonie@kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] regulator: qcom_spmi: Fix warning Bad of_node_put()
Message-ID: <20180716120134.GL10204@localhost>
References: <20180716113525.9335-1-niklas.cassel@linaro.org>
 <20180716113525.9335-2-niklas.cassel@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180716113525.9335-2-niklas.cassel@linaro.org>
User-Agent: Mutt/1.10.0 (2018-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Niklas,

On Mon, Jul 16, 2018 at 01:35:22PM +0200, Niklas Cassel wrote:
> For of_find_node_by_name(), you typically pass what the previous call
> returned. Therefore, of_find_node_by_name() increases the refcount of
> the returned node, and decreases the refcount of the node passed as the
> first argument.
> 
> However, in this case we don't pass what the previous call returned,
> so we have to increase the refcount of the first argument to compensate.

I don't think this is the right fix. of_find_node_by_name() should
generally not be used by drivers in the first place as it searches the
entire tree and can end up matching an entirely unrelated node.

I haven't looked at the device-tree binding in question, but you
probably want to use something like of_get_child_by_name() instead.

Johan