Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2276058imm; Mon, 16 Jul 2018 05:27:31 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdbV76YgjOrXLcND1lxq2b6cCl1p75lQlJvFLkutulHQupQR+53SYSP+WJqnFlXcduHji/Z X-Received: by 2002:a17:902:8215:: with SMTP id x21-v6mr12125982pln.175.1531744051621; Mon, 16 Jul 2018 05:27:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531744051; cv=none; d=google.com; s=arc-20160816; b=M8e5S1R8QhdI1ENJx+r72BJlHUAJZDcU7ge2f4xsjzI2o7MKlA9o77hBQCGIGzCgGu VxFoSNzcTzF3sdQjdgVp7+vfpnWi+T94pDEzQ3nUjurnhTjT5T4pv+THLpHe25heIr0h lHoVjSA7dcAzXBmKi3L31F4K83QG8ND5CGMZb7rgauWlqU0ljdGtCAEIkfV5Zmb3w2xB Yqrz84cQR3c66Ydo+iqHxlHQcnt6NaUS0sP66dLxwChKcasLD4poCxwCQM04rTKOt84p E/eMwrasdWs6CEeexi/+JsU9EA4lqZu+mJGeTyWuhlKVCZpQQ7JPbbmtxyHfcnQ9SIPR pEzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=QtYKwg940AaMah1Vp+UwNF8s1NrtW7Yrk8pQ94OVR2o=; b=vTZDBl4HnpDoy25mfSS5T/p/qMcFQVtQO1c1lC+yWhnCweChxSO9oqTP6vcpiUKtLA samSqVlsTXJ7d2XR7eef9t4i7Ko3k84HtArCUUzAszDLqDb7CkRoRCytSAcDIjSAYsDw cY5mhbnqgHj572YQBpJDyWhhr5nTJbcuLcN0b4Hr3DrRFzDV+1k6h39r486RWVeiEuGp nglyKuk1Bsb4XU9hE0QXL63fErd57AaxNvJuUK54XFY96eOpVxmOgWIjXagsDjhbaj4n baRz4aqHZOZFkZ8bvYQAqxxUmNuzBItvuCADLMgSkwzWeXg/xknyLTa9ucDd2apeV4Hb +LBQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q68-v6si33428031pfl.317.2018.07.16.05.27.16; Mon, 16 Jul 2018 05:27:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730742AbeGPMxt (ORCPT + 99 others); Mon, 16 Jul 2018 08:53:49 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:59152 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728872AbeGPMxt (ORCPT ); Mon, 16 Jul 2018 08:53:49 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EFB8581A4EA2; Mon, 16 Jul 2018 12:26:35 +0000 (UTC) Received: from dhcp-128-65.nay.redhat.com (ovpn-12-124.pek2.redhat.com [10.72.12.124]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0F6112026D65; Mon, 16 Jul 2018 12:26:27 +0000 (UTC) Date: Mon, 16 Jul 2018 20:26:23 +0800 From: Dave Young To: AKASHI Takahiro Cc: catalin.marinas@arm.com, will.deacon@arm.com, dhowells@redhat.com, vgoyal@redhat.com, herbert@gondor.apana.org.au, davem@davemloft.net, bhe@redhat.com, arnd@arndb.de, ard.biesheuvel@linaro.org, james.morse@arm.com, bhsharma@redhat.com, kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, "Eric W. Biederman" Subject: Re: [PATCH v11 03/15] powerpc, kexec_file: factor out memblock-based arch_kexec_walk_mem() Message-ID: <20180716122623.GB7160@dhcp-128-65.nay.redhat.com> References: <20180711074203.3019-1-takahiro.akashi@linaro.org> <20180711074203.3019-4-takahiro.akashi@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180711074203.3019-4-takahiro.akashi@linaro.org> User-Agent: Mutt/1.9.5 (2018-04-13) X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Mon, 16 Jul 2018 12:26:36 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Mon, 16 Jul 2018 12:26:36 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'dyoung@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Akashi, On 07/11/18 at 04:41pm, AKASHI Takahiro wrote: > Memblock list is another source for usable system memory layout. > So powerpc's arch_kexec_walk_mem() is moved to kexec_file.c so that > other memblock-based architectures, particularly arm64, can also utilise > it. A moved function is now renamed to kexec_walk_memblock() and merged > into the existing arch_kexec_walk_mem() for general use, either resource > list or memblock list. > > A consequent function will not work for kdump with memblock list, but > this will be fixed in the next patch. If this breaks something, then it would be good to fold the following patch in this patch so that bisect can still work? Thanks Dave