Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2309976imm; Mon, 16 Jul 2018 06:02:19 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcrXD+SGcOUH/SbUhDrlrcInXBh4w4D/m2LnKvh1dtmuIwY/ZVDsAqN3MG6j07hz58HBB6Q X-Received: by 2002:a62:6104:: with SMTP id v4-v6mr3100671pfb.122.1531746139521; Mon, 16 Jul 2018 06:02:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531746139; cv=none; d=google.com; s=arc-20160816; b=EkR0dyH1M6LXJexK4qj1bx4z/IBCDG7MHPni/2A8AmNrnA6ok1wNJaMsIFOww8QG3i GoLWDHZk3BiIvlTYXmO+x3rCVE3Q07RRROvehRDGwszofbya5aDoFE9SgGzRQZzopx4m VD+W4lTbogSjbk1XI06DBA1XIOr423lYj0v4uvSI5fHuwCIgX+3QKmpZLrckeXMC523i EM/0NoLyv2jtGdLmdQhCknIyiWZLDPSf7zN17bTZhlpw/wMaJYJhPMSNGFNZ0kBm3FRY oP/zQptBcYw3xMt7S9gaUbAp22HG8dCGdbcEG/bGYK8o0JqvyARurpXTfnidozQuMkh5 Vmpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=GomDL5C2OIVulv6LBVyiEAkPrCsAk/DE2CgCJkrvw7c=; b=UgIzoHDmtwNeodevTmGzSWPnMPjVs7X0+0oQLOBXeNtACW7POrA9nOk9PhwCNc7oVJ d4im4pgJ77N8dfUDdkRME+ARYVVp6tnFNz4bfcQNUJeQohYTfShPry5h/JTw5GdV6veX JhtHFBdowvEU8Tuj69+m8KLSEvcPIt6SJ9BlbqMfyA6mi6Tj/yaMZ90NkmoZIf5/XNZD QMmSDfvIgOa7w4Ydi8AdTmx+Q3ImNzrPaGQntG97jdeGNJPqMeJAh6G0BGMLZ/AmqRXt fytLvluTIa+d+arTqBGdEjFHToBF04uIr+bHjIXoRkX2EuzxqLo3XBxzPaU8++Sa2rOw gt8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=jMqDC9fs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c14-v6si33578823pfl.319.2018.07.16.06.02.04; Mon, 16 Jul 2018 06:02:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=jMqDC9fs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731170AbeGPN2B (ORCPT + 99 others); Mon, 16 Jul 2018 09:28:01 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:46422 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729854AbeGPN2A (ORCPT ); Mon, 16 Jul 2018 09:28:00 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w6GCxP5A170269; Mon, 16 Jul 2018 13:00:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : mime-version : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=GomDL5C2OIVulv6LBVyiEAkPrCsAk/DE2CgCJkrvw7c=; b=jMqDC9fscuYWdVpSjTYjvpgI4994MUpDGMjEJ1cgctaVJuFA0U6zl/yfJfDoL1v5Og7O ouwAQE8GiDtUVsNpl+mrTYBU1/2PbzZFqAWtKjlj3lRqiIosOz8KmobY+G6jmDhk0zJI sCzlubaWi+gXyCErGVBtfhU5n07zxPJOHIv+e52WPpVwRhGOvVByZr47FtUT+ZYijYzC D2O96uT4Xyuh0s+WEhn3LJIf8YR067kyyV5G889nh/LhHr7CTmRWab+m29aErEZpLBA5 jK8KLtARDMUJLznU5VPc4kQcF+bn9griALqHM/iV856rCSIDuIZBljgKjsdPbN0U3CRf Lw== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp2120.oracle.com with ESMTP id 2k7a33v9hm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 16 Jul 2018 13:00:36 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w6GD0Zv0031017 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 16 Jul 2018 13:00:36 GMT Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w6GD0YSD013881; Mon, 16 Jul 2018 13:00:34 GMT Received: from lab02.no.oracle.com (/10.172.144.56) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 16 Jul 2018 06:00:34 -0700 From: =?UTF-8?q?H=C3=A5kon=20Bugge?= To: Santosh Shilimkar , "David S . Miller" Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org Subject: [PATCH] net/rds: void function cannot return -1 Date: Mon, 16 Jul 2018 15:00:09 +0200 Message-Id: <20180716130009.1591379-1-Haakon.Bugge@oracle.com> X-Mailer: git-send-email 2.14.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8955 signatures=668706 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=745 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1806210000 definitions=main-1807160152 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit b6fb0df12db6 ("RDS/IB: Make ib_recv_refill return void") did not change the comment accordingly. Fixes: b6fb0df12db6 ("RDS/IB: Make ib_recv_refill return void") Signed-off-by: HÃ¥kon Bugge --- net/rds/ib_recv.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/rds/ib_recv.c b/net/rds/ib_recv.c index b4e421aa9727..e5ce93419263 100644 --- a/net/rds/ib_recv.c +++ b/net/rds/ib_recv.c @@ -376,8 +376,6 @@ static void release_refill(struct rds_connection *conn) * This tries to allocate and post unused work requests after making sure that * they have all the allocations they need to queue received fragments into * sockets. - * - * -1 is returned if posting fails due to temporary resource exhaustion. */ void rds_ib_recv_refill(struct rds_connection *conn, int prefill, gfp_t gfp) { -- 2.14.3