Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2326214imm; Mon, 16 Jul 2018 06:15:44 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfDv/b6l8wDCytRKpAiW5A0KssX1jFinEhrVLl6A6VZE3Gc4hhnJSf4UTgroXgUm+BiDQpp X-Received: by 2002:a63:f002:: with SMTP id k2-v6mr15252619pgh.8.1531746944470; Mon, 16 Jul 2018 06:15:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531746944; cv=none; d=google.com; s=arc-20160816; b=gQcITSTy4sf14B4P1rcc2oFDShl5kol39UyWAVKYxENndaar5ZOg6QKpCuUoPVSuws t0Vk4E7LPtV6NAuYeKP9mbnST7V+qQFzBMrSuDdXs2oKmFZfwYTy/Rgj8ER/jToD1Vgf CeqNa6xzWNtFPFQKxJxLMPs6wQaw8GWWOMfDpuJx58PQ3ZU+eRRDn07a5TNbH6YbXgyG eHWTfgoAQhnn0xSsf+gUEqJSAQGmCKlvPNbeVvTIQlwhz3FbmSmJy9jiVqvLfr1GKOJD 2XX28/pdH+eU5uDJ8s3avSzuFIwPwrB8BWRAqITEiXZG5IT918b8sJjc7C0sFckPX6i1 qFDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:arc-authentication-results; bh=0lkz2DGMKrYPAX3a7gS6tYe3Ix7qsuCep1dwlA10dN0=; b=Mmb0PRFGb80/hWrfz4Q4TEi/0jBQTNspZ07kgky3+/qLzmYtzPYzIGlVCBcOgsgU/J RVWG7UmKwzMvMLAgURVntIpfkLsXcSYxcU1wqg1C+kD7W7HwWYB8zTm4UvArUB/lUdBW rK1LeOMTsC5NvcIm+853wOhRle1qUB8qi/7xeoSboTlTWxsrVC16CRGSAooKccX0eOjR hBlCYlFZWGw1RJHmYqH92z3bvIv9lPWcfluG0a6xpw4P15qLR/YA0cy8opg0ZKoFMPhz BxpoaT4iSVugov3k6/bjYXglop20wDTlnEXzyZCLB5CujxZ9avbK0XUsjhEUySdIhliD Ue3Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 4-v6si29171811pgn.90.2018.07.16.06.15.29; Mon, 16 Jul 2018 06:15:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729871AbeGPNmT (ORCPT + 99 others); Mon, 16 Jul 2018 09:42:19 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:60908 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728359AbeGPNmT (ORCPT ); Mon, 16 Jul 2018 09:42:19 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3B61381A4EBC; Mon, 16 Jul 2018 13:14:55 +0000 (UTC) Received: from epycfail (ovpn-200-23.brq.redhat.com [10.40.200.23]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2FA79111DD03; Mon, 16 Jul 2018 13:14:51 +0000 (UTC) Date: Mon, 16 Jul 2018 15:14:46 +0200 From: Stefano Brivio To: Ursula Braun Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-s390@vger.kernel.org, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, raspl@linux.ibm.com, linux-kernel@vger.kernel.org, eric.dumazet@gmail.com, lifeasageek@gmail.com Subject: Re: [PATCH net V2 1/1] net/smc: take sock lock in smc_ioctl() Message-ID: <20180716151446.088ffc3b@epycfail> In-Reply-To: <20180716115652.72331-1-ubraun@linux.ibm.com> References: <20180716115652.72331-1-ubraun@linux.ibm.com> Organization: Red Hat MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Mon, 16 Jul 2018 13:14:55 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Mon, 16 Jul 2018 13:14:55 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'sbrivio@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 16 Jul 2018 13:56:52 +0200 Ursula Braun wrote: > From: Ursula Braun > > SMC ioctl processing requires the sock lock to work properly in > all thinkable scenarios. > Problem has been found with RaceFuzzer and fixes: > KASAN: null-ptr-deref Read in smc_ioctl > > Reported-by: Byoungyoung Lee > Reported-by: syzbot+35b2c5aa76fd398b9fd4@syzkaller.appspotmail.com > Signed-off-by: Ursula Braun Reviewed-by: Stefano Brivio -- Stefano