Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2340362imm; Mon, 16 Jul 2018 06:30:02 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfYYWyN9D/z5h1YAVTwLGHwGySD8lvsKWMnvmP9r7aAo18dTpaX3q2uXtuAn+0KpE6hox1D X-Received: by 2002:a65:420d:: with SMTP id c13-v6mr15488955pgq.265.1531747802355; Mon, 16 Jul 2018 06:30:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531747802; cv=none; d=google.com; s=arc-20160816; b=LKaen3SUbcDcmyZnvq3yoVVkSxmIQ7GQ74K9uA7ebfPtRqT5rA2tZu7hyWNLfDOSaX wWMRUPez2Pw8woYW+bPn9qWKbJ4gw8dW6zwiARQpcr2KBjI6/UKJzCDj5opDNThPg4ig mcK8ChYy7frcYjLpH5eZS5UEwClfRzCJOdeEVA4okK5GkrTDgUfyxV1jsMzXSCgGvsSo tgqfLDM7x5uCvYPmhGKJpsqkMktE4qPplppU0UHGwvlLJaoHOp+GspI7lDyOIgOgr2kC 7DSBjFcwzwM8qzj+uwBlGyCCpUQemuSAadGrUcLYA0Ihpwc2JXeE3BbCclDhOt23bgOJ ELfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from :arc-authentication-results; bh=3EntiegtA0KufQ9eOQ4ZugMfYe1otlw00h8XN98RuRg=; b=fN/bAPoV+8+ZgB5eyFBTvAATRFXrB3gGqft+mr4oa0KzX6wH9vcvT9yZ+ylV+yJ0dO 8EooMZzNYDGtkffWFTFxM06rylR6lcw35x5Ev+GyP/2y4PIfMjhURCotfgekryVjj6Jx 8yHDl3pyJzjFMPRsDN/vTI2zmoDfTnOAacwm6rz91tUu2hE5ib69OUOy0MexRpdzmV08 07c/FRSlc/+jrSFGRReiCYxlBfC3NhXBjYt8sAGN6+iaYQ+QOuhurj1cFYZUzRZeAGdN Op23+GTSj+KUO5jpAkXnjbRVpPd+x3BDX+sHzGSiM6WfnLWFqT4UEaFJRJCj4NSfbqZh EoMw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y128-v6si30539943pfb.299.2018.07.16.06.29.47; Mon, 16 Jul 2018 06:30:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727403AbeGPNzx (ORCPT + 99 others); Mon, 16 Jul 2018 09:55:53 -0400 Received: from foss.arm.com ([217.140.101.70]:59848 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727101AbeGPNzx (ORCPT ); Mon, 16 Jul 2018 09:55:53 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8A81718A; Mon, 16 Jul 2018 06:28:26 -0700 (PDT) Received: from localhost (e105922-lin.cambridge.arm.com [10.1.206.33]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2F1693F5A0; Mon, 16 Jul 2018 06:28:26 -0700 (PDT) From: Punit Agrawal To: Suzuki K Poulose Cc: kvmarm@lists.cs.columbia.edu, marc.zyngier@arm.com, will.deacon@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 1/8] KVM: arm/arm64: Share common code in user_mem_abort() References: <20180716110857.19310-1-punit.agrawal@arm.com> <20180716110857.19310-2-punit.agrawal@arm.com> Date: Mon, 16 Jul 2018 14:28:24 +0100 In-Reply-To: (Suzuki K. Poulose's message of "Mon, 16 Jul 2018 13:45:05 +0100") Message-ID: <87r2k3mhs7.fsf@e105922-lin.cambridge.arm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Suzuki, Suzuki K Poulose writes: > On 16/07/18 12:08, Punit Agrawal wrote: >> The code for operations such as marking the pfn as dirty, and >> dcache/icache maintenance during stage 2 fault handling is duplicated >> between normal pages and PMD hugepages. >> >> Instead of creating another copy of the operations when we introduce >> PUD hugepages, let's share them across the different pagesizes. >> >> Signed-off-by: Punit Agrawal >> Cc: Christoffer Dall >> Cc: Marc Zyngier > > Thanks for splitting the patch. It looks much simpler this way. > > Reviewed-by: Suzuki K Poulose Thanks for reviewing the patches. Punit > _______________________________________________ > kvmarm mailing list > kvmarm@lists.cs.columbia.edu > https://lists.cs.columbia.edu/mailman/listinfo/kvmarm