Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2344895imm; Mon, 16 Jul 2018 06:34:00 -0700 (PDT) X-Google-Smtp-Source: AAOMgpc0WlAE2vV6eXSyRqp20wwiwPNgBnL7YRyXQDvf00koLGKPEnjecxZu5/tl7R5nmXJ01W6X X-Received: by 2002:a63:8c0b:: with SMTP id m11-v6mr15656495pgd.372.1531748040539; Mon, 16 Jul 2018 06:34:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531748040; cv=none; d=google.com; s=arc-20160816; b=v6FQDnyUzfZY5D3CO3ALo3e0QM/HTru2GXmRQNQDAWA0lkmmBui2U7p8y77iQkdhwS MQcgKz1UU7D5ebU2xUkjQ08c8SPQxieTeZ6AZliTDh4dVgEbFQOyvOyjYus4Egjq7Hvv mgcxHX8khXdNnbA5T37zwk54qTec0YcRohcAKIkp3prenZUF0wrbmjdHmRcDuhHT/4FP /QuDdQB/9pUtOuFzV6dSfVkPVMKoilDQTx9EZWO8UnkytgHCE6Vwobwj+nXooJB0NGu8 wdFqmV64caZcji96DNZJGN/ah11Mro7Cm7Hw8tVRCo+J70WpUJ2t2os85bUXERiqAyjL vmNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=dwR2q+9R0Xn4F9WJrQYTuFQ7eo4wf2FGRuz3XTsXO5E=; b=YBIIH3HXFg7Yb6fktIojdsxK2bGBWRHfR3KHCon3Cvbl29Y092DnDDD8MWlYlCUieq D7LQjTvRQ5pV6JU3yGZLz3p/UzhAr06PQA5nhGXEmxK4UbVscLNK+y+dkZCZUCq42HwL DOU9g5pWYwCqk4DGljFvTkPCxCBYtPCfk2Jy+YoPndhKoSNzU6h+2QOUkfARhMZmZtgW PtC6yDYw5qtDUpr7IgHoDlfr9aNtrBeX6ew9y6sgO9YnK98isyhsCESm5IcX9BUq1BTs /onSwkh0O4FAnnTWs/i5umLZb+qtrIw7PQD/woq8YynVjBePZO+itNrmeL+jOs+VSpra iLqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VM4ZEEep; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t17-v6si27814626pgv.615.2018.07.16.06.33.45; Mon, 16 Jul 2018 06:34:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VM4ZEEep; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728556AbeGPOAl (ORCPT + 99 others); Mon, 16 Jul 2018 10:00:41 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:38219 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727250AbeGPOAk (ORCPT ); Mon, 16 Jul 2018 10:00:40 -0400 Received: by mail-lj1-f196.google.com with SMTP id p6-v6so29998888ljc.5 for ; Mon, 16 Jul 2018 06:33:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=dwR2q+9R0Xn4F9WJrQYTuFQ7eo4wf2FGRuz3XTsXO5E=; b=VM4ZEEepBQdpvDkIYJyrX+AcUPwTplq3DYEGWYBEysIBrbVAFY1rEFiLgPK/L3f2+u ahPKw6l/5cLtn7Cp7z1gMybsjgifdaOm6lP117X4rFyvGjqjJEK6kAL0pBCvcJp7ICpk 9Y3lQw6uaMAAZWTXTMqNhPpqSU7K30hmSxQvE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=dwR2q+9R0Xn4F9WJrQYTuFQ7eo4wf2FGRuz3XTsXO5E=; b=uGfqsoOrWH5OfNKKgwHu28vIpyRUvpuybEP/x+lpwJ0dA7QHpQR0ng9TEEaJWqH7Xh 0TdEPi0Nhkzkaezy+fbbz3Li2m6uptLt/hT7H/QAN7aKjONvaWe3H8KTXDNZGk/mu0CR OkeX7pBA6yhLC6ZLwtaIBVq40z1bJ9o9YZc+2s239Sy1BlvKRfbrIhVjTvbmr6ayJ4Nh tLMfIZEePfFROtrhDOdZta1484coue7P4fDoThBpSLFpUkZ9sYmCpy8nqaXO8nkh0VRQ j1tbvSqA+6unvpNbKTNWa7sHkMzbLhebmCCTcCuP+V+N8lNR1rGiP3a/jE5Zc8ChZrWS z9iQ== X-Gm-Message-State: AOUpUlEe9NMHwO+mL/tDmnxcvEbBIgosBDYsw0tZg0HiykS8vpdgghNZ eZKfWQdDLBPYmKQu76BHm3R9sw== X-Received: by 2002:a2e:869a:: with SMTP id l26-v6mr5770782lji.48.1531747990542; Mon, 16 Jul 2018 06:33:10 -0700 (PDT) Received: from centauri.lan (h-229-118.A785.priv.bahnhof.se. [5.150.229.118]) by smtp.gmail.com with ESMTPSA id a14-v6sm3820390ljb.49.2018.07.16.06.33.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 16 Jul 2018 06:33:10 -0700 (PDT) From: Niklas Cassel To: broonie@kernel.org, Liam Girdwood Cc: linux-arm-msm@vger.kernel.org, johan@kernel.org, Niklas Cassel , linux-kernel@vger.kernel.org Subject: [PATCH v2 2/4] regulator: qcom_spmi: Use correct regmap when checking for error Date: Mon, 16 Jul 2018 15:32:52 +0200 Message-Id: <20180716133255.1506-3-niklas.cassel@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180716133255.1506-1-niklas.cassel@linaro.org> References: <20180716133255.1506-1-niklas.cassel@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since we have just assigned saw_regmap, and since the error message refers to saw_regmap, it feels safe to assume that it is saw_regmap, and not regmap, that should be checked for errors. Fixes: 0caecaa87202 ("regulator: qcom_spmi: Add support for SAW") Signed-off-by: Niklas Cassel --- drivers/regulator/qcom_spmi-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/qcom_spmi-regulator.c b/drivers/regulator/qcom_spmi-regulator.c index 4cc14c65d86b..ba3d5e63ada6 100644 --- a/drivers/regulator/qcom_spmi-regulator.c +++ b/drivers/regulator/qcom_spmi-regulator.c @@ -1775,7 +1775,7 @@ static int qcom_spmi_regulator_probe(struct platform_device *pdev) syscon = of_parse_phandle(node, "qcom,saw-reg", 0); saw_regmap = syscon_node_to_regmap(syscon); of_node_put(syscon); - if (IS_ERR(regmap)) + if (IS_ERR(saw_regmap)) dev_err(dev, "ERROR reading SAW regmap\n"); } -- 2.17.1