Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2364223imm; Mon, 16 Jul 2018 06:54:43 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcyhInszmQsJfuEowqC7T5dn2QkzDwsF7G1EZ2pJ2767+TiJ/GGsk+MDIg2xjTdgdsjKlcv X-Received: by 2002:a17:902:7b97:: with SMTP id w23-v6mr13767739pll.66.1531749283532; Mon, 16 Jul 2018 06:54:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531749283; cv=none; d=google.com; s=arc-20160816; b=nwt4jI0gvEKouXEsyatyy1oAGK7lhOmoQ33x5f76x8LvWADTfPtKCYy4QGLptw4BiJ +AqmEjBL0Lv/yXveOqTuboxde4pqufWIWSM3pEVUfW7ipu1Rdf/Pup6h2hbBqQ3TPwa5 SmZVvh5W/YZvFGuR0a+zKuODns33h7GCyrLvSYiZlXL6Za4tMsQUUYZVWin3BGrGO+/O KaASQamk3iPBHf3BmFVFLGYLFmQVedpQrB4TgJJ8Jaz9jTNJuTlEttm0AKbiEwB1NHMx am5Gg7D3Hbu4PIOnZrhfKdeBob5upzb9XmzX/gJpT2x/IOslgfl8yoyBEVHUgd1+bhDx NKAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :mime-version:references:in-reply-to:date:cc:to:from:subject :arc-authentication-results; bh=kpv4hBJ3OttKpui0h9qQYl47IUtobGmS2JoAJv1cw1Y=; b=ry9DmSHfuG5Qeo64Ivgb/mowNNZUs6EluJPeGlTzHEhTuFxqkwuY6hlJTMhiJUdCEO F9asQEAIV0LHAL3l5dh7KgIXResk9G6u4ejh15s9ee6vCapk88QplnGfe19hRN6lUKEK KMmH0mM/yTIL9UaYrR1Omj6crSPpmuoZ7uwNtqUtDpR42hqzRFExgt7af9LeIkMOrvaL wpBc/dyM9btRnPsppeW7mygtiNP202jDzabtM4wzWflUGg18sRQrDodhLMIKulHhR63G E2wMfK40TiZB/kfd7KDJ/tVTbmsDE7Mu9sotAAE0wSeYalSrhw7ijUF1puCfpkWvS+2z eaPg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u10-v6si2122501plu.506.2018.07.16.06.54.28; Mon, 16 Jul 2018 06:54:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730092AbeGPOUX (ORCPT + 99 others); Mon, 16 Jul 2018 10:20:23 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:60068 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727405AbeGPOUX (ORCPT ); Mon, 16 Jul 2018 10:20:23 -0400 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w6GDn3hZ114148 for ; Mon, 16 Jul 2018 09:52:50 -0400 Received: from e06smtp02.uk.ibm.com (e06smtp02.uk.ibm.com [195.75.94.98]) by mx0a-001b2d01.pphosted.com with ESMTP id 2k8rq5tasb-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 16 Jul 2018 09:52:49 -0400 Received: from localhost by e06smtp02.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 16 Jul 2018 14:52:46 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp02.uk.ibm.com (192.168.101.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Mon, 16 Jul 2018 14:52:42 +0100 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w6GDqfKw41484446 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 16 Jul 2018 13:52:41 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B712E4C050; Mon, 16 Jul 2018 16:53:00 +0100 (BST) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E1DA84C046; Mon, 16 Jul 2018 16:52:58 +0100 (BST) Received: from localhost.localdomain (unknown [9.80.99.65]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 16 Jul 2018 16:52:58 +0100 (BST) Subject: Re: [PATCH v6 7/8] module: replace the existing LSM hook in init_module From: Mimi Zohar To: Kees Cook , Mimi Zohar Cc: linux-integrity , linux-security-module , LKML , "Luis R . Rodriguez" , Eric Biederman , Kexec Mailing List , Andres Rodriguez , Greg Kroah-Hartman , Jeff Vander Stoep , Casey Schaufler Date: Mon, 16 Jul 2018 09:52:28 -0400 In-Reply-To: References: <1531505163-20227-1-git-send-email-zohar@linux.vnet.ibm.com> <1531505163-20227-8-git-send-email-zohar@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 18071613-0008-0000-0000-00000253A660 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18071613-0009-0000-0000-000021B9F171 Message-Id: <1531749148.3380.2.camel@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-07-16_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1806210000 definitions=main-1807160162 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2018-07-14 at 19:30 -0700, Kees Cook wrote: > On Fri, Jul 13, 2018 at 11:06 AM, Mimi Zohar wrote: > > Both the init_module and finit_module syscalls call either directly > > or indirectly the security_kernel_read_file LSM hook. This patch > > replaces the direct call in init_module with a call to the new > > security_kernel_load_data hook and makes the corresponding changes > > in SELinux, LoadPin, and IMA. > > > > Signed-off-by: Mimi Zohar > > Cc: Jeff Vander Stoep > > Cc: Casey Schaufler > > Cc: Kees Cook > > Acked-by: Jessica Yu > > Acked-by: Paul Moore > > Acked-by: Kees Cook > > Thanks! Thank you for reviewing/ack'ing all the patches, not just this one. Mimi