Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 16 Jul 2018 16:53:36 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Todd Poynor <toddpoynor@gmail.com>
Cc:     Rob Springer <rspringer@google.com>,
        John Joseph <jnjoseph@google.com>,
        Ben Chan <benchan@chromium.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        devel@driverdev.osuosl.org, Zhongze Hu <frankhu@chromium.org>,
        linux-kernel@vger.kernel.org, Simon Que <sque@chromium.org>,
        Guenter Roeck <groeck@chromium.org>,
        Todd Poynor <toddpoynor@google.com>,
        Dmitry Torokhov <dtor@chromium.org>
Subject: Re: [PATCH 04/18] staging: gasket: device registration error and
 unregister fixups
Message-ID: <20180716135335.hnvj5kqvsrrwzp3b@mwanda>
References: <20180714055816.223754-1-toddpoynor@gmail.com>
 <20180714055816.223754-5-toddpoynor@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180714055816.223754-5-toddpoynor@gmail.com>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Jul 13, 2018 at 10:58:02PM -0700, Todd Poynor wrote:
> @@ -376,7 +377,10 @@ int gasket_register_device(const struct gasket_driver_desc *driver_desc)
>  fail1:
>  	class_destroy(internal->class);
>  
> +fail0:

GW-BASIC sytle label names are an anti-pattern.  It's better to name the
labels after what they do, just like function names describes what the
function does.  Here it would be "goto clear_desc;" or something.  It
doesn't have to be perfect but so long as you *try* to name it something
useful that's better than not trying.

> +	mutex_lock(&g_mutex);
>  	g_descs[desc_idx].driver_desc = NULL;
> +	mutex_unlock(&g_mutex);
>  	return ret;
>  }

regards,
dan carpenter