Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 1/4] lib/crc64: add crc64 option to lib/Kconfig
To:     Coly Li <colyli@suse.de>, linux-kernel@vger.kernel.org
Cc:     linux-bcache@vger.kernel.org, linux-block@vger.kernel.org,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Luis R . Rodriguez" <mcgrof@suse.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Kate Stewart <kstewart@linuxfoundation.org>
References: <20180716165507.23100-1-colyli@suse.de>
 <20180716165507.23100-2-colyli@suse.de>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <9a57ba5a-ec33-b275-43f8-1fa103966d1d@infradead.org>
Date:   Mon, 16 Jul 2018 10:48:46 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20180716165507.23100-2-colyli@suse.de>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 07/16/2018 09:55 AM, Coly Li wrote:
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> This patch adds crc64 option entry in lib/Kconfig. This patch is part of
> a patch originally written by Andy Shevchenko, Coly Li cherry-picks it
> and compose the commit log for a re-written crc64 source code.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Coly Li <colyli@suse.de>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Luis R. Rodriguez <mcgrof@suse.com>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Kate Stewart <kstewart@linuxfoundation.org>
> ---
>  lib/Kconfig | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/lib/Kconfig b/lib/Kconfig
> index 706836ec314d..4059df9ec4c7 100644
> --- a/lib/Kconfig
> +++ b/lib/Kconfig
> @@ -170,6 +170,14 @@ config CRC32_BIT
>  
>  endchoice
>  
> +config CRC64
> +	tristate "CRC64 functions"
> +	help
> +	  This option is provided for the case where no in-kernel-tree
> +	  modules require CRC64 functions, but a module built outside
> +	  the kernel tree does. Such modules that use library CRC64
> +	  functions require M he

eh?  missing something here.

> +
>  config CRC4
>  	tristate "CRC4 functions"
>  	help
> 


-- 
~Randy