Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2750719imm; Mon, 16 Jul 2018 13:33:04 -0700 (PDT) X-Google-Smtp-Source: AAOMgpekVOgFj2CD/+5n2755P5PlSvg1NjSmHC8TEm/WFaUDGuOuHitwnIrmnUJ338y1995PztwE X-Received: by 2002:a63:f18:: with SMTP id e24-v6mr16935670pgl.320.1531773184040; Mon, 16 Jul 2018 13:33:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531773184; cv=none; d=google.com; s=arc-20160816; b=NdIlMMeui2T62KfasQTkZ6R4qwpWE5fdbHiv6Ktzb9tCcxKnn6/1kxRuSBD9k61SC6 I6MCMgoYvpdJT0KwFWI6T3fMsPqxxeIy3IvVauWg/25Oqo/eAENb3lDl8XahHo3buL8Q 7onVW0wt0nCD8bpUNa9eU+0Ts7m1vCDaGkJWvp1GT2RVEOTaW5S1WVeHFXmZ8dt6LOLX vGnlTLpFlMzFzqCAC/lFerJPfPDnylnTHJqc4glI4FOmKGEN5ZwwOZYCC1x9xtgqOD4M tJ8Q1Ey176mEa2ovRETsQeOoeCIc3Aq1UYRB4TjKe9PR3L9358+NtGrd0+QoMKgqMw2f 0B+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=CLeJaO8HLV3ngd6fMW8cOyS+puBqJuaQ0xduUqQhvI0=; b=q9TX+lyDer14R8wM4DMXUr4CxCG+NjttNmf9XIIcc7Jd4W9uitY94D2rEzoVyMLka9 vJLAGI/eiafYtPiHBb1kPQz3Vlj+zFf/4BG+fC6iWUJJdL8KGp6yD2gsRRPQUteNL76e HgG1/4Fp3BKHgIwqMEl5MJsIlUCdQVvEY0LfYFZzUoBay8kdJ1dQgOhaQHkoFtmU6tvi EBjyXaifgaed8FmeJOKjuyOoqlKXB/p0WovYKvVEdF17ySOKYGUt+T9xfy8WhcIAcgmF SfauuXStjPzHnfPIV8lJ7EPyi8EYPQMUQptH7sfpDAkx+3aySrHDEJdRvamYHhhOjPc2 9UBg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m8-v6si29918512plt.29.2018.07.16.13.32.48; Mon, 16 Jul 2018 13:33:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729910AbeGPVA3 (ORCPT + 99 others); Mon, 16 Jul 2018 17:00:29 -0400 Received: from smtp2.provo.novell.com ([137.65.250.81]:45509 "EHLO smtp2.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728290AbeGPVA3 (ORCPT ); Mon, 16 Jul 2018 17:00:29 -0400 Received: from linux-r8p5.suse.de (prv-ext-foundry1int.gns.novell.com [137.65.251.240]) by smtp2.provo.novell.com with ESMTP (TLS encrypted); Mon, 16 Jul 2018 14:31:23 -0600 From: Davidlohr Bueso To: herbert@gondor.apana.org.au Cc: linux-kernel@vger.kernel.org, dave@stgolabs.net, Davidlohr Bueso Subject: [PATCH] lib/crc10dif: Update crct10dif_fallback static key to modern api Date: Mon, 16 Jul 2018 13:31:15 -0700 Message-Id: <20180716203115.22248-1-dave@stgolabs.net> X-Mailer: git-send-email 2.16.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org No changes in semantics -- key init is false; replace static_key_slow_inc with static_branch_inc static_key_false with static_branch_unlikely Added a '_key' suffix to crc10dif_fallback for better self documentation. Signed-off-by: Davidlohr Bueso --- lib/crc-t10dif.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/crc-t10dif.c b/lib/crc-t10dif.c index 1ad33e555805..528b24249ddd 100644 --- a/lib/crc-t10dif.c +++ b/lib/crc-t10dif.c @@ -17,7 +17,7 @@ #include static struct crypto_shash *crct10dif_tfm; -static struct static_key crct10dif_fallback __read_mostly; +static DEFINE_STATIC_KEY_FALSE(crct10dif_fallback_key); __u16 crc_t10dif_update(__u16 crc, const unsigned char *buffer, size_t len) { @@ -27,7 +27,7 @@ __u16 crc_t10dif_update(__u16 crc, const unsigned char *buffer, size_t len) } desc; int err; - if (static_key_false(&crct10dif_fallback)) + if (static_branch_unlikely(&crct10dif_fallback_key)) return crc_t10dif_generic(crc, buffer, len); desc.shash.tfm = crct10dif_tfm; @@ -51,7 +51,7 @@ static int __init crc_t10dif_mod_init(void) { crct10dif_tfm = crypto_alloc_shash("crct10dif", 0, 0); if (IS_ERR(crct10dif_tfm)) { - static_key_slow_inc(&crct10dif_fallback); + static_branch_inc(&crct10dif_fallback_key); crct10dif_tfm = NULL; } return 0; -- 2.16.4