Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2789972imm; Mon, 16 Jul 2018 14:20:29 -0700 (PDT) X-Google-Smtp-Source: AAOMgpf7OpgIqDMBxeX29muYOXp4EHcyyEr9j9plLwN26VwxvlUxoNJ/mBvhM9Lp1lpTJGv1HAHP X-Received: by 2002:a62:4909:: with SMTP id w9-v6mr19856657pfa.154.1531776029034; Mon, 16 Jul 2018 14:20:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531776029; cv=none; d=google.com; s=arc-20160816; b=wfJbWoSaHjDGGwIA3IlhN/bRPK/46Mw/joQM6Hpqbj29NFcJ4Oh500PlBi5VCkj5Sh 9F5pSFRLGa3YjNR0i8N45HIsSJDdrc06FjEKbdUWH87Bx0qeDELv9SXn5RX551J7Prf1 6+IaGPWHjfo95WUAmBgNvkqGqpKXn+oq05nzQUGfP4b6NAQSTbqvzXLvQQdBqm2k++xI eMuN/hD/WldXEU1K7Twl/uW0mdI/sADO7Qz569B1tdnK3kI1iEWwwEnJEoRiaMI3JBkZ enGmJNTihm4ryaoSRutdn1/GsA+zoBoSzU7rywnEQHLlj2fNVEpsi0OrdLejvvxsrOy5 KtaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=LTJDll4DeaxHH2pBvgHfTa15N7od/nEhh36vPRD+geg=; b=yL0A4fSZHKgR22ZaMvFiPORLLhlXfjSa9GfcykgDDMArtqNduFiiVmvxlPK4jGWC/L VkaBpzXtgxa65IxS3mUCJp0pUdrKLU6Gn22cGlzc9ovcusteC3hY420N4W/KZ62yhoFl 6ig5jWoNR/K69yeK6xP5g/z4QdmAQEgPtXssbtS4LIFzDEhMXNCV5r5EzZMHW4z59alh bQME7CLvU6VgaXMhfbauGwXfXtsTYDs7IqdmOFcWSTHbSUpu8cE0G7CyxiUQFlksckI8 GnslznDkTS6E+KHYN0g+TX5bFI4H+2idAGPuQIr0+a49kez1JgO3SnU3n9GAwmRnb2Zm haCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=jvKLqHfn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u186-v6si1501113pfu.263.2018.07.16.14.20.13; Mon, 16 Jul 2018 14:20:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=jvKLqHfn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729881AbeGPVsM (ORCPT + 99 others); Mon, 16 Jul 2018 17:48:12 -0400 Received: from mail-yb0-f194.google.com ([209.85.213.194]:46041 "EHLO mail-yb0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728290AbeGPVsM (ORCPT ); Mon, 16 Jul 2018 17:48:12 -0400 Received: by mail-yb0-f194.google.com with SMTP id h127-v6so15993763ybg.12 for ; Mon, 16 Jul 2018 14:18:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=LTJDll4DeaxHH2pBvgHfTa15N7od/nEhh36vPRD+geg=; b=jvKLqHfn/NyQVzOPGuPVC1rI4F0S/A+XWB3mfoaTtuWkZFzz9P/ZREtXl6w8jF23Lq tVBtQlFqKlqkCzIT6BS13fR4DeVtwsKd2+TM+DeWisMcj40rtUssaHJba5u1mvsz1Gb7 GSmOucxy2HCdZ05j/EAggiOvPjeklw3NGASAbYV0dFGdkxnDDQeE3CAsAAY/yZAiye2c TgRF8bqEk1RzVAZh8rYOUIC5X/ue7gmzFYEtQ+bMrm4YWcnixrfqXTGp3BGE1T2MRkbG u/Q64Y3r7X4cWRyBhhW/mwuFB9Dp4h1Hn0po26T5LjwhOlDY/ZUe0DpOhUuZQtNk5WRs R12g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=LTJDll4DeaxHH2pBvgHfTa15N7od/nEhh36vPRD+geg=; b=hi9EULf0IMKK7wnCMJC345x/cnQtLoQ8ksPOcuV9u060Y3oLcWZT1TrNJys/AXUrn7 UujKvewFUZYpoWkaRYL3SXkYS5x7T3799/bthATU4EpDNjNqPD7YLXggVghH10POIbNT o71czxxGWWly/T730vbHKsrsw6YMQSuIWFIHgl6/fT38A63S6Ll09N3eaizTrhjumc0b qDyfuppxxTqii+Wo3qdsLEgIDTKd6SBc53t6T6DEy8Q5Mv8/RhNa5z8aL3BHicsdED4l 9Hm4m6FfMi3MTNFZoAe3BpkoDIgZpqCuY7y92kQIhUXky1mp36LL7Hqq7W9iZB3CHq2C /1Mg== X-Gm-Message-State: AOUpUlE6ZIYzJbXX40ik+QIkM3MSNawOdg9nDdK4TYPaJsMfKZtgS0Jc zx24znuCKc1szc/GSG5SU2vJWmn127lAdfvbFTY= X-Received: by 2002:a25:d181:: with SMTP id i123-v6mr4846482ybg.489.1531775937573; Mon, 16 Jul 2018 14:18:57 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a25:5e42:0:0:0:0:0 with HTTP; Mon, 16 Jul 2018 14:18:57 -0700 (PDT) In-Reply-To: References: <20180714055816.223754-1-toddpoynor@gmail.com> <20180714055816.223754-11-toddpoynor@gmail.com> From: Todd Poynor Date: Mon, 16 Jul 2018 14:18:57 -0700 Message-ID: Subject: Re: [PATCH 10/18] staging: gasket: gasket_open use container_of() To: Dmitry Torokhov Cc: Rob Springer , John Joseph , Ben Chan , Greg Kroah-Hartman , Zhongze Hu , Simon Que , Guenter Roeck , devel@driverdev.osuosl.org, lkml , Todd Poynor Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 14, 2018 at 1:15 AM, Dmitry Torokhov wrote: > On Sat, Jul 14, 2018 at 8:58 AM Todd Poynor wrote: >> >> From: Todd Poynor >> >> Use container_of(), drop unnecessary NULL check. >> >> Reported-by: Dmitry Torokhov >> Signed-off-by: Zhongze Hu >> Signed-off-by: Todd Poynor >> --- >> drivers/staging/gasket/gasket_core.c | 7 ++----- >> 1 file changed, 2 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/staging/gasket/gasket_core.c b/drivers/staging/gasket/gasket_core.c >> index ffd6ce801313..0c45c54254fb 100644 >> --- a/drivers/staging/gasket/gasket_core.c >> +++ b/drivers/staging/gasket/gasket_core.c >> @@ -1099,12 +1099,9 @@ static int gasket_open(struct inode *inode, struct file *filp) >> const struct gasket_driver_desc *driver_desc; >> struct gasket_ownership *ownership; >> char task_name[TASK_COMM_LEN]; >> - struct gasket_cdev_info *dev_info = gasket_cdev_get_info(inode->i_cdev); > > Are there other users of gasket_cdev_get_info()? if this was the only > one we should remove the macro,otherwise we should convert them as > well. No other users, I'll add a patch to remove it, thanks. > >> + struct gasket_cdev_info *dev_info = >> + container_of(inode->i_cdev, struct gasket_cdev_info, cdev); >> >> - if (!dev_info) { >> - gasket_nodev_error("Unable to retrieve device data"); >> - return -EINVAL; >> - } >> gasket_dev = dev_info->gasket_dev_ptr; >> driver_desc = gasket_dev->internal_desc->driver_desc; >> ownership = &dev_info->ownership; >> -- >> 2.18.0.203.gfac676dfb9-goog >> -- Todd